Thread: Print variable which only exists within for loop?

There's loads of problems with this. What I'm trying to do.

1) get a program to add the contents of an array together, preferably with a for loop and not the heavy handed version I've tried to use here.
2) get the for loop's output just once, since it won't compile or recognise the variable outside of the loop.
How do I make the loop's 'counter' variable available everywhere?

 
public class retint {
 
	public static void main(String[] args){
 
 
 
		int[] onetoTen = {1,2,3,4,5,6,7,8,9,10};
 
			for (int i=0; i<10; i++) {
 
				int counter = (onetoTen[0] + onetoTen[1] + onetoTen[2] + onetoTen[3] + onetoTen[4] + onetoTen[5] +
						onetoTen[6] + onetoTen[7] + onetoTen[8] + onetoTen[9]);
 
				System.out.println(counter);
 
 
		}
 
 
 
 
 
 
	}

Terrible code, I know. There has to be a more efficient way.

How do I make the loop's 'counter' variable available everywhere?

By declaring it outside of the loop.

By the way, I dont understand your calculation within the loop. You add all numbers 10 times?

Okay, thank you both that worked fine, does that mean that it needs to be declared in main only? I tried it in main and that worked, but would it work if it were to be declared in another method?

With the array, I'm basically trying to:
1. declare array of numbers 1 to 10
2. set up a for loop which cycles through the array and adds the elements together (such as 1+2+3+4+5+6+7+8+9+10)

I can make it print out the numbers from one to ten, like this:

public class retint {
 
	public static void main(String[] args){
 
		int[] onetoTen = {1,2,3,4,5,6,7,8,9,10};
 
 
			for (int i=0; i<10; i++) {
 
 
					System.out.println(onetoTen[0]++);
 
 
 
		}
 
 
 
 
 
 
	}
}

But it doesn't add them together. Obviously it won't based on the code but there must be a small modification I can make to get it to do that?

What you want to do is sum up the elements of the array.
Think about it without writing code. Try to write the steps down one by one on a piece of paper.
You have a list of numbers. You can always get 1 number at a time out of that list. How would you make the sum by hand?

When you thought about that think how you could translate that into java code.

	int[] onetoTen = {1,2,3,4,5,6,7,8,9,10};
			int sum = 0;
 
				for (int i=0; i<10; i++) {
 
 
 
						sum +=onetoTen[0]++;
						System.out.println(sum);

I think I've got it. I just needed to store the result in a new variable to make it manipulable. Thank you!

There are still a few small problems.

1) you should change your for loop to run until the end of the array instead of hardcoding a value:

// this is bad
for (int i=0; i<10; i++) {

// this is good !
for (int i=0; i<oneToTen.length; i++) {

2) You are not actually summing up all values in your array. You never use your variable i.

3) Why are you incrementing the values stored in the array?
This last part here, does not make any sense to me:

onetoTen[0]++;

But you've missed an important advantage of having a loop control variable. Consider this:

sum += onetoTen[i];

Also, your indentation is inconsistent. It should look like this (open brace on the for() statement line is an option):

int[] onetoTen = {1,2,3,4,5,6,7,8,9,10};
int sum = 0;
 
for (int i=0; i<10; i++)
{
    sum +=onetoTen[i];
    System.out.println(sum);
}

And don't use hard coded values (sometimes called "magic numbers") whenever possible. An improved for() loop condition would be:

for ( int i=0 ; i < onetoTen.length ; i++ )