Thread: Class Temperature, not sure about constructor/methods

For my class I need 4 constructors, one for every object variable (set value to 0 and unit to Celsius), one with 2 parameters for the 2 objectvariables and one without arguments, whereas 0 degreeC is initialized. I think I have the constructors right.

But I am not sure if my methods are right. I need to return Temperature (C and F); set Value, Unit or both; and return the Temperature in String. I've tried this and I think I am right but not too sure, may someone check?

[CODE = Java]
// object variables
	float Value;
	char Unit;
 
// constructors	
	Temp(float Value){	
		this.Value = Value;
		Value = 0;
	}
 
	Temp(char Unit){
		this.Unit = Unit;
		Unit = 0;
	}
 
	Temp (float Value, char Unit) {
		this.Value = Value; this.Unit = Unit;
	}
 
	Temp () {	Value = 0; Unit = 'C'; }
 
//now the methods:
 
        float getCelsius (float Value) {
		float Celsius;
		Celsius = Value;
		return Celsius; 
	}
 
	float getFahrenheit (float Value) {
		float Pre;
		float Fahrenheit;
 
		Pre = (9*Value/5)+32;
		Fahrenheit = Math.round(Pre*10f)/10f;
		return Fahrenheit;
	}
 
	void setValue (float V) {
		Value = V;
	}
 
	void setUnit (char U) {
		Unit = U;
	}
 
	void setBoth (float V, char U) {
		Value = V;
		Unit = U;
	}
 
	String tempToString (float Celsius, float Fahrenheit) {
		String c = Float.toString(Celsius);
		String f = Float.toString(Fahrenheit);
 
		return c + f;
	}

I think I am right but not too sure

What concerns do you have? Is the program's output OK?

One problem I see in the code is the naming of variables. Variable names should start with lowercase letters.

variables can be declared and given a value in one statement on a single line. No need to have two statements and lines:
float cel = value * 13.3;

What is in the variable named Value? The variable name should describe what the variable contains.

I am not sure what exactly is "set"

That is very important to know before trying to write any code.

What is in the variable: Value (it should be value)? Is it the temperature in degrees? Then a better name might be numberOfDegrees.
setValue should be named setDegrees
The contents of unit then says whether the degrees are Fahrenheit or Celsius
The get methods would need to look at unit to know what value was in numberOfDegrees to know whether or not it needed to be converted.

Also posted at: https://coderanch.com/t/730770/java/...ructor-methods

Please read this: http://www.javaprogrammingforums.com...s-posting.html