Thread: Is it OK to have a superclass just to hold variables common to their subclasses?

I have two classes that have no methods:

Weapon
----------
String name
int cost
int requiredStrength
int requiredDexterity
int minDamage
int maxDamage

Armor
---------
String name
int cost
int requiredStrength
int defenseRating

First question: is it OK to have a classes like this?
Second question: the variables 'name', 'requiredStrength', and 'cost' are common to both classes. Does it make sense to factor them out into a superclass, like the one below:

Equipable
----------
String name
int cost
int requiredStrength

third question: is it good practice to have a superclass just for the sake of factoring out common variables? And if so, is it better in this case to use protected access rather than private?

Originally Posted by jrahhali

First question: is it OK to have a classes like this?

Yes, they look fine. Nothing weird.

is it good practice to have a superclass just for the sake of factoring out common variables? And if so, is it better in this case to use protected access rather than private?

It's not always true, two or three classes may have some identical variables, it's trivial. No need to refactor for a superclass. But it depends on you, the designer of your program.