Thread: Question about ActionListener

What you mean by having 20 or so listeners? I'm not sure what Java's behavior is if you add a single object multiple times to the same object that's sending out ActionEvents, but I know that's completely unnecessary. However, if you have 2 different buttons, and you want your program to listen to both buttons, you MUST add your main program to the ActionListeners list of each button. Also, there's nothing wrong with having each button listen to each other, just make sure your main program isn't duplicating the actionsPerformed by these two buttons listening to each other.

Personally, I don't see anything wrong with that style-wise.

I have wondered this as well. I think it just depends upon how you wish to organize your code. I agree with helloworld...nothing at all wrong with doing it this way. This method does however seem harder to adapt (at least to me) should you wish to listen to the same command coming from different places. For example suppose you have a menu item and a button that you wish to perform the same action, you can adapt your inner classes to do this, but to me it seems a bit more difficult than just having a general listener that 'listens' to many different objects based upon action commands. In addition, creating a general listener makes it easier (easier at lest the way I see it) to take advantage of inheritance. For example:

//Parent Class
public class AppFrame extends JFrame implements ActionListener{
 
    public void actionPerformed(ActionEvent e){
        if ( e.getActionCommand().equals("Something") ){
            doSomething();
        }else  if ( e.getActionCommand().equals("Else") ){
            doElse();
        }
    }
}
//Child Class
public class NextFrame extends AppFrame implements ActionListener{
   public void actionPerformed(ActionEvent e){
        if ( e.getActionCommand().equals("Something") ){
            doSomthingElse();
            super.actionPerformed(e);
        }else{
            super.actionPerformed(e);
        }
    }
}

NextFrame can perform some action before allowing its parent class to act, and in addition NextFrame doesn't even have to worry about the "Else" command because it is passed onto the parent. Granted this can be accomplished either way you do it, I just find I can wrap my head around it easier this way

You want to be careful if you do that... the parent class doesn't necessarily have to implement ActionListener. Also, you have a totally unrelated class that may want to listen to that class's action events. I'd implement an addActionListener method in your class, and then send the event only to those that are listening to that panel.

ArrayList<ActionListener> toSendTo;
 
...
 
public void addActionListener(ActionListener listener)
{
     if (listener != null)
          toSendTo.add(listener);
}
public void actionPerformed(ActionEvent e){
        if ( e.getActionCommand().equals("Something") ){
            doSomthingElse();
            super.actionPerformed(e);
        }else{
            for (int i = 0; i < toSendTo.size(); i++)
            {
                 toSendTo.actionPerformed(e);
             }
        }
}

Originally Posted by helloworld922

the parent class doesn't necessarily have to implement ActionListener.

I think I'm misunderstanding the point you are making....can you clarify?

Originally Posted by helloworld922

Also, you have a totally unrelated class that may want to listen to that class's action events. I'd implement an addActionListener method in your class, and then send the event only to those that are listening to that panel.

Of course that would be one way if you want to have multiple listeners, although not the way I would want do it (but I rarely add multiple listeners so my experience in that realm is low)