Thread: balancedBracketsByCounting (String s) that checks brackets are matched in the String.

Hi, I need to write an algorithm balancedBracketsByCounting (String s), as follows, that takes a string as an input and checks whether the brackets "[" and "]" in the string are matched correctly.
For example, balancedBracketsByCounting("[x][[xy]]") would return true but balancedBracketsByCounting("[[x[y]]") would return false.

Do I need to use stack or queue?

Please assist!
Thanks.

Sorry, was trying to get fast response and resolve the problem.

Another testing done. This time round is smooth testing. All the way test by entering new figure instead of hard-coding.

 
    public static void main (String args [])
    {
        boolean test = true;
        while(test)
        {
            BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); 
            System.out.println("Enter test data: ");
            try
            {
                String input = reader.readLine();      
                boolean result = balancedBracesMethod (input);
                System.out.println(result);
            }
            catch (IOException e)
            {
                System.out.println("An unexpected error occured."); 
            }
        }
    }

Hope I can get feed back on improving the program code, and make improvement.

Originally Posted by KevinWorkman

I get that. Other members may feel inclined to continue to help you despite the crossposting, but I for one will be spending my time elsewhere. To understand why, please read this: http://www.javaprogrammingforums.com...s-posting.html

Got it sorry!

Hmm, I am pretty new to how this works?
Are both the forum linked?
Meaning to say that both forum registered account users are able to help you?

Hmm, also does it mean that posting on the forum you are definitely expected to receive free help? Because I am afraid to limit myself and wait for help on one forum, and no one appear to give you help.

Thanks for letting me know.

If I limit myself to posting in one forum, and indicate in another forum as cross-posting, will that be alright?

Latest program:

import java.util.*; 
import java.io.*; 
 
public class balancedBraces
{
    public static boolean  balancedBracesMethod (String s)
    {
        int myLength = s.length();
        Stack st = new Stack();
        char d;
 
        for (int i=0;i<s.length();i++)
        {
            char c = s.charAt(i);
 
            if (c == '(')
            {
                st.push(new Character(c));
            }
            else if (c == '[') 
            {
                st.push(new Character(c));
            }
            else if (c == '{')
            {
                st.push(new Character(c));
            }
 
            else if (c == ')')
            {
                if (st.empty())
                {
                    return false;
                }
                else
                {
                    d = (Character) st.pop();
                    if (d != '(')
                    {
                        return false;
                    }
                }
            } 
            else if (c == ']')
            {
                if (st.empty())
                {
                    return false;
                }
                else
                {
                    d = (Character) st.pop();
                    if (d != '[')
                    {
                        return false;
                    }
                }
            }
            else if (c == '}')
            {
                if (st.empty())
                {
                    return false;
                }
                else
                {
                    d = (Character) st.pop();
                    if (d != '{')
                    {
                        return false;
                    }
                }
            }
        }
 
        if (st.empty()) return true;
        else return false;
    }
 
    public static void main (String args [])
    {
        boolean test = true;
        while(test)
        {
            BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); 
            System.out.println("Enter test data: ");
            try
            {
                String input = reader.readLine();      
                boolean result = balancedBracesMethod (input);
                System.out.println(result);
            }
            catch (IOException e)
            {
                System.out.println("An unexpected error occured."); 
            }
        }
    }
}

Please help to comment and check if there any problem.

Cross-posted: Java method that check brackets in String are matched? - Java Forums

Hope someone will take a look and help comment to see if everything work fine.
Thanks, been a few days already and no one commented or reply.

Thanks for all comment and reply.

Originally Posted by KevinWorkman

Like I said, people don't love wasting their time on crossposters. I see you're still posting to the other forum, and I see that you haven't really responded to any of the suggestions you received in either forum. All of those things are very good ways to make sure people don't want to reply.

I have mention it is a cross-posted thread.

Before requesting for help, I waited for a few day before posting again.

What are the suggestion I receive with regard to the program code that I haven't change or edited?

Originally Posted by helloworld922

From a quick scan-through it looks like it works. Have you tested it thoroughly? Designing a good test structure is as important if not more important than the actual program itself. Try running it on fragments you know will work and ones you know won't work. If you've done that, than it's probably a fairly safe bet that the code works as intended.

The last thing I can think of is to comment your code, as well as pick logical names for your variables. Variable names such as c and d can be difficult to decipher what they're being used for.

Thank you very much.
Very helpful comment. Will test it part by part and will change the variable names.

By the way, I am also requires to write the algorithm that outline the codes. Do you all know where to find the proper syntax in writing the algorithm?

I know a bit about how to write the algorithm, not sure if I am right:

1. No ' ; ' to be uses as it is use in different programing language and have different meaning.
2. They look very similar to java coding.

Are there many ways which you can write an algorithm?

To: KevinWorkman and helloworld922

Thanks for the advice.

My problem is resolved.