Thread: Printing highest number of array. Can't find my error.

Hi all. Your's truly here again. Hope everyone is doing well. Alas, I'm having trouble pointing out what I'm doing wrong here with this little program I'm writing for class. What I need to do is ask the user to input numbers, store them in an array of ten, and then display the largest one. Simple enough I thought. But when I run my program, it just keeps displaying '2' as the largest entry no matter what. I was really happy with the speed at which the code poured out of my n00b brain that I'm really disappointed it's not working. Any thoughts would be appreciated.

import javax.swing.JOptionPane;
 
public class PeerProgram3
{
	public static void main(String[] args)
	{
		final int TOTAL = 10;
		String input;
		String newInput;
		int[] numbers = new int[TOTAL];
 
 
		JOptionPane.showMessageDialog(null,"I'm going to ask you to input 10 numbers.");
		input = JOptionPane.showInputDialog("Please enter a number:");
		for (int index = 1; index < TOTAL; index++)
		{
			newInput = JOptionPane.showInputDialog("Please enter another number");
			numbers[index] = Integer.parseInt(newInput);
 
		}
		int highest = numbers[0];
		for (int index = 1; index < TOTAL; index++)
		{
			if (numbers[index] > highest)
			highest = numbers[index];
			JOptionPane.showMessageDialog(null, "The highest number you entered is " + highest + ".");
			System.exit(0);
		}
 
 
	}

Don't be in a rush to code. Have a plan! and be able to express it in ordinary English before coding.

input = JOptionPane.showInputDialog("Please enter a number:");
for (int index = 1; index < TOTAL; index++)
{
    newInput = JOptionPane.showInputDialog("Please enter another number");
    ...

Here you appear to be asking the user for an input but then do absolutely nothing with it. It seems to me that a plan or "recipe" for this problem will only involve one thing that you refer to as "input": you get the input, you deal with the input, you move on. There isn't really a need for an input and a newInput.

for (int index = 1; index < TOTAL; index++)
{
    if (numbers[index] > highest)
    highest = numbers[index];
    JOptionPane.showMessageDialog(null, "The highest number you entered is " + highest + ".");
    ...

Here you are displaying something every time you go around the loop. That can't be right. Go round the loop until, at the end of the array you know what the largest value is. And then, after the loop has finished, display the message.

Thanks pbrockway2. Yeah, it's not really as well put together as I thought, now that I look at it. I wasn't really rushing through it, I was just hoping that because the code seem to pour from my finger tips, I was really catching on.