Thread: New Recursion problem need lil help

this program is supposed to add up the integers in a number entered by a user and print out the sum. i got the easy part down.

 if(number<10)
{
sum=number;
 }

for the next part i was thinking about storing the value of each integer in an array by using mod operator then then addin them all up. any suggestions or psuedo code to help???

Changed my mind not gonna use an array, ive decided to do something like this but its not really working and i kno why but i dnt know how to change itm

while(number>10)
{
digit=number%10;
sum = digit; 
}

what i want to do is save the last digit so i can keep incrementing the sum value with whatever the integer is but idk how i can save the last integer pissibly a variable, but how???

Nvm all i got it

yes thats exactly it and I fear i thought i got it but i didnt still need some help lol

thats the new code but yea its a logical error in there somewhere

Originally Posted by Delstateprogramer

thats the new code but yea its a logical error in there somewhere

Are you sure that you get your number when you use " / " maybe it is better this " % ".

OK perhaps if you explained a bit better what exactly you are trying to do. I am guessing you want to find the sum of the digits of an integer not the sum of integers of a digit first of all declare your variables above your main method I can't remember if you are allowed to declare them elsewhere but if you are it's still good practice to put them at the start of the class.

Secondly I'm guessing that it can only be a 1 or 2 digit number(1 to 99) in which case you don;t have to do anything particullarly clever and you can do it with an if statement.

So lets look at your code

    if(number<10)
    {
        sum=number+digit;
    }
    else

This part: you are setting sum to number plus digit but what is digit at this stage? It should give the right result but it's not what you'd call good programming.

    else
 
    {
        if(number>10)
        {
        digit=number/10;
 
        sum=digit;
 
        number=sum;
     adddigits(number);
 
        }
       return  sum;
 
        }
    return sum;
}

This runs whenever it's greater then 10 anyways so you don't need the nested if statement(if you want to provide some checks say make sure the number is between 1 and 99 then that's a different story)

But anyways this part
digit = number/10
Say the number is 57 that will make digit 5 fair enough but after that

        sum=digit;
        number=sum;
     adddigits(number);

That code is will do the exact same thing as

adddigits(digit)

Because you are essantially setting sum to 5 and then number to five and calling that method. The mehtod call by the way is just going to run it as 5 and you probably end up getting 10 if I'm reading this right because you've set digit to 5 and you're passing the method 5 and it's the same object.

But anyways why don't you write up a bit of pseudocode and see what exactly you want to do and then post it here and we can see if you understand the logic. From there we can give you some more advice. Also it's best if you provide 1 or 2 example inputs and outputs.

I didnt intend for it to be a number 1 through 99. It would not matter what the user put in. and yes it would add the digits in an integer. Heres an example.

If the user entered the integer 223 the output would be "The sum of the digits in this integer is 7"

Heres a mild attempt at psuedo code


if (number<10)
sum= number

else
sum=sum of digits in number
return sum

or something like that

The user should be able to enter any integer and the program should output the sum of the digits in the integer.

number = 224;

When you see this number you know that sum is 8.. So how did you calculate it?

1° number = 224

(224 < 10) = false

224 % 10 = 4 "digit = 4"

(224 - 4)/10 = 22


2° number = 22

(22 < 10 ) = false

22 % 10 = 2 "digit = 2"

(22 - 2) / 10 = 2



3° number = 2

(2 < 10) = true "digit = 2"

And after this you sum all digits. So my best advice for yo would be draw algorithm first for recursion then later code.

Originally Posted by Davidovic

number = 224;

When you see this number you know that sum is 8.. So how did you calculate it?

1° number = 224

(224 < 10) = false

224 % 10 = 4 "digit = 4"

(224 - 4)/10 = 22


2° number = 22

(22 < 10 ) = false

22 % 10 = 2 "digit = 2"

(22 - 2) / 10 = 2



3° number = 2

(2 < 10) = true "digit = 2"

And after this you sum all digits. So my best advice for yo would be draw algorithm first for recursion then later code.

how do i save the prior digits to add them up at the end becuz here they keep changing and are not saved so they cant be added at the end

Originally Posted by Delstateprogramer

how do i save the prior digits to add them up at the end becuz here they keep changing and are not saved so they cant be added at the end

Can you post the code for that?

sum=sum of digits in number

What is the pseudo code for "sum of digits in number"?
That's just a restatement of what the whole program is supposed to do.
Your recursion needs to get the 'current' digit and add to it the sum of digits for the remaining digits (ie without the current digit)

Ok thx ill try that out

addDigits(number);

You don't use the value returned by the addDigits() method called here?

lol the code works and that all that matters