Thread: Nested 'If' Statements

Hello again, all,

I am in the process of creating a calculator GUI that calculates different answers based on inputs two main comboboxes and numbers in the appropriate textfields. The first one allows the user to choose from 18 different materials, while the second has the user choose between two different shapes. In a brief word explanation, here's how it's set up:

User chooses material.
User chooses shape.
User types in appropriate values.
'Calculate' button clicked.
If shape = rectangle, execute rectangle calculation.
Else if shape = cylinder, execute cylinder calculation.

Everything works just fine with zero errors on all 18 materials and all kinds of decimal numbers when the second shape is selected. So the math and layout is solid. However, when the first shape is selected, it returns a $0.00 answer regardless of the input values (still no red-line errors). In efforts to troubleshoot, when I have
/* Cylinder section */, the rectangle section works to a 'T'. This, I believe is caused by poor formatting in the syntax of the 'if' 'else if' in regards to the shape combobox. But, I'm not sure how to correctly format it to fix the issue. Here is a sample of the coding, if you need more I can provide it, but it's rather lengthy. Any help is much appreciated!

//If 'Rectangle' is selected:
      if(shapeDropDown.getSelectedIndex()==1) {
      //6061
      if(materialDropDown.getSelectedIndex()==0) {
          String  msg0 = "The price is: $"
              + currencyFormat.format((0.098*(number2*number3*number4)*3.06));
                totalPrice.setText(msg0);               
      } 
       //2024
      if(materialDropDown.getSelectedIndex()==1) {
          String  msg1 = "The price is: $"
              + currencyFormat.format((0.1*(number2*number3*number4)*5.61));
                totalPrice.setText(msg1);
      }
 
...
 
 //If 'Cylinder' is selected:
    } else if(shapeDropDown.getSelectedIndex()==2); {
      //6063 
      if(materialDropDown.getSelectedIndex()==0){
           String  msg0c = "The price is: $"
              + currencyFormat.format(((0.098*(((number1/2)*(number1/2))*3.14159*number2))*3.06));
                totalPrice.setText(msg0c);}
       //2024
     if(materialDropDown.getSelectedIndex()==1){
           String  msg1c = "The price is: $"
              + currencyFormat.format(((0.1*(((number1/2)*(number1/2))*3.14159*number2))*5.61));
                totalPrice.setText(msg1c);} ...

Isn't there a zero index for the shape selected dropdown? Show that code.

The zero index simply says "Choose Shape" and is not coded. As far as I can tell, it hasn't affected the rest of the program.

I should put an error message in there if the end user leaves it like that, but holding off on that until I get this ironed out.

The cylinder if() statement has a semicolon at the end.

You've got to be kidding me...

Wow. Newer to this than I thought!

I figured it had to be something simple. Oy vey. It works now, thanks so much!

I dont even know why java allows stupid things like that. Sometimes one has to wonder what the people were thinking when they wrote the ruleset.

Originally Posted by Cornix

I dont even know why java allows stupid things like that. Sometimes one has to wonder what the people were thinking when they wrote the ruleset.

Yeah, there weren't any red lines or anything. I just skipped over it when writing it the first time and never saw it again.

Originally Posted by Norm

Add the -Xlint option to the javac command and you'll get a warning.
Don't have your IDE suppress warnings.

Definitely keep that in mind for the future, thank you.