Thread: old object take variabile from the new issue

Originally Posted by Norm

How are you debugging the code to see what it is doing and why its output is not what you want?

Where in the code is the output generated?
Where does that coded get the data that is printed?

I use eclipse, with his debugger.

the output is generated on Class StrausParser, method: importBeams (line 95)

the code that generate the output take the data from the method where it is, and from the arraylists called element and node from structure class

Originally Posted by Norm

I can't help you to use the IDE's debugger.
I use println statements for my debugging. I would print out the values of the variables that the code uses to create the report that is wrong. That print out would show where the code is going wrong.
Some choices would be:
the data passed to the method that creates the report is wrong
the method makes mistakes when it creates the output from the data
or both of the above.

Is the data that is passed to the method that creates the report correct?


I do NOT see where the output you posted comes from in the code. The importBeams() method has ONE println() with text and numbers, not just numbers:

			System.out.println("index: " + indiceelemento + " ndElem: " + nodoelemento + " extr1 " + nodiestremi[0].getIndex() + " " + nodiestremi[1].getIndex());

Where is the output from that println?

the output is this:

index: 0 ndElem: 0 extr1 0 1
index: 0 ndElem: 1 extr1 1 2
index: 0 ndElem: 1 extr1 1 0
index: 0 ndElem: 2 extr1 2 4

i have added some text in the meanwhile for avoid to do confusion , but the numbers (that matters) are the same

the output that i search is that:

index: 0 ndElem: 0 extr1 0 1
index: 0 ndElem: 0 extr1 1 2
index: 0 ndElem: 0 extr1 1 0
index: 0 ndElem: 0 extr1 2 4

that is the index of the node passed to the first Beam remain the same when i add other beam


the data used by the method are correct.

Originally Posted by Norm

Are the values of the ndElem what is wrong?
Is everything else correct?

if i check the value of ndElem that is nodoelemento that is structure.element.get(a).getNodes()[0].getIndex(); with the debugger it is correct.

the problem is that when a new beam is created, the node of all oldest beam are overwritten with the node of the new beam

Originally Posted by Norm

Can you print out the values that you are talking about to show what is happening?


Are you talking about this array: Node[] nodiestremi?
The code only defines one instance of that array and overwrites it each time around the loop. Move the definition inside the loop so a new array is created each time.

i rewrite the method importBeams with some system print:

	public  void importBeams() throws IOException{  
		Node[] nodiestremi = new Node[2];
		int index = 0;		
		int propNumber = 0 ;
		int a = 0;
 
		while ((string.contains("Beam") != true)){
			string = scanner.next().trim();
		} 
 
		while ((string.contains("Beam") == true)){
			String[] line = string.split("\\s+"); 
 
			for (int i = 0 ; i < 2 ; i++){
				nodiestremi[i] = structure.nodes.get(Integer.parseInt(line[i+4])-1); 
			}
 
 
			if (Integer.parseInt(line[3]) != propNumber){
				propNumber = Integer.parseInt(line[3]);
				structure.section.add(new Section());
			}
 
			index = Integer.parseInt(line[1])-1;		
 
			structure.element.add( new Beam(index, structure.section.get(propNumber-1) , nodiestremi) );
 
			//index node that i put on new beam 
			System.out.println("index nodiestremi on beam with index: " + a + ": "+ nodiestremi[0].getIndex() +" " +nodiestremi[1].getIndex());
 
			int nodoelemento = structure.element.get(0).getNodes()[0].getIndex();
			int nodoelemento1 = structure.element.get(0).getNodes()[1].getIndex();
 
			System.out.println(" index of node on beam 0: " + nodoelemento + " "+ nodoelemento1);
			string = scanner.next().trim();
			System.out.print("\n");
			a++;
		} 
		System.out.println("Import beam complete");
	}

the output is this:

index nodiestremi on beam with index: 0: 0 1
index of node on beam 0: 0 1

index nodiestremi on beam with index: 1: 1 2
index of node on beam 0: 1 2

index nodiestremi on beam with index: 2: 1 0
index of node on beam 0: 1 0

index nodiestremi on beam with index: 3: 2 4
index of node on beam 0: 2 4

as you can see, the index of node on beam 0, change every time i create a new Beam

Originally Posted by Norm

The posted code in post#15 does not fix the problem I talked about in post#14.

Add some more debug code to print out the contents of the object returned by:

structure.element.get(0)

so you can see if the contents of that object is being changed or not.

I move the definition inside the loop and the problem disappear...

i'm sorry for taking you busy with a stupid problem like this

thanks a lot