Thread: exercise 229

Hi, so this exercise has two separate sections of editable code. The assignment is to fix the two errors. Do I need to create a getter method to get rid of the error? Here are the full instructions:

The following code segment overrides the processActors method to implement BlushingActor, but it contains two errors, one of which causes a compile-time error and the other of which will sometimes cause a runtime exception. Study the code and correct the errors. Test that your corrected definition gives rise to Actors that behave in the manner described above.

Here is my attempt at fixing the first error in section 1:

public class BlushingActor extends Critter
{
  public void processActors( ArrayList<Actor> actors )
  {
    Color c = getColor();
    int red = c.getRed();
    int green = c.getGreen();
    int blue = c.getBlue();
    if ( actors.size() > 0 )
      red = 255;
      green = 235;
      blue = 110;
    else
      red = Math.min( 0, red - 10);
    setColor( red, c.getGreen(), c.getBlue() );
  }
}

And here is section 2:

Actor alice = new Bug(),
      blusher = new BlushingActor();
 
blusher.setColor( Color.BLACK );
 
(new Rock()).putSelfInGrid( grid, new Location( 3, 5 ) );
(new Rock()).putSelfInGrid( grid, new Location( 0, 10 ) );
(new Rock()).putSelfInGrid( grid, new Location( 7, 16 ) );
(new Rock()).putSelfInGrid( grid, new Location( 15, 19 ) );
(new Rock()).putSelfInGrid( grid, new Location( 19, 2 ) );
 
alice.putSelfInGrid( grid, new Location( 5, 3 ) );
blusher.putSelfInGrid( grid, new Location( 7, 7 ) );

I get this error when I try to run it:

"error 'else' without if"

That's different from the original error, but am I just messing this code up further?

Oh, and for section 1, I think I can give you the original code:

public class BlushingActor extends Critter
{
  public void processActors( ArrayList<Actor> actors )
  {
    Color c = getColor();
    int red = c.getRed();
    if ( actors.size() > 0 )
      red = 255;
    else
      red = Math.min( 0, red - 10);
    setColor( red, c.getGreen(), c.getBlue() );
  }
}

It's still not working. Here's what I've edited it to:

public class BlushingActor extends Critter
{
  public void processActors( ArrayList<Actor> actors )
  {
    Color c = getColor();
    int red = c.getRed();
    int blue = c.getBlue();
    int green = c.getGreen();
    if ( actors.size() > 0 ){
      red = 255;
      blue = 235;
      green = 235;
    }
    else
      red = Math.min( 0, red - 10);
    setColor( red, c.getGreen(), c.getBlue() );
  }
}&#65279;

--- Update ---

I think the brace should be AFTER the else statement, but I've had to take a short time off. Any quick review tutorials for me to read that might help?

KW's answer still applies, but in a more general sense: Enclose ALL clauses inside curly brackets, "{}".

Obviously, that includes else statements. Alright, so here's what I have now:

public class BlushingActor extends Critter
{
  public void processActors( ArrayList<Actor> actors )
  {
    Color c = getColor();
    int red = c.getRed();
    int blue = c.getBlue();
    int green = c.getGreen();
    if ( actors.size() > 0 ){
      red = 255;
      blue = 235;
      green = 235;
    else
      red = Math.min( 0, red);
      blue = Math.min(0, blue);
      green = Math.min(0, green);
    }
    setColor( c.getRed(red), c.getGreen(gren), c.getBlue(blue) );
    }
}

That's at least for the top box, which is what really matters I think.

That construct is certainly giving you errors. if and else are separate clauses. A proper else statement is not included inside the if clause.

Alright, so I'll take the else statement out. Here's what I have now:

public class BlushingActor extends Critter
{
  public void processActors( ArrayList<Actor> actors )
  {
    Color c = getColor();
    int red = c.getRed();
    int blue = c.getBlue();
    int green = c.getGreen();
    if ( actors.size() > 0 ){
      red = 255;
      blue = 235;
      green = 235;
    }
    else
      red = Math.min( 0, red);
      blue = Math.min(0, blue);
      green = Math.min(0, green);
    setColor( c.getRed(red), c.getGreen(green), c.getBlue(blue) );
    }
}

But here's the thing. I still get this error:

error: method getRed in class cannot be applied to the given types
 
setColor (c.getRed(red), c.getGreen(green), c.getBlue(blue));

--- Update ---

And I get the same thing if I take the parameters out of the part described in the error message, from the getters

Why are you just guessing what to do? You're better than that. The construct is:

if ( condition )
{
    // the body of the if clause goes here
}
else
{
    // the body of the else clause goes here
}

The error is telling you that you're not calling the getRed() method correctly. The parameter you're supplying are not those expected by the method. Review the method's signature, the API if necessary, and adjust your code to comply with the method's requirements.

This is not new stuff to you.