Thread: Adding operands and operators to Arrays.

Hi, I'm building a calculator and I need to take input from the user, and put the operators and operands in separate arrays. So far I have managed to split the input up by using operators and regex.

Here is my code:

]import java.util.ArrayList;
import java.util.Arrays;
import java.util.Scanner;
 
public class calcTester {
 
		public static String userInput()
		{
			System.out.println("Please enter a string to be evaluated: ");
			String stringEntered;
			Scanner keyboardInput = new Scanner(System.in);
			stringEntered = keyboardInput.nextLine();
			keyboardInput.close();
			return stringEntered;
		}
 
		public static String stringCalculator(String userInput )
		{
			return (userInput.replaceAll("\\s+", "").trim());	//removes space from user input
		}
 
 
		public static String parseInput(String stringCalculator)
		{
			String stringCalc = stringCalculator;
			String[] splitCalc = stringCalc.split("(?<=[-+*/])|(?=[-+*/])");
			return Arrays.toString(splitCalc);
		}
 
		ArrayList<int[]> calcOperands = new ArrayList<int[]>();
		ArrayList<String> calcOperators = new ArrayList<String>();
 
 
		public static void main(String[] args)
		{
			System.out.println(parseInput(stringCalculator(userInput())));
		}
}

When I run it and enter, for example - "10+5*3" what is returned is "[10, +, 5, *, 3]"

So what I am trying to do now is add the integers to the ArrayList calcOperands and the operators to the ArrayList calcOperators but I'm struggling to do this. Any help is greatly appreciated.

Thanks!

Sorry, I'm not sure exactly what you mean. I've already got the input split in to an array so what I really want to do is take all the characters that are +-/* from the array and put them in the operator array and all the integers and put them in the operand array but I don't know how to do this? Can you point me in the right direction?

Thanks!

I've spent some time researching how to do it and I've come up with something but I've got a few issues. Here's the code:

 
		public static Object[] parseInput(String stringCalculator)
		{
			String stringCalc = stringCalculator;
			String[] splitNumbers = stringCalc.split("[-+*/]");  //splits on operator but leaves the operand in
			String[] splitSymbols = stringCalc.split("[0-9]");    //splits on operand but leaves operator in
 
 
			ArrayList<String[]> calcOperators = new ArrayList<String[]>();
			calcOperators.add(splitSymbols);
 
			ArrayList<String[]> calcOperands = new ArrayList<String[]>();
			calcOperators.add(splitNumbers);
 
			return new Object[]{calcOperators, calcOperands};
		}

The problems I'm having is that I don't know how to test to see if the operators and operands have actually been added to the array because if I try and print them I get an error like this "[Ljava.lang.Object;@544b02".

I also need to be able to use both arrays in other methods and I've tried to return both, but then I still don't understand how I can use them in other methods.

Thanks for the help!

When I'm trying to print using that I'm getting the error "The method toString(long[]) in the type Arrays is not applicable for the arguments (ArrayList<String[]>)"

Eclipse is suggesting I change to deepToString but when I do that there is still an error and it tell me to change back to toString, what it was before.

Sorry I'm not sure I understand you when you say it needs to be an array not an arrayList? Surely it's better to use an ArrayList as I don't have to define how big it is?

Here is my code incase I've made some error and that's why the print isn't working:

		public static Object[] parseInput(String stringCalculator)
		{
			String stringCalc = stringCalculator;
			String[] splitNumbers = stringCalc.split("[-+*/]");  //splits on operator but leaves the operand in
			String[] splitSymbols = stringCalc.split("[0-9]");   //splits on operand but leaves the operator in
 
 
			ArrayList<String[]> calcOperators = new ArrayList<String[]>();
			calcOperators.add(splitSymbols);
 
			ArrayList<String[]> calcOperands = new ArrayList<String[]>();
			calcOperators.add(splitNumbers);
 
			System.out.println(Arrays.toString(calcOperators));
			System.out.println(Arrays.toString(calcOperands));
 
			return new Object[]{calcOperators, calcOperands};
		}

Thanks!

Ok, i've read what you said and realised that you can't print an ArrayList like that. I've also read about printing an arrayList using a for loop and I've tried that but it's still printing correctly.

Here's my new code:

		public static Object[] parseInput(String stringCalculator)
		{
			String stringCalc = stringCalculator;
			String[] splitNumbers = stringCalc.split("[-+*/]");
			String[] splitSymbols = stringCalc.split("[0-9]");
 
 
			ArrayList<String[]> calcOperators = new ArrayList<String[]>();
			calcOperators.add(splitSymbols);
 
			ArrayList<String[]> calcOperands = new ArrayList<String[]>();
			calcOperators.add(splitNumbers);
 
			int n = calcOperators.size();
			for (int i = 0; i < n; i++)
				System.out.println(calcOperators.get(i));
 
 
			return new Object[]{calcOperators, calcOperands};
		}

And when I run it this is what prints out:

[Ljava.lang.String;@18c5b4f
[Ljava.lang.String;@1beb7ec
[Ljava.lang.Object;@1cfb56

I also added this line in to see how long the ArrayList was:

System.out.println(calcOperands.size());
System.out.println(calcOperators.size());

And no matter what the input was, be it, 1+1+1+1+1+1+1+1+1 or 3/4*5+7-6+2 then length of the operands ArrayList would always be 0 and the length of the Operators arrayList would always be 2. Does that means that the ArrayLists aren't working as they should?

Originally Posted by Norm

That is the String from a String array.

Have you tried printing the contents of these arrays: splitNumbers and splitSymbols

I think I've finally figured it out, but I'm not completely sure. I think I've got both the operands and operators in arrays, but as I've used different ways to get them in to the arrays I'm not sure if they're both actually in Arrays. Would it be OK if you had a quick look at the code for me?

	public static void parseInput(String stringCalculator)
	{
		String[] operand= stringCalculator.split("([-+*/])");			
		String operator = stringCalculator.replaceAll("[0-9]", "");
 
		System.out.println("Arraylist operands contains: " + Arrays.toString(operand));
 
		ArrayList<String> calcOperators = new ArrayList<String>();
		calcOperators.add(operator);
		System.out.println("Arraylist operators contains: " + calcOperators.toString());  
 
 
	}

When the input of "1+2*3-4/5+6" is inputted the output is:

Arraylist operands contains: [1, 2, 3, 4, 5, 6]
Arraylist operators contains: [+*-/+]

Thanks for all the help!