Thread: Two characters trancated

Hi,

I have following method that adds passed arrays of txt files to zip. The method was working fine until I added a condition if (in.read() != -1){} that checks if a file is empty and skip it.
That works but, in every file added to a zip now first two characters on the first line are truncated like that
0000234...
P00000434...
P00000254...

instead of

P00000234...
P00000434...
P00000254...

Here is the method:

public void compressFiles(String[] fileArray, String zipFileName){
        byte[] buf = new byte[1024];
        try {
           // Create the ZIP file
            String outFilename = zipFileName;
 
            ZipOutputStream out = new ZipOutputStream(new FileOutputStream(outFilename));
 
            // Compress the files
            for (int i=0; i < fileArray.length; i++) {
	            FileInputStream in = new FileInputStream(fileArray[i]);
 
                if (in.read() != -1){   // check if a file is not empty
                    // Add ZIP entry to output stream.
                    out.putNextEntry(new ZipEntry(fileArray[i]));
 
                    // Transfer bytes from the file to the ZIP file
                    int len;
                    while ((len = in.read(buf)) > 0) {
                        out.write(buf, 0, len);
                    }
 
                    // Complete the entry
                    out.closeEntry();
                }
                in.close();
            }
            // Complete the ZIP file
            out.close();
         }
         	catch (IOException e) {
 
         }
    }

Any help is greatly appreciated.
Thanks,
Gena

You are reading the first byte(s) of the file to check if it is empty or not. If not, you then start to read and write the file from that point on...in other words, your code skips the first bytes read due to your initial check. If it is not -1, you should write those bytes to the file.

For future reference, please use the code tags.

Calling in.read() reads the byte, but your code does nothing with the read byte. If there is a byte read, you should do something with it:

byte firstByte = in.read();
if ( firstByte == -1 ){
//skip
}else{
///write the first byte to the file
///Continue to read the rest of the file. 
}

And never, ever let exceptions fall through...

catch (IOException e) {
//Better do something here, or you will never know an error occurred.
}

...at the least print the stack trace