Thread: What wrong with my code? count++ isnt incrementing.

Im working on a NxN tic tac toe game and making recursive function to check the position.
The recursive function uVertical is working correctly, however, the count++ on dVertical check is not being increment (it the same method as uVertical but it going in the opposite direction).
Please help im totally lost.

	//check Up Vertical
	public static int uVeritcal(int row, int col, int count)
	{
		if(row == 0)
			return count;
		else if(board[row-1][col].equals("X") && count < 4)
		{
			count++;
			return uVeritcal(--row, col, count);
		}
		else
			return count;
	}
	//check down Veritcal This function check the board to see if there 4 X located below the initial location. 
	public static int dVeritcal(int row, int col, int count)
	{
//SOP always return 0 here.
		if(row == boardSize - 1)
		{
			return count;
 
		}
		else if(board[row+1][col].equals("X") && count < 4)
		{
			count++;
//SOP return 1
			return rHorizantal(++row, col, count);
		}
		else
		{
			return count;
		}
	}
	public static void winner(int move) //move is the location of the board
	{
		int row = move / boardSize;
		int col = move % boardSize;
		if(uVeritcal(row, col, 0) + dVeritcal(row, col, 0) >= 4)
			gameOver = true;
	}

You might have a combination of two misunderstandings here.

First, changes you make to a local variable don't "stick". What I mean by that is:

public static void main(String... args){
   int x = 7;
   increment(x);
   System.out.println(x);
}
 
public static void increment(int x){
   x++;
}

What do you think that prints out?

The other is that the ++ operator returns the original value, not the incremented value. Try this:

public static void main(String... args){
   int x = 7;
   System.out.println(x++);
   System.out.println(x);
   System.out.println(++x);
   System.out.println(x);
}

That's why you shouldn't pass x++ in as an argument to anything. Do the incrementing, then use it. Don't try to take shortcuts.

Originally Posted by godofdoom999

Thank for the fast response, I just updated the code ... just found out i had count++ in the return function. however, I have count++ above the return that should have incremented count before return the statement. Using your first example as shown below.

	public static void main(String... args){
		   int x = 7;
		   System.out.println(increment(x));
		}
 
		public static int increment(int x){
			x++;
			return x;
		}

That code would print out 8.

Originally Posted by godofdoom999

yup that what dVertical should be doing but it not ... kinda weird considering dVertical and uVertical is the same code going in different direction.

I suggest you put together an updated SSCCE that demonstrates your newest code exhibiting the problem.