Thread: Loop not working

<
{
	Rectangle rectangle = new Rectangle(0, 0, 1365, 770);
	{
		while(true)
		{
        BufferedImage image = robot.createScreenCapture(rectangle);
        search: for(int x = 0; x < rectangle.getWidth(); x++)
			{
            for(int y = 0; y < rectangle.getHeight(); y++)
				{
					if(image.getRGB(x, y) == color1.getRGB())
						{
							return true;
						}
					return false;
				}
			}
		}
	}
}
>

what im having a problem with is that the loop while(true) is not working and i need it to work

this method is supposed to search through a screenshot and find a pixel and if it dose not take another shot and look again but it is not doing that when i run the program

the loop while(true) is not working

Please explain what the code does and why you think it is not working.

When the code executes the return false; statement, that will end the loop. Are you sure that you want to end the loop the first time the colors don't match?


The formatting of your code makes it very hard to read. The {}s should be aligned and not left and right as yours are.

That loop only ever looks at a single pixel in a single image. To see that try:

Rectangle rectangle = new Rectangle(0, 0, 1365, 770);
{
    while(true)
    {
        System.out.println("About to take screen shot");
        BufferedImage image = robot.createScreenCapture(rectangle);
        search: for(int x = 0; x < rectangle.getWidth(); x++)
        {
            for(int y = 0; y < rectangle.getHeight(); y++)
            {
                System.out.println("Looking at pixel " + x + "/" + y);
                if(image.getRGB(x, y) == color1.getRGB())
                {
                    System.out.println("About to finish and return true");
                    return true;
                }
                System.out.println("About to finish and return false");
                return false;
            }
        }
    }
}

You might to replace the "true" while(true) with something that better expresses your intent that the loop should continue until a pixel of a specific colour has been found. Also remove the label "search:" - it isn't being used.

Remove the return false from inside of the loop.

ok so where would i put it? i took it out completely and its still not looping, do i need to put it in at the end of the method?

its still not looping,

Add a printlns as shown in post#4 in the loop to show if it is looping.
If the method does not execute return true, where is it executing?
The return appears to be the ONLY way to exit the loop. The loop should loop forever.

exception in thread "main" nosuchmethod error i have a Main class

When you get an error, please copy and paste here the full text of the error message.

do i have to have a main method?

If you want to have the java program execute the class it must have a proper main method.

Are you conscious that with the while(true) statement you are creating a infinite loop ?

Oscar Gómez
Engineer at PSL
PSL S.A. - CMMi 5 nearshore software development and outsourcing from Latin America - Home

Are you conscious that with the while(true) statement you are creating a infinite loop ¡

Oscar Gómez
Engineer at PSL
PSL S.A. - CMMi 5 nearshore software development and outsourcing from Latin America - Home

replace return false statement from inside the for loop. It should be outside the while(true) loop.