Thread: Make it stop looping! please. :)

=O I think you are right. But I'm not sure because I can't test it. now its giving me more problems. After its suppose to add the person I tell it to print the list and it just says null. =(
and I try to register another person and it has an error. =/ so I did something wrong, maybe that's why it wasn't working in the first place. maybe you want to look at my code for me and tell me whats wrong? haha.

import javax.swing.JOptionPane;
import java.util.*;
 
public class Main
{
	public static void main(String[] args)
	{
		Login Login = new Login();
 
		Login.Login();
	}
 
}

import javax.swing.*;
import java.util.*;
 
public class Login
{
	public void Login()
	{
		// Account Creation Variables.
		String newLogin = null;
		String newPassword = null;
		int newidNumber = 0;
		String newName = null;
		String newType = null;
		String reEnterPassword = null;
 
		// Login variables
		boolean running = true;
		String LoginMenu = "";
		int response1 = 0;
		Scanner keyBd = new Scanner(System.in); // scanner
 
		AAL AAL = new AAL(); // Initialize AAL class.
 
		// Initialize Account class.
		Account Account = new Account(newLogin, newPassword, newidNumber,
				newName, newType);
 
		String errorMsg = "Bad command.";
 
		while (running == true)
		{
			response1 = 0; // Resets response.
 
			LoginMenu = "Please select a menu option.\n\n1. Login \n2. Register";
 
			System.out.println(LoginMenu);
			try
			{
				response1 = keyBd.nextInt();
			} // end try
			catch (Exception inputMismatchException)
			{
				System.out.println(errorMsg);
				Login();
			}
			// respond to menu options
			switch (response1)
			{
 
			// Login
			case 1:
			{
 
				break;
			}
 
				// Register
			case 2:
			{
				// reset info to default.
				newLogin = "";
				newPassword = "";
				newidNumber = 0;
				newName = "";
				newType = "";
 
				System.out.println("Please fill out the folling information:");
 
				boolean newAccountLoop = true;
				do
				{
 
					try
					{
						// start attempting new login
						boolean loginClear = false;
						boolean loginUsed = false;
						do
						{
 
							loginClear = false;
							loginUsed = false;
							System.out.print("Login:");
 
							newLogin = keyBd.next();
 
							if (AAL.accArray.size() == 0)
							{
								loginClear = true;
							}
							else
							{
								for (int i = 0; i < AAL.accArray.size(); i++)
								{
 
									if (AAL.accArray.get(i).getLogin().equals(
											newLogin))
									{
										loginUsed = true;
										System.out.println("Bad login.");
									}
									if (loginUsed != true)
									{
										loginClear = true;
									}
								}
 
							}
						} while (loginClear == false);
 
						// start attempting new password
						boolean passwordClear = false;
						do
						{
							System.out.print("\nPassword:");
							newPassword = keyBd.next();
							System.out.print("\nReEnter Password:");
							reEnterPassword = keyBd.next();
							// check to make sure password is the same.
							if (newPassword.equals(reEnterPassword))
							{
								passwordClear = true;
							}
						} while (passwordClear == false);
 
						// start attempting new id number.
						boolean idNumberUsed = false;
						boolean idNumberClear = false;
						do
						{
							idNumberUsed = false;
							idNumberClear = false;
							System.out
									.print("\nPlease choose and account number.");
							System.out.print("\nidNumber:");
							newidNumber = keyBd.nextInt();
							if (AAL.accArray.size() == 0)
							{
								idNumberClear = true;
							}
							else
							{
								for (int i = 0; i < AAL.accArray.size(); i++)
								{
									// Make sure idNumber is not used already.
									if (AAL.accArray.get(i).getidNumber() == newidNumber)
									{
										idNumberUsed = true;
										System.out.println("Bad ID Number");
									}
									if (idNumberUsed != true)
									{
										idNumberClear = true;
									}
 
								}
 
							}
 
						} while (idNumberClear == false);
 
						newAccountLoop = false;
					}// end try
					catch (Exception inputMismatchException)
					{
						System.out.println(errorMsg);
						Login();
					}// end catch
				} while (newAccountLoop == true);
 
				// Create account object with new values
				Account newAccount = new Account(newLogin, newPassword,
						newidNumber, newName, newType);
 
				// Add the account to accArray
				AAL.accArray.add(newAccount);
 
				System.out.printf("Account " + newName + " created successfully.\n");
 
				break;
			}
			case 433:
			{
				for (int i = 0; i < AAL.accArray.size(); i++)
				{
					System.out.println(AAL.accArray.get(i).getName());
					System.out.print("" + AAL.accArray.get(i).getName());
 
				}
				break;
			}
 
			default:
			{
				System.out.println(errorMsg);
				System.out.println("Switch Default.");
				/*
				 * String Msg =
				 * String.format("Sorry that is an invalid option.");
				 * JOptionPane.showMessageDialog(null, Msg);
				 */
				break;
			}
 
			}// end switch
 
		}// end while
	}
}

public class Account
{
 
	public String Login;
	public String Password;
	public String Name;
	public int idNumber;
	public String Type;
 
	public Account(String newLogin, String newPassword, int newidNumber,
			String newName, String newType)
	{
 
		Login = newLogin;
		Password = newPassword;
		idNumber = newidNumber;
		Name = newName;
		Type = newType;
	} // end Account
 
	public String toString()
	{
		return Name;
	} // end method toString
 
	public void setName(String changedName)
	{
		Name = changedName;
	}// end setName
 
	public void setPassword(String changedPassword)
	{
		Password = changedPassword;
	}// end setPassword
 
	public void setType(String changedType)
	{
		Type = changedType;
	}// end setType
 
	public int getidNumber()
	{
		return idNumber;
	}// end getidNumber
 
	public String getType()
	{
		return Type;
	}// end getType
 
	public String getName()
	{
		return Name;
	}// end getName
 
	public String getLogin()
	{
		return Login;
	}
}// end class

import java.util.ArrayList;
 
 
public class AAL
{
	public ArrayList<Account> accArray = new ArrayList();
}

That's a fair amount of code to go through I know but if you do thanks. I've never tried putting an arraylist in its own class like that before though. There should be nothing wrong with it right?

When you type in 433 as your response, what happens?

EDIT: Actually, if I remember right toString() is only auto-called by the compiler during string concatenation (i.e object + " "). So try this:

case 433:
			{
				for (int i = 0; i < AAL.accArray.size(); i++)
				{
					System.out.println(AAL.accArray.get(i).toString());
				}
				break;
			}

If that doesn't work (it should...but I'm exhausted and should be asleep), try creating a temp account object with no args. I noticed you didn't have a default no-args constructor in your account class. Perhaps add one. Then just assign the temp the account at index i and call temp.toString();

Your code keeps failing to print because you are asking it to print blanks. Nowhere in the code does it ask the user for his/her actual name. Just the login name. So I added this piece of code just at the very start of the try block and it works fine:

						//Get users registration name
						System.out.print("Please enter your name: ");
						newName = keyBd.next();
                                                System.out.println("");

Now when you go to call the getName() method it has something to print out.

Or if you'd prefer to print out the login credentials instead of the users actual name, in your for-loop, change to the following:

case 433:
			{
				for (int i = 0; i < AAL.accArray.size(); i++)
				{
					System.out.println(AAL.accArray.get(i).getLogin());
				}
				break;

No problem at all. I'm always making simple mistakes and I know its always something small that I've overlooked. Outside perspective is a life saver! Besides, I'm still only a beginner really when it comes to Java but I enjoy the challenge of fixing problematic code

Glad to have been of some help !