Thread: Linked List problem, please help.

Ok thanks, but I'm cant find how to use that. Is it build into the post box, or do I need to get it from somewhere else?

Originally Posted by Axeander

Ok thanks, but I'm cant find how to use that. Is it build into the post box, or do I need to get it from somewhere else?

Hi Axeander, you can get your code into the box by editing your post above and flanking the source code with either the [highlight=java][/highlight] or [code][/code], where the code goes between the bracketed tags.

Ok thanks, but do you have any suggestions about the code its self? I really need some help on it.

ListNode<Integer> start as your ListNode stores Integers.

int length = Length (prevNodeMain);

I don't see what this is for.

Usually you look at the size of the entire list, not a just a single Node.

Unless Length is another method in the class that you're not showing because you've already got it figured out.

(String)prevNodeMain.getValue ()

If you're using Integers,

prevNodeMain.getValue().toString() would be better.

I don't think the way you have it now will work.

Also, the ListNodes you're passing as parameters should have their data types. I think that you said they were both Integer.

public static ListNode<Integer> insertBeforeSmallest (ListNode<Integer> headMain, ListNode<Integer> headInsert)

Yes I already have the method Length on the rest of the program which is working but for some reason when i run the program using this code,

 public static void main (String[] args)
    {
 
        ListNode startList, startInsert;
        System.out.println ("Entering the original list...");
        startList = getLinkedList ();
        System.out.println ("Entering the list to be inserted...");
        startInsert = getLinkedList ();
        startList = insertBeforeSmallest (startList, startInsert);
 
        // prints elements of a linked list
        ListNode tempNode = startList;
        while (tempNode != null)
        {
            System.out.println (tempNode.getValue ().toString ());
            tempNode = tempNode.getNext ();
        }
    } // main method
 
 
    public static ListNode getLinkedList ()
    { //gets linked list
        ListNode startNode, node, lastNode;
        System.out.println ("Type in a name,'none' to quit..");
        String name = Stdin.readLine ();
        if (name.equals ("none"))
            startNode = null;
        else
        {
            startNode = new ListNode (name, null);
            lastNode = startNode;
            do
            {
                System.out.println ("Type in a name, 'none' to quit.");
                name = Stdin.readLine ();
                if (!name.equals ("none"))
                {
                    node = new ListNode (name, null);
                    lastNode.setNext (node);
                    lastNode = node;
                }
            }
            while (!name.equals ("none"));
        } //else
        return startNode;
    }

I get stuck in the while loop "while(tempNode != null)" and keeps printing the same 2 number over and over.

Ok thanks everyone, I just finished it up. Thanks for the help.