Thread: How to open the lock?

import java.util.Scanner;
 
public class Chapter8{
 
    // user need to find the combo to open the lock
    // the right combo is first right, left and then right
 
    Scanner userInput = new Scanner(System.in);
 
    public void printMenu()
    {
 
        System.out.println("1) Choose combo");
        System.out.println("2) Reset");
        System.out.println("3) Try to open the lock ");
        System.out.println("4) Finish");
    }
 
    public void combo()
    {
        System.out.println("Type in the right code to open the lock:  ");
        String inputOne =  userInput.next();
        String inputTwo =  userInput.next();
        String inputThree = userInput.next();
        return;
    }
 
    public void reset()
    {
        userInput.reset();
        System.out.println("You have reset!");
    }
 
    public void open()
    {
        String inputOne =  userInput.next();
        String inputTwo =  userInput.next();
        String inputThree = userInput.next();
 
 
        if (inputOne.equals("right") && inputTwo.equals("left") && inputThree.equals("right")) // the code ignores this
        {
        System.out.println("You succed to open the lock");
 
        }
        else
        {
            System.out.println("You got wrong combo");
            // this line shows in the console even though the user input in the console is right
 
        }
    }
}

Main

import java.util.Scanner;
public class Main {
    public static void main(String[] args) {
        Chapter8 Chapter8 = new Chapter8();
 
        boolean running = true;
 
        do
        {
           Chapter8.printMenu();
           int choice = Chapter8.userInput.nextInt();
            switch(choice)
            {
        case 1:
            Chapter8.combo();
            break;
        case 2:
            Chapter8.reset();
            break;
        case 3:
            Chapter8.open();
            break;
        }
    } while(true);
}
}

Can you copy and paste here the contents of the console from when you execute the code that shows the problem.
Add some comments to the posting where you the output is not what you expected.


One possible problem with the code is it has more than one instance of the Scanner class that reads from the console. If there is any input read and buffered by one instance, another instance of Scanner will not see it. Better to only have one instance of the Scanner to read user input from the console.

it does not pop up anything in the console

That is the problem.
If the program is trying to read user input I would expect it to print something on the console telling the user what to enter.
The program needs to ask for user input before trying to read the user's input.

All the calls to Scanner methods need to be inside of a method.

Is that the current contents of the console when the program is run?
What is wrong with it? What should it be different?

Add some comments to the output to show where the output is not what is expected. For example:
<<<< This should be ....


Also post the new code.

To open the lock the user need to type right left right and it should pop up a message that the lock is opened and thats the problem. Even if input is right left right the message dont pop up. It ignores the if and hops over to else.

The code is updated now also

What is the shown on the console when the new code is executed?
Add some comments to the output showing where it is not what is expected.

You missed this:

All the calls to Scanner methods need to be inside of a method.

There are calls to Scanner methods outside of any method:

 
    String inputOne =  userInput.nextLine();
    String inputTwo =  userInput.nextLine();
    String inputThree = userInput.nextLine();

These statements need to be inside of a method.

Also this has not been fixed:

One possible problem with the code is it has more than one instance of the Scanner class that reads from the console. If there is any input read and buffered by one instance, another instance of Scanner will not see it. Better to only have one instance of the Scanner to read user input from the console.