Thread: SoftwareSales Program

Hello, I'm having trouble with my SoftwareSales.java program that involves another demo part. I have it running but my output seems off, something tells me its a simple fix but I'm having trouble again. Thanks for any tips/suggestions.

SoftwareSales.java

package chapter4;
 
public class SoftwareSales 
{
	private double retailCostPerUnit = 99.00;
	private double costBeforeDiscount;
	private double costAfterDiscount;
	private double discount;
	private double unitsSold;
	private double cost;
 
	public SoftwareSales(int units) 
	{
		unitsSold = units;
	}
 
	public void setUnitsSold(int units)
	{
		unitsSold = units;
	}
 
	public double getDiscount()
	{
		costBeforeDiscount = retailCostPerUnit * unitsSold;
 
		if (unitsSold >= 100)
		{
			discount = costBeforeDiscount * 0.5;
		}
 
		else if(unitsSold >= 50)
		{
			discount = costBeforeDiscount * 0.4;
		}
 
		else if(unitsSold >= 20)
		{
			discount = costBeforeDiscount * 0.3;
		}
 
		else if (unitsSold >= 10)
		{
			discount = costBeforeDiscount * 0.2;
		}
 
		else
		{
			discount = 0;
		}
 
		costAfterDiscount = costBeforeDiscount - discount;
 
		return discount;
	}
 
	public double getUnitsSold() 
	{
		return unitsSold;
	}
 
	public double getCost()
	{
		cost = retailCostPerUnit - discount;
 
		return cost;
	}
}

SoftwareSalesDemo.java

package chapter4;
 
import java.text.DecimalFormat;
import java.util.Scanner;
 
public class SoftwareSalesDemo 
{
	public static void main(String[] args) 
	{
		int units; 
 
		// Create a Scanner object for keyboard input.
		Scanner keyboard = new Scanner(System.in);
 
		// Get the units sold.
		System.out.print("Enter the units sold: ");
		units = keyboard.nextInt();
 
		// Create a SoftwareSales object.
		SoftwareSales sales = new SoftwareSales(units);
 
		// Display purchase info.
		DecimalFormat dollar = new DecimalFormat("#, ## 0.00");
		System.out.println("Units sold: " + sales.getUnitsSold());
		System.out.println("Discount: $" + dollar.format(sales.getDiscount()));
		System.out.println("Cost: $" + dollar.format(sales.getCost()));
 
		keyboard.close();
	}
}

So what exactly is the problem? I am not sure exactly what it is supposed to do so I can't tell what is wrong.

--- Update ---

I noticed your getDiscount method returns the variable discount, but I think you wanted to return costAfterDiscount.

you have this statement : costAfterDiscount = costBeforeDiscount - discount;

and then you just return discount anyway, so I'm assuming you want to return costAfterDiscount.

I'm just suspecting my output is funny and/or wrong. This is what I get after making that slight change:

Enter the units sold: 100
Units sold: 100.0
Discount: $4,950.00  
Cost: $4,851.00

Which is the same output as I got before.

And it seems that your getCost method should look more like:



cost = costBeforeDiscount - discount;
return cost;

Actually, at 100 it should be 50% off right? which would make that correct..

--- Update ---

But for others it is wrong, so you are right, you do want to go back and return discount for getDiscount.

Still I believe getCost should be changed to:

	public double getCost()
	{
                cost = costBeforeDiscount - discount;                
		return cost;
	}

I am getting an output like this

Enter the units sold: 40
Units sold: 40.0
Discount: $1,188.00  
Cost: $2,772.00

Is that correct output?

40 * 99 = $3,960

$3,960 - $1,188.00 (discount) = $2,772.00

So yes that is correct. And that seemed to of fixed it all. Thank you greatly for your help Koder, much appreciated.

No problem. Glad I could help.


Just a tip: This was a little difficult to understand because calculations are happening in different places (which is why I was confused about the first part)

I would recommend doing your calculations once you gather the number of units. This will make your code easier to read and easier to tweak.


So your code could look something like this:

 
{
	private double retailCostPerUnit = 99.00;
	private double costBeforeDiscount;
	private double costAfterDiscount;
	private double discount;
	private double unitsSold;
	private double cost;
 
	public Million(int units) 
	{
		unitsSold = units;
	}
 
	public void setUnitsSold(int units)
	{
		unitsSold = units;
                setDiscount();
                costAfterDiscount = costBeforeDiscount - discount;
                cost = costBeforeDiscount - discount;                
 
 
 
	}
 
	public void setDiscount()
	{
		costBeforeDiscount = retailCostPerUnit * unitsSold;
 
		if (unitsSold >= 100)
		{
			discount = costBeforeDiscount * 0.5;
		}
 
		else if(unitsSold >= 50)
		{
			discount = costBeforeDiscount * 0.4;
		}
 
		else if(unitsSold >= 20)
		{
			discount = costBeforeDiscount * 0.3;
		}
 
		else if (unitsSold >= 10)
		{
			discount = costBeforeDiscount * 0.2;
		}
 
		else
		{
			discount = 0;
		}
 
 
	}
 
        public double getDiscount(){
            return discount;
        }
 
	public double getUnitsSold() 
	{
		return unitsSold;
	}
 
	public double getCost()
	{
		return cost;
	}
}

	public static void main(String[] args) 
	{
		int units; 
 
		// Create a Scanner object for keyboard input.
		Scanner keyboard = new Scanner(System.in);
 
		// Get the units sold.
		System.out.print("Enter the units sold: ");
		units = keyboard.nextInt();
 
		// Create a SoftwareSales object.
		Million sales = new Million(units);
 
		// Display purchase info.
		DecimalFormat dollar = new DecimalFormat("#, ## 0.00");
		System.out.println("Units sold: " + sales.getUnitsSold());
                sales.setUnitsSold(units); //added this
		System.out.println("Discount: $" + dollar.format(sales.getDiscount()));
		System.out.println("Cost: $" + dollar.format(sales.getCost()));
 
		keyboard.close();
	}
}

I know mine isn't perfect either, but you can see that all the calculations are done in one place so it makes it easier to read without needing to jump around. Also makes it easier to debug since its more compact. Once you get the units you can find all of your other variables, so why not do it in the setUnitsSold method like that?

Looks good, yeah I apologize for the confusion, I myself was because of the calculations. But I'll def consider the revised code you provided, right now going to take a break from all this coding. Been at it for a few hours now.

Originally Posted by Caffeine

Looks good, yeah I apologize for the confusion, I myself was because of the calculations. But I'll def consider the revised code you provided, right now going to take a break from all this coding. Been at it for a few hours now.

Sometimes the best thing to do is take a break, but it can be difficult to do when you know the answer is going to be something so simple!