Thread: array stack

Make a array with three stacks.

Please describe what the program is supposed to do.

Let's start with the error in the code you've posted. This is what I get when I run your code:

An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
An error has occured java.lang.ArrayIndexOutOfBoundsException: 2
1200
0000
0000
0000
0000

You must analyze your code to determine why the error is occurring and fix it if you can. You might trying improving the error message to determine the source of the exception. If you can't find the source and a solution, come back.

One of the first things to do is to print out the exception stack trace:

catch(Exception ex)
{
    System.out.println("An error has occured "+ex);
    ex.printStackTrace();
}

This will tell you the exact location of the exception. Check the line of code indicated in the stack trace for errors. You may find it helpful to put in some System.out.println()s in that area to further understand the reason for the exception.

Apart from that, go through Arrays (The Java™ Tutorials > Learning the Java Language > Language Basics). Pay extra attention to the way an array is indexed in relation to its size/length.

Here is a different approach. I want to make a 3 stacked array.

import java.util.*;
 
public class ArrayStack 
{
	private int SIZE =10;
	private int MAXSIZE= 30;
	private int location =0;
	private int number;
	ArrayStack[] arrayStack = new ArrayStack[MAXSIZE];
 
	static Stack<Integer> st = new Stack<Integer>();
 
	ArrayStack()
	{
		for(int i=0;i<MAXSIZE;i++)
		{
			arrayStack[i] = new ArrayStack(); 
		}
	}
 
	boolean checkSize()
	{
		return st.size()==SIZE;
	}
 
	public void pushNumbersOntoStack(int num)
	{
		if(checkSize()) //if stack is full create a new one
		{
			for(int i=0;i<st.size();i++)//add stack to array
			{
				arrayStack[location++].number=st.pop();
			}
			st = new Stack<Integer>();//creating new stack
		}
		st.push(num);
	}
 
	public void getNumberfromArray()
	{
		for(int i=0;i<MAXSIZE;i++)
		{
			System.out.println(arrayStack[i].number);	
		}
	}
 
	public static void main(String[] args)
	{
		ArrayStack myStack = new ArrayStack();
 
		for(int i=0;i<30;i++)
		{
		myStack.pushNumbersOntoStack(i);
		}
 
		myStack.getNumberfromArray();
	}
 
}

errors

Exception in thread "main" java.lang.StackOverflowError
	at ArrayStack.<init>(ArrayStack.java:13)
	at ArrayStack.<init>(ArrayStack.java:17)
	at ArrayStack.<init>(ArrayStack.java:17)
	at ArrayStack.<init>(ArrayStack.java:17)
	at ArrayStack.<init>(ArrayStack.java:17)
	at ArrayStack.<init>(ArrayStack.java:17)

Take a look at StackOverflowError (Java Platform SE 7 ) to see why might this error occur. (Note, "stack" in the API doc refers to JVM internals.)

The StackOverflowError is many ways is similar to the problem discussed in another thread. My reply there, http://www.javaprogrammingforums.com...tml#post146642, is also applicable to your case, especially this part:

Originally Posted by jashburn

Note that when a class is instantiated, the new object is initialised by going through the following procedure (on a high-level):

1. invoke another constructor in the same class (if such a call exists)
2. invoke a superclass constructor
3. execute instance initialisers and instance variable initialisers
4. execute the rest of the body of the constructor

(See Object initialization in Java | JavaWorld and Chapter*12.*Execution for elaboration on the above.)

In your case, it is at step #4 above. Consider the following, based on the code in your post but significantly simplified:

public class ArrayStack {
 
	ArrayStack arrayStack;
 
	ArrayStack() {
		arrayStack = new ArrayStack();
	}
 
	public static void main(String[] args) {
		ArrayStack myStack = new ArrayStack();
	}
 
}

When "ArrayStack myStack = new ArrayStack()" is called in the main method, it goes through the object initialisation procedure. On reaching step #4, it executes the constructor, ArrayStack(). The body of the constructor contains "arrayStack = new ArrayStack()," i.e., code to instantiate and initialise another ArrayStack object. This again, goes through the object initialisation procedure, execute the constructor, etc., ad infinitum.

In short, you cannot instantiate the same object in the object's class constructor as it causes infinite recursion.