Thread: Morse Problem

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      for(i = 0; i < alpha.length; i++)
      {
        if(phrase.charAt(i) == alpha[i]);  
      }
 
    }
}

My problem is the morse alphabet conversion like a =--. or something to that effect.

That's the assignment, but what questions do you have about the code you posted? What problems are you having writing the code to complete the assignment? If you're getting errors, post them. If the results from the code you posted are not correct, show the results, explain what should be different, and ask specific questions about how to fix the code to get the correct results.

(I understand the problem but dont see how.)(pseudocode!)See i need the if to be equivalent to asking if the phrase has a letter in the alphabet, return the index. Then look for the index in the norse code adding to new phrase.

So try coding that.

It wont work because everytime I would go to next letter in phrase it can only be compared to next letter in array.

--- Update ---

Here is what I have (tried...)

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      String l = "";
      for(i = 0; i < alpha.length; i++)
      {
        if(phrase.charAt(i) == alpha[i]); 
           { 
            l = morse[i];
            Newphrase += l;
           }
      }
 
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

Wow, it's hard to get info from you, but we might finally be getting somewhere.

What I think you've said is that each time you advance to the next letter of the input, the array used for comparison needs to reset to the first element. That means that the same index, i, can't be used for the charAt() method and the alpha[] index. Do you see a way to use two variables? It may take 2 for loops, or it may take an independent index variable that can be reset to zero when needed.

is this what you mean

 
/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      String l = "";
      for(i = 0; i < phrase.length(); i++)
      {  
          for(i = 0; i < alpha.length; i++)
         {   
             if(phrase.charAt(i) == alpha[i]); 
                { 
                 l = morse[i];
                 Newphrase += l;
                }
         }
 
    }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

This all I could come up with.

not the same, two variables = DIFFERENT

Use a DIFFERENT index/loop control variable in each for loop.

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      int a = 0;
      String l = "";
      for(i = 0; i < phrase.length(); i++)
      {  
          for(a = 0; a < alpha.length; a++)
         {   
             if(phrase.charAt(i) == alpha[a]); 
                { 
                 l = morse[a];
                 Newphrase += l;
                }
         }
 
    }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

this

Think it through. In plain language, you might say what you're trying to do:

Get a value from the input
Compare the value to each element of the array alpha[] to find a match

So, program that:

// get a value from the input
value = charAt( i );
 
// compare the value to each element of the array alpha[] to find a match
for ( j = 0 ; j < alpha.length ; j++ )
{
    if ( value == alpha[j] )
    {
        // then do something
    }
}

The for loop I wrote is the inner or nested loop. The outside loop that you'll write (you already have) takes each value of the input one at a time. Write the outer for loop and put it around the for loop I wrote.

After making suggested changes here is what I have.

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      int a = 0;
      char l;
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase+= morse[a];
                  }
          }
 
    }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

yes at least for letters I suppose Ill do the same thing for numbers

--- Update ---

Now the number part wont return anything

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      int a = 0;
      char l;
      int b = 0;
      phrase.toLowerCase();
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase+= morse[a];
                  }
          }
 
      }
      for(i = 0; i < phrase.length(); i++)
      {  
        b = phrase.charAt(i);
          for ( a = 0 ; a < num.length ; a++ )
          {
               if ( b == num[a] )
                   {
                     Newphrase+= morse[a];
                  }
          }
 
    }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

Here is tester.

/**
 * Write a description of class MorseCodeTester here.
 * 
 * @author (your name) 
 * @version (a version number or a date)
 */
import java.io.*;
public class MorseCodeTester
{
   public static void main(String [] args) throws IOException
   { 
       MorseCode m = new MorseCode("Hohoho");
       m.read();
       m.Convert();
       System.out.println(m.getNewPhrase());
    }
}

Input was Hohoho122.
Output was ---....---....---

/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      int[] num = {0,1,2,3,4,5,6,7,8,9};
      int i = 0;
      int a = 0;
      char l;
      int b = 0;
      phrase  = phrase.toLowerCase();
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase+= morse[a];
                    }
          }
 
      }
      for(i = 0; i < phrase.length(); i++)
      {  
        b = phrase.charAt(i);
          for ( a = 0 ; a < num.length ; a++ )
          {
               if ( b == num[a] )
                   {
                     Newphrase+= morse[a];
                  }
          }
 
      }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

Now the H prints but still even with the Id statements, nothing wrong with array printed so thats not it.

but the code has to convert ints to morse code also.

Thanks finally fixed the problem or at least I think I did based on results

 
/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      char[] num = {'0','1','2','3','4','5','6','7','8','9'};
      int i = 0;
      int a = 0;
      char l;
      int b = 0;
      phrase  = phrase.toLowerCase();
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase+= morse[a];
                    }
          }
 
      }
      for(i = 0; i < phrase.length(); i++)
      {  
        b = phrase.charAt(i);
          for ( a = 0 ; a < num.length ; a++ )
          {
               if ( b == num[a] )
                   {
                     Newphrase+= "    " + morse[a+25];
                  }
          }
 
      }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

Space was removed but used to test results.

--- Update ---

Now my problem is spacing when a sentence is inserted

 
/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      char[] num = {'0','1','2','3','4','5','6','7','8','9'};
      int i = 0;
      int a = 0;
      char l;
      int b = 0;
      phrase  = phrase.toLowerCase();
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
          if((int) 'l' == 32)
               Newphrase += " ";
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase += morse[a];
                    }
          }
 
      }
      for(i = 0; i < phrase.length(); i++)
      {  
        b = phrase.charAt(i);
          for ( a = 0 ; a < num.length ; a++ )
          {
               if ( b == num[a] )
                   {
                     Newphrase+= morse[a+25];
                  }
          }
 
      }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

for example inputting I love
would printout all morse code letters correctly in one jumble.

--- Update ---

So go ahead and scrap what I just said (Spacing still doesnt work also found out numbers between letters dont pint out until after letters are printing which makes sense because of my organization. Now with program reorganized they dont print at all.)

 
/**
 * Write a description of class MorseCode here.
 * 
 * @author (Landon L) 
 * @version (a version number or a date)
 */
import java.util.*;
import java.io.File;
import java.io.IOException;
public class MorseCode 
{
    private static String[] morse; 
    private static String phrase;
    private static String Newphrase;
    /**
     * Constructor for objects of class MorseCode
     */
    public MorseCode(String p)
    {
        morse = new String[36];
        phrase = p;
        Newphrase = "";
    }
 
    public static String[] read() throws IOException
    {
        Scanner in = new Scanner(new File("morsecode.txt"));
        String a = phrase;
        int i = 0;
        while(in.hasNext())
        {
        String b = in.next();
        morse[i] = b;
        i++;
        }
        //for(i = 0; i < morse.length; i++)
        return morse;
    }
    public static void  Convert()
    {
      char[] alpha = {'a','b','c','d','e','f','g','h','i','j','k','l','m',
                        'n','o','p','q','r','s','t','u','v','w','x','y','z'};
      char[] num = {'0','1','2','3','4','5','6','7','8','9'};
      int i = 0;
      int a = 0;
      char l;
      int b = 0;
      phrase  = phrase.toLowerCase();
      for(i = 0; i < phrase.length(); i++)
      {  
        l = phrase.charAt(i);
        if((int) 'l' == 32)
               Newphrase += " ";
          else if(((int) 'l'>= 99)&& ((int) 'l'<= 122))
          {
          for ( a = 0 ; a < alpha.length ; a++ )
          {
               if ( l == alpha[a] )
                   {
                     Newphrase += morse[a];
                    }
 
          }
          }
          else if(((int) 'l'>= 48)&& ((int) 'l'<= 57))
          {
          for ( a = 0 ; a < num.length ; a++ )
          {
               if ( l == num[a] )
                   {
                     Newphrase+= morse[a+25];
                  }
          }
        }
      }
    }
    public static String getNewPhrase()
    {
        return Newphrase;
    }
}

I dont understand what is meant by your first sentence/how to fix it.