Hot Dog Stand Code

**Powerbomb** · October 26th, 2013, 08:31 PM

All right, since I don't want to bother my teacher (I'm wondering if he'll eventually get annoyed since I'm having to ask him for help every weekend now...), can anyone help me with my code?

The question is: You operate several hot dog stands distributed throughout town. Define a class named HotDogStand that has an instance variable for the hot dog stand's ID number and an instance variable for how many hot dogs the stand has sold that day. Create a constructor that allows a user of the class to initialize both values.

Also create a method named justSold that increments by one the number of hot dogs the stand has sold. The idea is that this method will be invoked each time the stand sells a hot dog so that you can track the total number of hot dogs sold by the stand. Add another method that returns the value in this variable.

Finally, ad a static variable that tracks the total number of hot dogs sold by all hot dog stands and a static method that returns the value in this variable.

This is my class definition...

public class HotDogStand {
 
	// instance variables
 
	private String hotDogStandID;
	private int hotDogsSold;
	private static int totalSold;
 
	// mutators
 
	public void setHotDogStandID(String standID) {
		hotDogStandID = standID; }
 
	public void setHotDogsSold(int sold) {
		hotDogsSold = sold; }
 
	public void setAll(String standID, int sold) {
		hotDogStandID = standID;
		hotDogsSold = sold; }
 
	// constructors
 
	public HotDogStand() {
		hotDogStandID = "A Hot Dog Stand";
		hotDogsSold = 0; }
 
	public HotDogStand(String standID, int sold) {
		hotDogStandID = standID;
		if(hotDogsSold >= 0) {
			hotDogsSold = sold;
		} else {
			System.out.println("Error! Stop giving away free hot dogs!");
			System.exit(0); }; }
 
	// accessors
 
	public String getHotDogStandID() {
		return hotDogStandID; }
 
	public int getHotDogsSold() {
		return hotDogsSold; }
 
	public int getTotalSold() {
		return totalSold; }
 
	// other methods
 
	public int justSold(int sold) {
		return sold++; }
 
	public static int totalSold(int sold) {
		return totalSold++; }
 
}

And this is my driver/tester/demo:

import javax.swing.JOptionPane;
public class StandDemo {
	public static void main(String[] args) {
 
		String nameStandOne = JOptionPane.showInputDialog("What is the first stand's name?");
		String inputFirstSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandOne+"?");
		int firstSold = Integer.parseInt(inputFirstSold);
		HotDogStand firstStand = new HotDogStand(nameStandOne, firstSold);
 
		String nameStandTwo = JOptionPane.showInputDialog("What is the second stand's name?");
		String inputSecondSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandTwo+"?");
		int secondSold = Integer.parseInt(inputSecondSold);
		HotDogStand secondStand = new HotDogStand(nameStandOne, firstSold);
 
		System.out.println("The third hot dog stand has just opened!\n");
		HotDogStand thirdStand = new HotDogStand();
 
		int k = 1;
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 for the next stand.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				System.out.println("Hot dogs sold: "+firstStand.justSold(firstSold));
			} else if(choice == 0) {
				break; }
		}
 
 
 
	}
}

Obviously, the code isn't done yet. I'm stopping a moment to see if part of it works, but I've hit a roadblock. You see, whenever I try to increase the amount of hot dogs sold by the first stand, nothing actually happens. When, for the first hot dog stand, I enter 1 as the current amount of hot dogs sold and increment it, nothing happens. It remains at one and I'm not sure why.

I'm not very great at class definitions yet (I'm bumbling through them), but I'm hoping to get a bit of help.

The attached file shows the error.
Error.jpg
EDIT: or... it's too small. Nonetheless, the amount of hot dogs sold isn't incrementing and I'm not sure why. The program is compiling, but I have a logical error somewhere in there.

**Junky** · October 26th, 2013, 09:54 PM

public int justSold(int sold) {
		return sold++; }

You are increasing the parameter value and not the instance variable that tracks how many hotdogs have been sold. Other problems:

Why are you passing in a parameter at all? If you have sold 10 hotdogs so far today and then another one gets sold all that should happen is that the total increases by one.
Why is the method returning a value?

**Powerbomb** · October 26th, 2013, 10:04 PM

Originally Posted by Junky

public int justSold(int sold) {
		return sold++; }

You are increasing the parameter value and not the instance variable that tracks how many hotdogs have been sold. Other problems:

Why are you passing in a parameter at all? If you have sold 10 hotdogs so far today and then another one gets sold all that should happen is that the total increases by one.
Why is the method returning a value?

If I only return the total wouldn't that carry over for each stand? Also, why wouldn't I pass in a parameter? Don't I need some starting value on the driver, or should that be on the class definition?

The method is returning a value because... isn't that what it's supposed to do? JCreator won't compile the code if there isn't a return value...

I changed a few things. Class definition:

public class HotDogStand {
 
	// instance variables
 
	private String hotDogStandID;
	private int hotDogsSold;
	private static int totalSold = 0;
 
	// mutators
 
	public void setHotDogStandID(String standID) {
		hotDogStandID = standID; }
 
	public void setHotDogsSold(int sold) {
		hotDogsSold = sold; }
 
	public void setAll(String standID, int sold) {
		hotDogStandID = standID;
		hotDogsSold = sold; }
 
	// constructors
 
	public HotDogStand() {
		hotDogStandID = "A Hot Dog Stand";
		hotDogsSold = 0; }
 
	public HotDogStand(String standID, int sold) {
		hotDogStandID = standID;
		if(hotDogsSold >= 0) {
			hotDogsSold = sold;
		} else {
			System.out.println("Error! Stop giving away free hot dogs!");
			System.exit(0); } }
 
	// accessors
 
	public String getHotDogStandID() {
		return hotDogStandID; }
 
	public int getHotDogsSold() {
		return hotDogsSold; }
 
	public int getTotalSold() {
		return totalSold; }
 
	// other methods
 
	public int justSold(int sold) {
		sold = hotDogsSold;
		hotDogsSold = hotDogsSold+1; // ++ won't increase the value for some reason
		return hotDogsSold; }
 
	public String generateJustSold(String standID, int sold) {
		return "You have sold "+sold+" hot dogs for stand "+standID+"!"; }
 
	public static int totalSold() {
		return totalSold++; }
 
}

Tester:

import javax.swing.JOptionPane;
public class StandDemo {
	public static void main(String[] args) {
 
		String nameStandOne = JOptionPane.showInputDialog("What is the first stand's name?");
		String inputFirstSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandOne+"?");
		int firstSold = Integer.parseInt(inputFirstSold);
		HotDogStand firstStand = new HotDogStand(nameStandOne, firstSold);
 
		String nameStandTwo = JOptionPane.showInputDialog("What is the second stand's name?");
		String inputSecondSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandTwo+"?");
		int secondSold = Integer.parseInt(inputSecondSold);
		HotDogStand secondStand = new HotDogStand(nameStandOne, firstSold);
 
		System.out.println("The third hot dog stand has just opened!\n");
		HotDogStand thirdStand = new HotDogStand("Third Stand", 0);
 
		int k = 1;
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 for the next stand.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				System.out.println("Hot dogs sold: "+firstStand.justSold(firstSold));
			} else if(choice == 0) {
				break; } }
 
		System.out.println(firstStand.generateJustSold(nameStandOne, firstSold));
 
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 for the next stand.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				System.out.println("Hot dogs sold: "+secondStand.justSold(secondSold));
			} else if(choice == 0) {
				break; } }
 
		System.out.println(secondStand.generateJustSold(nameStandTwo, secondSold));
 
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 to show how many total hot dogs you've sold.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				System.out.println("Hot dogs sold: "+thirdStand.justSold(0));
			} else if (choice == 0) {
				break; } }
 
		System.out.println(thirdStand.generateJustSold("Third Stand", 0));
 
		System.out.println(HotDogStand.totalSold());		
	}
}

**Junky** · October 26th, 2013, 10:43 PM

If you were blindfolded and it was your job to count how many hotdogs I sold and I called out "justSold" every time I sold a hotdog how would you keep track? Would you require me to give your a number each time I sold a hotdog? Before you answer "what if you sold 3 hotdogs?" then I would call out "justSold justSold justSold". there is no need for me to give you a number.

"If I only return the total wouldn't that carry over for each stand? "

I'm not sure what you are asking here but each object of HotDogStand would have its own instance variable keeping track of the number of hotdogs sold.

**Powerbomb** · October 26th, 2013, 10:55 PM

What I mean is that if I'm using a static variable to count the amount of hot dogs sold for each stand wouldn't that value carry over once I finished with the input for stand 1?

For example, let's say Stand 1 sells 5 hot dogs. Because I'm using a static variable, that value counts for all of the objects, right? Or am I misunderstanding something?

EDIT: The problem is also asking me to keep track of each stand's individual hot dog count. How would I make a static method that keeps track of the total amount of hot dogs sold work? Sorry, I'm confused.

public class HotDogStand {
 
	// instance variables
 
	private String hotDogStandID;
	private int hotDogsSold;
	private static int totalSold = 0;
 
	// mutators
 
	public void setHotDogStandID(String standID) {
		hotDogStandID = standID; }
 
	public void setHotDogsSold(int sold) {
		hotDogsSold = sold; }
 
	public void setAll(String standID, int sold) {
		hotDogStandID = standID;
		hotDogsSold = sold; }
 
	// constructors
 
	public HotDogStand() {
		hotDogStandID = "A Hot Dog Stand";
		hotDogsSold = 0; }
 
	public HotDogStand(String standID, int sold) {
		hotDogStandID = standID;
		if(hotDogsSold >= 0) {
			hotDogsSold = sold;
		} else {
			System.out.println("Error! Stop giving away free hot dogs!");
			System.exit(0); } }
 
	// accessors
 
	public String getHotDogStandID() {
		return hotDogStandID; }
 
	public int getHotDogsSold() {
		return hotDogsSold; }
 
	public int getTotalSold() {
		return totalSold; }
 
	// other methods
 
	public int justSold(int sold) {
		sold = hotDogsSold;
		hotDogsSold = hotDogsSold+1;
		return hotDogsSold; }
 
	public String generateJustSold(String standID, int sold) {
		sold = hotDogsSold;
		return "You have sold "+hotDogsSold+" hot dogs for stand "+standID+"!"; }
 
	public static int totalSold() {
		return totalSold++; }
 
}

import javax.swing.JOptionPane;
public class StandDemo {
	public static void main(String[] args) {
 
		String nameStandOne = JOptionPane.showInputDialog("What is the first stand's name?");
		String inputFirstSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandOne+"?");
		int firstSold = Integer.parseInt(inputFirstSold);
		HotDogStand firstStand = new HotDogStand(nameStandOne, firstSold);
 
		String nameStandTwo = JOptionPane.showInputDialog("What is the second stand's name?");
		String inputSecondSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandTwo+"?");
		int secondSold = Integer.parseInt(inputSecondSold);
		HotDogStand secondStand = new HotDogStand(nameStandTwo, secondSold);
 
		String nameStandThree = JOptionPane.showInputDialog("What is the third stand's name?");
		String inputThirdSold = JOptionPane.showInputDialog("How many hot dogs have been sold so far for "+nameStandThree+"?");
		int thirdSold = Integer.parseInt(inputThirdSold);
		HotDogStand thirdStand = new HotDogStand(nameStandThree, thirdSold);
 
		int k = 1;
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 for the next stand.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				HotDogStand.totalSold();
				System.out.println("Hot dogs sold: "+firstStand.justSold(firstSold));
			} else if(choice == 0) {
				break; } }
 
		System.out.println(firstStand.generateJustSold(nameStandOne, firstSold));
 
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 for the next stand.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				HotDogStand.totalSold();
				System.out.println("Hot dogs sold: "+secondStand.justSold(secondSold));
			} else if(choice == 0) {
				break; } }
 
		System.out.println(secondStand.generateJustSold(nameStandTwo, secondSold));
 
		while(k != 0) {
			String choiceWord = JOptionPane.showInputDialog("Enter 1 to sell a hot dog! Enter 0 to show how many total hot dogs you've sold.");
			int choice = Integer.parseInt(choiceWord);
			if (choice == 1) {
				HotDogStand.totalSold();
				System.out.println("Hot dogs sold: "+thirdStand.justSold(0));
			} else if (choice == 0) {
				break; } }
 
		System.out.println(thirdStand.generateJustSold(nameStandThree, thirdSold));
 
		System.out.println("Total amount of hot dogs sold is: "+HotDogStand.totalSold());		
	}
}

In any case, here's the code so far. The static variable works, and the logic is sound, I guess. I don't suppose you have any tips for trimming it? It looks pretty bulky.

**Junky** · October 26th, 2013, 11:29 PM

Originally Posted by Powerbomb

What I mean is that if I'm using a static variable to count the amount of hot dogs sold for each stand wouldn't that value carry over once I finished with the input for stand 1?

You should be able to answer that question. Why is is static?

--- Update ---

Ahhh!

You have 2 variables:
totalsold which I assume is for all stands then that does need to be static.
hotDogsSold which is for one hotdog stand and should be an instance variable.

You have made your code much harder than it needs to be.

public void justSold() {
    hotDogsSold++;
}

That's it!

**Powerbomb** · October 26th, 2013, 11:45 PM

All right, I got it. Thanks for the help and patience, Junky.

Thread: Hot Dog Stand Code

LinkBack

Thread Tools

Display

Hot Dog Stand Code

Related threads:

Re: Hot Dog Stand Code

Re: Hot Dog Stand Code

Re: Hot Dog Stand Code

Re: Hot Dog Stand Code

Re: Hot Dog Stand Code

The Following User Says Thank You to Junky For This Useful Post:

Re: Hot Dog Stand Code

Similar Threads

Stand Alone Classes

Dog Tester Class

Dog Class

Old Dog Learning New Tricks!