Thread: Password Application I'm Coding Won't Work

I'm trying to make an application where you register a username and password then login, but when for some reason it won't recognize that the password is correct. Here is my code.

import javax.swing.JOptionPane;
 
public class Main {
	String username;
	String password;
 
	public void start(){		
		int a = JOptionPane.showConfirmDialog(null, "Do you have an account?", "Login / Register", 1);
 
		if(a == JOptionPane.NO_OPTION){
			regAccount();
		}
		if(a == JOptionPane.YES_OPTION){
			login();
		}
 
	}
 
	public void login(){
		String loginName = JOptionPane.showInputDialog("Please Enter Your Username");
		String loginPass = JOptionPane.showInputDialog("Please Enter Your Password");
 
 
 
		if(loginName == username){
			JOptionPane.showMessageDialog(null, "Login succesful");
		}else{
			JOptionPane.showMessageDialog(null, "Login failed");
		}
	}
 
	public void regAccount(){
		username = JOptionPane.showInputDialog("Please Enter a Username:");
		password = JOptionPane.showInputDialog("Please Enter a Password");
 
		JOptionPane.showMessageDialog(null, "Your username is " +username, "Register", JOptionPane.PLAIN_MESSAGE);
		JOptionPane.showMessageDialog(null, "Your password is " +password, "Register", JOptionPane.PLAIN_MESSAGE);
		start();
	}
 
	public static void main(String[] args){
		Main main = new Main();
		main.start();
 
	}
}

Sorry if my code is messy.

Your code doesn't look messy to me, and in fact seems pretty well formatted.

I see one problem in that you're comparing Strings using == which you should almost never do since == checks to see if one object reference is the exact same as another, and you really don't care about this. You don't want to know if one String object is the same as another String object, but instead you want to make sure that the two String objects hold the same characters in the same order, and possibly with the same capitalization. For that you should use the method equals(...) or equalsIgnoreCase(...).

so instead of

if (oneString == anotherString) {
   // ...
}

do something like

if (oneString.equalsIgnoreCase(anotherString)) {
   // ...
}

Thanks! It works fine now.

Great, glad you've got it working!