Thread: Trouble with Collision Detection

Hi, I'm having a little trouble with collision detection for walls in my game project. I'm trying to make it so that when a wall is detected, you can't keep moving in that direction, but for some reason, the character object will keep moving anyway.

package com.gravitygamesinteractive.kylethecaiman;
 
import java.awt.*;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
 
import javax.imageio.ImageIO;
 
public class Character {
	private int x,y;
	public static int fallspeed = 2;
	public static int moveSpeed = 1;
 
	public static BufferedImage kyle;
	public static BufferedImage cali;
	public static BufferedImage steve;
	public static boolean isTouchingFloor;
	public static boolean canMove;
	public Character(int x, int y){
		this.x=x;
		this.y=y;
		try {
		    kyle = ImageIO.read(new File("res/Kyle.png"));
		} catch (IOException e) {
		}
	}
 
	public void tick(){
		if(!isCollidingWithFloor(new Point(x,(y+44+fallspeed)),new Point((x+16),(y+44+fallspeed)))){
		y+=fallspeed;
		Component.sy+=(fallspeed);
		}else{
		}
 
		if(Component.isMoving){
			if(Component.dir==moveSpeed){
				canMove = isCollidingWithWall(new Point(x+16,y), new Point(x+16,y+40));
			}else if(Component.dir==-moveSpeed){
				canMove = isCollidingWithWall(new Point(x-1,y+2), new Point(x-1,y+40));
			}
 
			if(!canMove){
			x+=Component.dir;
			Component.sx+=Component.dir;
			}else{
				Component.isMoving=false;
			}
		}
	}
 
	public boolean isCollidingWithFloor(Point pt1, Point pt2){
		for(int f=0;f<Level.tile.size();f++){
			if(Level.tile.get(f).contains(pt1) || Level.tile.get(f).contains(pt2)){
				isTouchingFloor=true;
				return true;
			}
		}
		isTouchingFloor=false;
		return false;
	}
 
	public boolean isCollidingWithWall(Point pt1, Point pt2){
		for(int g=0;g<Level.tile.size();g++){
			if(Level.tile.get(g).contains(pt1) || Level.tile.get(g).contains(pt2)){
				return true;
			}
		}
		return false;
	}
 
	public void render(Graphics g){
		g.setColor(Color.red);
		g.drawRect(Component.sx+x, Component.sy+y, 16, 44);
		g.drawRect(Component.sx+x-1, Component.sy+y+40, 16, 44);
		g.drawImage(kyle,Component.sx+x-8,Component.sy+y,null);
 
	}
}

shouldnt if(!canMove) be if(canMove)

canMove = isCollidingWithWall(

When does isCollidingWithWall() return true?
The sense of those names doesn't make sense to me?
It seems to say it can move if it is colliding with the wall.

Nevermind, skim reading is bad for ones health.

if isColliding is true, then can move will be false

I don't read it that way. The code: canMove = isCollidingWithWall(

And $0.02 more makes it $0.04. Almost enough to bend over for to pick up.

Nevermind, I figured it out not too long ago. Apparantly the problem was that I forgot to reset a variable back to 0, so the object kept moving even when a wall was detected.

Edit: But I am, however, having trouble with points a bit. You see, I have the speed at which the y variable changes higher than one per frame. This sometimes leads to the character object getting stuck a little bit in the tiles.

Character object:

package com.gravitygamesinteractive.kylethecaiman;
 
import java.awt.*;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
 
import javax.imageio.ImageIO;
 
public class Character {
	private int x,y;
	public static int fallspeed = 3;
	public static int moveSpeed = 4;
	public static int jumpSpeed = 3;
	public static int jumpHeight=35, jumpCount=0;
 
	public static BufferedImage kyle;
	public static BufferedImage kali;
	public static BufferedImage steve;
	public static boolean isTouchingFloor;
	public static boolean canMove;
	public static boolean isJumping=false;
 
	public Character(int x, int y){
		this.x=x;
		this.y=y;
		try {
		    kyle = ImageIO.read(new File("res/Kyle.png"));
		} catch (IOException e) {
		}
	}
 
	public void tick(){
		if(!isJumping && !isCollidingWithFloor(new Point(x,(y+44)),new Point((x+16),(y+44)))){
		y+=fallspeed;
		Component.sy+=(fallspeed);
		}else if(Component.isJumping){
				isJumping=true;
			}else{
 
			}
 
		if(Component.isMoving){
			if(Component.dir==moveSpeed){
				canMove = isCollidingWithWall(new Point(x+16,y), new Point(x+16,y+40));
			}else if(Component.dir==-moveSpeed){
				canMove = isCollidingWithWall(new Point(x-1,y+2), new Point(x-1,y+40));
			}
 
			if(!canMove){
			x+=Component.dir;
			Component.sx+=Component.dir;
			}else{
				x+=0;
				Component.sx+=0;
				Component.dir=0;
				Component.isMoving=false;
			}
			if(isJumping){
				if(jumpCount>=jumpHeight){
					isJumping=false;
					Component.isJumping=false;
					jumpCount=0;
				}else{
					y-=jumpSpeed;
					Component.sy-=jumpSpeed;
 
					jumpCount+=1;
				}
			}
		}
	}
 
	public boolean isCollidingWithFloor(Point pt1, Point pt2){
		for(int f=0;f<Level.tile.size();f++){
			if(Level.tile.get(f).contains(pt1) || Level.tile.get(f).contains(pt2)){
				isTouchingFloor=true;
				return true;
			}
		}
		isTouchingFloor=false;
		return false;
	}
 
	public boolean isCollidingWithWall(Point pt1, Point pt2){
		for(int g=0;g<Level.tile.size();g++){
			if(Level.tile.get(g).contains(pt1) || Level.tile.get(g).contains(pt2)){
				return true;
			}
		}
		return false;
	}
 
	public void render(Graphics g){
		g.setColor(Color.red);
		g.drawRect(x-Component.sx, y-Component.sy, 16, 44);
		g.drawImage(kyle,x-8-Component.sx,y-Component.sy,null);
 
	}
}

Tile object:

package com.gravitygamesinteractive.kylethecaiman;
 
import java.awt.*;
import java.awt.image.*;
import javax.swing.JFrame;
import javax.imageio.*;
import java.io.*;
 
public class Tile extends Rectangle{
	private static final long serialVersionUID=1L;
 
	public static int[] g1top={0,0};
	public static BufferedImage tileset1ground;
	public Tile(int x, int y){
		this.x=x;
		this.y=y;
		this.width=16;
		this.height=16;
		try {
		    tileset1ground = ImageIO.read(new File("res/tileset1.png"));
		} catch (IOException e) {
		}
	}
 
public void tick(){
 
}
 
	public void render(Graphics g){
		g.setColor(Color.red);
		g.drawImage(tileset1ground,x-Component.sx,y-Component.sy,null);
	}
}

That worked for the most part, but for some reason about one out of eight times the character object will immediately snap down to the ground without scrolling the stage with it, resulting in the level beginning to leave the screen.

package com.gravitygamesinteractive.kylethecaiman;
 
import java.awt.*;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
 
import javax.imageio.ImageIO;
 
public class Character {
	private int x,y;
	private int tiley;
	public static int fallspeed = 3;
	public static int moveSpeed = 4;
	public static int jumpSpeed = 3;
	public static int jumpHeight=35, jumpCount=0;
 
	public static BufferedImage kyle;
	public static BufferedImage kali;
	public static BufferedImage steve;
	public static boolean isTouchingFloor;
	public static boolean canMove;
	public static boolean isJumping=false;
	public static boolean allowFall=true;
 
	public Character(int x, int y){
		this.x=x;
		this.y=y;
		try {
		    kyle = ImageIO.read(new File("res/Kyle.png"));
		} catch (IOException e) {
		}
	}
 
	public void tick(){
		if(!isJumping && allowFall && !isCollidingWithFloor(new Point(x,(y+44)),new Point((x+16),(y+44)))){
		y+=fallspeed;
		Component.sy+=(fallspeed);
		}else if(Component.isJumping){
				isJumping=true;
			}else{
				y=tiley-45;
				allowFall=false;
			}
 
		if(Component.isMoving){
			if(Component.dir==moveSpeed){
				canMove = isCollidingWithWall(new Point(x+16,y), new Point(x+16,y+40));
			}else if(Component.dir==-moveSpeed){
				canMove = isCollidingWithWall(new Point(x-1,y+2), new Point(x-1,y+40));
			}
 
			if(!canMove){
			x+=Component.dir;
			Component.sx+=Component.dir;
			}else{
				x+=0;
				Component.sx+=0;
				Component.dir=0;
				Component.isMoving=false;
			}
			if(isJumping){
				if(jumpCount>=jumpHeight){
					isJumping=false;
					Component.isJumping=false;
					jumpCount=0;
					allowFall=true;
				}else{
					y-=jumpSpeed;
					Component.sy-=jumpSpeed;
 
					jumpCount+=1;
				}
			}
		}
	}
 
	public boolean isCollidingWithFloor(Point pt1, Point pt2){
		for(int f=0;f<Level.tile.size();f++){
			if(Level.tile.get(f).contains(pt1) || Level.tile.get(f).contains(pt2)){
				tiley=Level.tile.get(f).y;
				isTouchingFloor=true;
				return true;
			}
		}
		isTouchingFloor=false;
		return false;
	}
 
	public boolean isCollidingWithWall(Point pt1, Point pt2){
		for(int g=0;g<Level.tile.size();g++){
			if(Level.tile.get(g).contains(pt1) || Level.tile.get(g).contains(pt2)){
				return true;
			}
		}
		return false;
	}
 
	public void render(Graphics g){
		g.setColor(Color.red);
		g.drawRect(x-Component.sx, y-Component.sy, 16, 44);
		g.drawImage(kyle,x-8-Component.sx,y-Component.sy,null);
 
	}
}

the character object will immediately snap down to the ground without scrolling the stage with it, resulting in the level beginning to leave the screen.

Can you describe what happens in terms of program variables? What variables are set to what values and cause the visual effect you are describing?

Well, according to the printlines, the boolean is false when touching the ground, true when falling, and false when jumping. Also, for some reason moving the object to an area where there is no tile objects won't cause it to fall unless the button to jump is pressed.

I Have no idea if those are the correct values for the boolean variables for the state of the program.

You need to analyze the values of the program's variables when it is not doing what you want to do and see what the values are when the execution goes wrong and then check the code to see why it gave those values to the variables instead of giving them correct values. I other words, you need to debug the code.