Welcome to the Java Programming Forums


The professional, friendly Java community. 21,500 members and growing!


The Java Programming Forums are a community of Java programmers from all around the World. Our members have a wide range of skills and they all have one thing in common: A passion to learn and code Java. We invite beginner Java programmers right through to Java professionals to post here and share your knowledge. Become a part of the community, help others, expand your knowledge of Java and enjoy talking with like minded people. Registration is quick and best of all free. We look forward to meeting you.


>> REGISTER NOW TO START POSTING


Members have full access to the forums. Advertisements are removed for registered users.

Results 1 to 4 of 4

Thread: Java Multithreading Example - Issues

  1. #1
    Junior Member
    Join Date
    Mar 2012
    Posts
    3
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default Java Multithreading Example - Issues

    Hi,

    Problem statement - 5 visitors come to a car showroom having 3 cars. The visitors take a test drive for random time and the other visitors have to wait till a car becomes free. This has to be implemented using Threads.

    I have written the code and it works fine. But, sometimes the output is wierd.

    Code -

    import java.util.Random;

    class VisitorSchool implements Runnable {
    DrivingSchool drivingSchool;

    public VisitorSchool(DrivingSchool drivingSchool) {
    this.drivingSchool = drivingSchool;
    }

    public void run() {
    if (CarsGreaterThanZero()) {
    getInTheCarAndDrive();
    } else if (CarsEqualToZero()) {
    waitForCar();
    getInTheCarAndDrive();
    }
    }

    public boolean CarsGreaterThanZero() {
    synchronized (drivingSchool) {
    if (drivingSchool.getNoOfCars() > 0) {
    return true;
    } else {
    return false;
    }
    }
    }

    public boolean CarsEqualToZero() {
    synchronized (drivingSchool) {
    if (drivingSchool.getNoOfCars() == 0) {
    return true;
    } else {
    return false;
    }
    }
    }

    void waitForCar() {
    synchronized (drivingSchool) {
    try {
    drivingSchool.wait();
    } catch (InterruptedException e) {
    e.printStackTrace();
    }
    }
    }

    void getInTheCarAndDrive() {
    synchronized (drivingSchool) {
    drivingSchool.setNoOfCars(drivingSchool.getNoOfCar s() - 1);
    System.out.println(Thread.currentThread().getName( )
    + " is driving, " + drivingSchool.getNoOfCars()
    + " available");
    }
    Random numGen = new Random();
    int r = numGen.nextInt(1000);
    try {
    Thread.sleep(r);
    } catch (InterruptedException e) {
    e.printStackTrace();
    }
    synchronized (drivingSchool) {
    drivingSchool.setNoOfCars(drivingSchool.getNoOfCar s() + 1);
    System.out.println(Thread.currentThread().getName( )
    + " has done driving, " + drivingSchool.getNoOfCars()
    + " available");
    drivingSchool.notify();
    }
    }
    }

    public class DrivingSchool {
    private int noOfCars = 3;

    public int getNoOfCars() {
    return noOfCars;
    }

    public void setNoOfCars(int noOfCars) {
    this.noOfCars = noOfCars;
    }

    public static void main(String[] args) {
    DrivingSchool drivingSchool = new DrivingSchool();
    VisitorSchool vs1 = new VisitorSchool(drivingSchool);
    Thread t1 = new Thread(vs1, "A");
    VisitorSchool vs2 = new VisitorSchool(drivingSchool);
    Thread t2 = new Thread(vs2, "B");
    VisitorSchool vs3 = new VisitorSchool(drivingSchool);
    Thread t3 = new Thread(vs3, "C");
    VisitorSchool vs4 = new VisitorSchool(drivingSchool);
    Thread t4 = new Thread(vs4, "D");
    VisitorSchool vs5 = new VisitorSchool(drivingSchool);
    Thread t5 = new Thread(vs5, "E");
    t1.start();
    t2.start();
    t3.start();
    t4.start();
    t5.start();
    }
    }



    Acceptable Output -

    A is driving, 2 available
    C is driving, 1 available
    E is driving, 0 available
    A has done driving, 1 available
    B is driving, 0 available
    B has done driving, 1 available
    D is driving, 0 available
    E has done driving, 1 available
    C has done driving, 2 available
    D has done driving, 3 available



    Unacceptable Output -

    A is driving, 2 available
    C is driving, 1 available
    B is driving, 0 available
    D is driving, -1 available
    D has done driving, 0 available
    C has done driving, 1 available
    B has done driving, 2 available
    A has done driving, 3 available

    Please let me know what is the bug in my code and suggest the solution.

    Thanks and Regards,
    Vijay


  2. #2
    Junior Member
    Join Date
    Mar 2012
    Posts
    3
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default Re: Java Multithreading Example - Issues

     
    import java.util.Random;
     
    class VisitorSchool implements Runnable {
    	DrivingSchool drivingSchool;
     
    	public VisitorSchool(DrivingSchool drivingSchool) {
    		this.drivingSchool = drivingSchool;
    	}
     
    	public void run() {
    		if (CarsGreaterThanZero()) {
    			getInTheCarAndDrive();
    		} else if (CarsEqualToZero()) {
    			waitForCar();
    			getInTheCarAndDrive();
    		}
    	}
     
    	public boolean CarsGreaterThanZero() {
    		synchronized (drivingSchool) {
    			if (drivingSchool.getNoOfCars() > 0) {
    				return true;
    			} else {
    				return false;
    			}
    		}
    	}
     
    	public boolean CarsEqualToZero() {
    		synchronized (drivingSchool) {
    			if (drivingSchool.getNoOfCars() == 0) {
    				return true;
    			} else {
    				return false;
    			}
    		}
    	}
     
    	void waitForCar() {
    		synchronized (drivingSchool) {
    			try {
    				drivingSchool.wait();
    			} catch (InterruptedException e) {
    				e.printStackTrace();
    			}
    		}
    	}
     
    	void getInTheCarAndDrive() {
    		synchronized (drivingSchool) {
    			drivingSchool.setNoOfCars(drivingSchool.getNoOfCars() - 1);
    			System.out.println(Thread.currentThread().getName()
    					+ " is driving, " + drivingSchool.getNoOfCars()
    					+ " available");
    		}
    		Random numGen = new Random();
    		int r = numGen.nextInt(1000);
    		try {
    			Thread.sleep(r);
    		} catch (InterruptedException e) {
    			e.printStackTrace();
    		}
    		synchronized (drivingSchool) {
    			drivingSchool.setNoOfCars(drivingSchool.getNoOfCars() + 1);
    			System.out.println(Thread.currentThread().getName()
    					+ " has done driving, " + drivingSchool.getNoOfCars()
    					+ " available");
    			drivingSchool.notify();
    		}
    	}
    }
     
    public class DrivingSchool {
    	private int noOfCars = 3;
     
    	public int getNoOfCars() {
    		return noOfCars;
    	}
     
    	public void setNoOfCars(int noOfCars) {
    		this.noOfCars = noOfCars;
    	}
     
    	public static void main(String[] args) {
    		DrivingSchool drivingSchool = new DrivingSchool();
    		VisitorSchool vs1 = new VisitorSchool(drivingSchool);
    		Thread t1 = new Thread(vs1, "A");
    		VisitorSchool vs2 = new VisitorSchool(drivingSchool);
    		Thread t2 = new Thread(vs2, "B");
    		VisitorSchool vs3 = new VisitorSchool(drivingSchool);
    		Thread t3 = new Thread(vs3, "C");
    		VisitorSchool vs4 = new VisitorSchool(drivingSchool);
    		Thread t4 = new Thread(vs4, "D");
    		VisitorSchool vs5 = new VisitorSchool(drivingSchool);
    		Thread t5 = new Thread(vs5, "E");
    		t1.start();
    		t2.start();
    		t3.start();
    		t4.start();
    		t5.start();
    	}
    }

  3. #3
    Junior Member
    Join Date
    Mar 2012
    Posts
    3
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Default Re: Java Multithreading Example - Issues

    this is working fine.

    package com.oracle;
     
    import java.util.Random;
     
    class Visitor implements Runnable {
    	ThreadExample t;
     
    	Visitor(ThreadExample t) {
    		this.t = t;
    	}
     
    	public void run() {
    		if (t.getNoOfCars() == 0) {
    			synchronized (t) {
    				try {
    					t.wait();
    				} catch (InterruptedException e) {
    					e.printStackTrace();
    				}
    			}
    		}
    		synchronized (t) {
    			t.setNoOfCars(t.getNoOfCars() - 1);
    			System.out.println(Thread.currentThread().getName()
    					+ " is driving, " + t.getNoOfCars() + " car(s) available");
    		}
    		Random numGen = new Random();
    		int r = numGen.nextInt(5000);
    		try {
    			Thread.sleep(r);
    		} catch (InterruptedException e) {
    			e.printStackTrace();
    		}
    		synchronized (t) {
    			t.setNoOfCars(t.getNoOfCars() + 1);
    			System.out.println(Thread.currentThread().getName()
    					+ " has done driving, " + t.getNoOfCars() + " car(s) available");
    			t.notify();
    		}
    	}
    }
     
    public class ThreadExample {
    	private int noOfCars = 3;
     
    	public int getNoOfCars() {
    		return noOfCars;
    	}
     
    	public void setNoOfCars(int noOfCars) {
    		this.noOfCars = noOfCars;
    	}
     
    	public static void main(String[] args) {
    		ThreadExample t = new ThreadExample();
    		System.out.println(t.getNoOfCars() + " cars are available");
    		Visitor v1 = new Visitor(t);
    		Visitor v2 = new Visitor(t);
    		Visitor v3 = new Visitor(t);
    		Visitor v4 = new Visitor(t);
    		Visitor v5 = new Visitor(t);
    		Thread t1 = new Thread(v1, "A");
    		Thread t2 = new Thread(v2, "B");
    		Thread t3 = new Thread(v3, "C");
    		Thread t4 = new Thread(v4, "D");
    		Thread t5 = new Thread(v5, "E");
    		t1.start();
    		t2.start();
    		t3.start();
    		t4.start();
    		t5.start();
    	}
    }

  4. #4
    Member
    Join Date
    Feb 2011
    Posts
    55
    My Mood
    Tolerant
    Thanks
    1
    Thanked 16 Times in 15 Posts

    Default Re: Java Multithreading Example - Issues

    Problem recreated as stated from your original post

    suggested Unacceptable Output thread route
    Thread A to .sleep and Thread B to just about to call getInTheCarAndDrive() thread switch and run
    Thread C to .sleep and Thread D to just about to call getInTheCarAndDrive() thread switch back to
    Thread B to .sleep and Thread D to .sleep
    Thread E to .wait

    So the issue that you seemed to have was one of an:
    Thread D: oops I didn't keep the "check ok to run" and "perform task" in the same sync block. Thus allowing thread switches between the check and the task to allow the other threads to pass through and take the resource that I thought was ok to use... I'll use a resource anyway.

    A quick fix of your old code:
    void getInTheCarAndDrive() {
    		synchronized (drivingSchool) {
    			while(!CarsGreaterThanZero()) waitForCar();//add this line
    			drivingSchool.setNoOfCars(drivingSchool.getNoOfCars() - 1);

Similar Threads

  1. Multithreading and its importance in java
    By jessie143143 in forum The Cafe
    Replies: 0
    Last Post: October 13th, 2011, 03:09 PM
  2. ISSUES in java.awt
    By mailkamlesh in forum AWT / Java Swing
    Replies: 2
    Last Post: August 25th, 2011, 10:36 AM
  3. Java sliding block puzzle issues
    By Vesper in forum What's Wrong With My Code?
    Replies: 15
    Last Post: April 11th, 2011, 08:30 AM
  4. Replies: 0
    Last Post: October 2nd, 2009, 11:51 PM
  5. Replies: 1
    Last Post: April 1st, 2009, 03:47 PM