Thread: I had an old code it really sucked, so i now am making a new one

Check the correct pairing of the {}s
Is all code inside of a method? Its hard to tell with the way the {}s are positioned in your code.

You should post the full text of the error message. Your edited version left important information, like the source line number.

new Color = new Color(196, 195, 181);
Your syntax is wrong. new usually only goes to the right of an = when you create an instance of a class.
What are you trying to do here?

well im trying to set a color for the method to check and if it return true, as in it can find the color move a mouse to that position

What is the name of the variable you are trying to assign the new color value to?

I believe it is:

if (image.getRGB(x, y) == inputColor.getRGB())

inputColor i believe is the one that is being assigned the RGB value

This is what I am talking about:
new Color = new Color(196, 195, 181);

What is that statement supposed to do?

oh ya sorry dident get the question,

ok so the method that includes that little piece is supposed to take a screenshot and look for the specified color, the color is specified by:

new Color = new Color(196, 195, 181);

the above statement is supposed to link the color (new Color) to the color in the get pixel method specifically inputColor, so it specifies what color to look for through inputColor.

Time to go back to the text book and see how to define a variable and give it a value that is an instance of a class.

supposed to link the color (new Color) to the color in the get pixel method

What do you mean by "link"?
(new Color) is not a variable name nor a valid Color object. What is it supposed to be?

ok well if i were declaring a variable for newColor what would i declare it as, int?

ok so what variable would that be declared under? not int or float or long or short right?

well im going to assign it RGB values so that the method knows what value to search for

If RGB values are ints, then create an int variable to hold them.

You still have not said what you want this statement to do.
new Color = new Color(196, 195, 181);

see i havent actually had a class or textbook or anything on this kind learning it as i go so ill research those then get back to you, if you know of a site with good tutorials please tell me

Try some of these:
Trail: Learning the Java Language: Table of Contents (The Java™ Tutorials)
The Really Big Index

<
import java.awt.*;
import java.awt.event.*;
import java.awt.Robot;
import java.awt.AWTException;
import java.awt.Rectangle;
import java.awt.Color;
import java.awt.Toolkit;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
 
public class GB{
public boolean checkColor(Color inputColor) throws Exception
{
 
	Robot robot = new Robot();
	Rectangle rectangle = new Rectangle(0, 0, 1365, 770);
	{
    BufferedImage image = robot.createScreenCapture(rectangle);
    for(int x = 0; x < rectangle.getWidth(); x++) {
        for (int y = 0; y < rectangle.getHeight(); y++) {
            if (image.getRGB(x, y) == inputColor.getRGB()) {
                return true;
            }
        }
    }
    return false;
	}
	{
		while (!checkColor(inputColor)) {
		inputColor = new Color(196, 195, 181);
	}
	}
    }
public static void main(String[] args)
	{
	}
}
>

my updated code that now only has two errors:

1. java.30: unreachable statement
{

2. java:35 missing return statement:
}

Where is line 30. What code is there?
You need to add a return statement at the end of the checkColor() method.
You may have an infinite loop if you call the checkColor method from inside of the checkColor method.

If checkColor() is passed a color as an argument, why do you change its value inside of the method?

Your {}s are not properly aligned. It is very hard to see the nesting of code within loops and methods the way you have them.

ok now i have gotten that a few times, the its hard to read, but i don't know how you want me to fix it so its not as difficult, is there a standard i can look at or something like that?

return false;
}
{
while (!checkColor(inputColor)) {
inputColor = new Color(196, 195, 181);

that is code lines 28-32

wait never mind i figured it out