Thread: Need help playing sound in backround of a program in a loop.(Please Fix my code!)

Im running an Executable JAR

Make sure that the wav file is in the jar archive and in the right place, ie next to TestClass.class. Also that the spelling of the jar entry is "PBnJ.wav". In particular Windows isn't fussy about the case, but jar files are.

I know how to do printlns but what do I add to them to make them debug?

A good place to start would be printing the url you are using for the sound clip. In the case of Eclipse it will be a file: url. Then you go looking on your hard disk to see if the file is at that place.

Do I add the .wav into the jar?
If so how? (If possible using Eclipse)

Could you put the code for detecting if the url is valid? Or do I just check?
Thx for helping.
-Duster

In Eclipse the "File->Export->Runnable Jar" wizard should do this provided you have the wav file in the same place as the class. I think if you copy the wav file into the package tree next to the java file for the class then it gets copied to the right place when the program is compiled.

As far as the url is concerned, just print it. It will be a valid URL, what matters is whether there is a file on your hard disk at that place.

Yes, the wav file goes right next to TestClass in the Eclipse's Package view.

"didnt work" == what? Did you print the url? What did it say? Did you check on your hard disk at that location for the .wav file? Was it there?

THANK YOU SO MUCH. YOU WERE SO HELPFUL! It works! It works! But only in Eclipse... What options do I check when exporting the jar to make sure it will work outside of Eclipse?
The .wav and .gif files are in so many places in the project folder, if I check the right options, it would be hard not to import them.

Thank. You. So. Much.
(I may not be able to get back to you until tomorrow)

-Duster

Maybe I'm wrong - in which case someone should chime in - but I don't think exporting as a *runnable* jar has any options. Exporting as a jar does, and you can select the resources you want to include (they're all listed in a couple of panes at the top of the window). But for runnable jars you just select the launch configuration and how you want libraries handled (if that matters).

If you are exporting a runnable jar and finding that the sound disappears then check the case of the resource names. This is the point I made earlier that Windows will regard Foo.wav and foo.wav as the same, but within a jar file they are different things.

Thanks again for your continued help. So I found out that it does work outside of Eclipse but only with the resource files in the same folder. When I try to export the files into the jar, it can't find them. I have double checked the file names and they are correct. Which option do I select for exporting? And right now, I have the resource files crammed into just about every where possible in the project file.

Thank.You.So.Much.

-Duster

Wait...

Forget the resource thing for now, when I run it it plays for about 30 seconds- then stops and does not loop. The full file is 1:45 long.
Does this have something to do with the AudioClip method? If so is their another one for playing longer music?
Please help.

-Duster

According to the API docs you've got play(), loop() and stop().

In your original post you call loop() which should ... loop. The fact that it stops after c30s is weird. My guess is that whatever is causing that is stopping it from looping. You haven't changed the code and could possibly have stopped the loop somewhere have you?

This guy had the same problem (back in May last year). That's no help, of course - but it's comforting to find you're not alone! The reason I mention that link is that the one person who responded - Andrew Thompson - is one of the Good Guys of the online Java world, and I wouldn't dismiss his suggestion of looking at javax.sound.sampled.Clip. Personally I've never had a problem with AudioClip, but my experience is almost certainly less than his.

The other approach - which also takes work! - is to step back from your current problem and construct a SSCCE. In your case just a frame with background (longish) looping clip. Then gradually add some functionality. If a simple frame+loop functions correctly then the problem lies in the detail of your code somewhere. You mention having resources all over the place, and general randomness of code organisation can (will?) bite you in the @ss like this.

Use the opportunity of a SSCCE to come to grips with resource location and export within Eclipse.

If a simple frame+loop *fails* to function correctly then you have a very specific problem that we can all look at.

-----

Sorry for the absence of magic bullets in this post. javax.sound.sampled.Clip and friends will take work, and so will constructing a SSCCE. Recommendations that people construct a SSCCE are commonplace on sites like this ... for good reason! That's probably the approach I'd take first.

Just out of interest I made a .wav file and adapted the following from your code:

import java.net.URL;
import javax.swing.JFrame;
 
public class LoopFrame extends JFrame {
    AudioClip clip; // <-- note this variable is never used
 
    public static void main(String[] args) {
        new LoopFrame();
    }
 
    public LoopFrame() {
        this.setSize(300, 300);
        this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        this.setTitle("Frame loop test");
 
        URL url = LoopFrame.class.getResource("BWV243 01 Magnificat.wav");
        AudioClip clip = Applet.newAudioClip(url);
        clip.loop();
 
        this.setVisible(true);
    }
}

The program runs, and the wav file (about 3 minutes) loops. So the problem is not with the length of the file.

As I described before the wav resource just sits next to the java source file, and all you do is set the run configuration and destination when you export s a runnable jar. res.jpgexport.jpg

Ok first of all,
Thank.You.So.Much.

I tested your code and it does work. It plays the audio how I would want it. I cant see what the differences between it and my code that make it work or not work, so I am guessing it is something with my code outside of the audio. Im now going to try to rebuild my code around yours. Lets cross our fingers!

You are so helpful.

-Duster

Wait...

I tried to edit my your code to get what I want from mine (minus the button because it is not needed), and got the same issue... Ittl play for about 30 secs then stop. This didnt happen before I edited your code. As you can see, I basically just added a JPanel and its contents, and changed FrameLoop to TestClass where it pops up. Here is the new code:

import java.net.URL;
import javax.swing.ImageIcon;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import java.applet.*;
import javax.swing.*;
import java.awt.*;
 
public class TestClass extends JFrame {
    AudioClip clip; // <-- note this variable is never used
 
    public static void main(String[] args) {
        new TestClass();
    }
 
    public TestClass() {
        this.setSize(300, 300);
        this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        this.setTitle("Frame loop test");
 
        URL url = TestClass.class.getResource("PbnJ.wav");
        AudioClip clip = Applet.newAudioClip(url);
        clip.loop();
 
        this.setVisible(true);
    }
    	JPanel panel = new JPanel();
	{
 
 
		JLabel label = new JLabel("PEANUT BUTTER JELLY TIME");
		panel.add(label);
		ImageIcon pic = new ImageIcon("PBn'J.gif");
		panel.add(new JLabel(pic));
 
 
		this.add(panel);
		this.setVisible(true);
	}
}

Could it have something to do with my many unnecesary imports? If this cant be resolved with a simple solution I will look into one of your suggestions.

Thank you so much.

-Duster

I renamed my wav file, created a gif file and ran exactly the code you posted. It ran fine ie 3 min wav file looped.

But I have a few questions:

Imports are a compiler time thing and don't affect the compiled byte code at all. So that isn't the difference. But why are the other imports there?

Why do you put the resources (the wav file and the gif) in different locations? In particular the ImageIcon constructor you use takes a filename argument and, hence, will be no good once you make a jar file. Applet's newAudioClip() on the other hand takes a URL argument which is more robust (works in a jar or not). I suggest you use the other form of ImageIcon, the one that also takes a URL argument. And for now put both resources in the same place.

Why do you have an initialiser block? (a block of code outside any method or constructor. it's the code you have just after declaring the panel) I suggest you move this code - and the declaration of the panel - into the constructor, and remove the duplicate setVisible() call.

Why keep the unused AudioClip declaration at the start of the class definition. The variable clip declared there is never used.

-----

Most of the above revolves around keeping the code neat, and not just chucking things in at random. (Sorry if that sounds harsher than is meant - I realise you are learning and, by definition, that process is rather random.)

This is your code slightly changed (imports and location of the gif). The API documentation is the place to look to see what alternatives are available.

import java.applet.Applet;
import java.applet.AudioClip;
import java.net.URL;
 
import javax.swing.ImageIcon;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
 
public class TestClass extends JFrame {
 
 
    public static void main(String[] args) {
        new TestClass();
    }
 
    public TestClass() {
        this.setSize(300, 300);
        this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        this.setTitle("PEANUT BUTTER JELLY TIME");
        JPanel panel = new JPanel();
 
        JLabel label = new JLabel("PEANUT BUTTER JELLY TIME");
        panel.add(label);
        //ImageIcon pic = new ImageIcon("PBn'J.gif");
        ImageIcon pic = new ImageIcon(TestClass.class.getResource("PBn'J.gif"));
        panel.add(new JLabel(pic));
 
 
        URL url = TestClass.class.getResource("PbnJ.wav");
        AudioClip clip = Applet.newAudioClip(url);
        clip.loop();
 
        this.add(panel);
        this.setVisible(true);
    }
}

Of course the gif itself has to be moved to wherever you put the wav file.

I'm running it now to see if it loops ... and it does.

We are also using different wav files. Try changing the file you are using. Mine is a wav signed 16bit PCM (whatever that means...)

Also if you are using an older version of Java try compiling it on another computer with a newer version.

Im using Java SE 6 update 30, and I have no idea what you mean about different wave files.

Thanks for helping.

-Duster

All I meant is that *my* wav file loops fine. So maybe something is wrong with the one you are using. I know you said you had played it in another application, but it is still worth replacing it with some other wav file to see what happens.

@DusteroftheCentury: Try creating a button and in action event play the clip again and see if it successfully plays the clip. If it doesn't it clearly means that there is something wrong with the resource you are using to play/loop.
If it does, i guess you can conclude that something is stopping it. This is one of the way to debug this issue right now.