Thread: URgh, drawing a square

My current task is to draw a square and im nowhere near into it. Been working on the project now for about 4 hours and im just confused. Heres my code, atm i can't even get it to do what i want it to do.

 
 
public class Main
{
    public static void main(String args[])
    {
        System.out.print("#Number Of Stars: ");
        int sizeofsquare = 5;
        int line = 1;
        int down = 1;
        int across = 1;
        System.out.println();
 
        while ( line <= sizeofsquare ){
 
            System.out.print("*");
            line = line + 1;
 
        }
 
        while ( down < sizeofsquare ){
 
            down = down + 1;
            System.out.println();
 
            while ( across <= sizeofsquare ){
 
                System.out.print("*");
                across = across + 1;
 
            }
 
        }
 
 
    }
}

Basically im trying to draw a square out of stars after having the user read in how many stars will be along the y and x.

for example if i read in 5 the square would be:

*****
*****
*****
*****
*****

and would change depending on the number i entered, the max number of stars being 40 along the x/y axis.

So far ive managed to get *'s to constantly generate after reading a number and have no idea why they don't stop when the count gets to the number that has been entered.

If you want help, you'll have to provide an SSCCE that demonstrates the problem. You're close, but what is BIO? I assume it's a Scanner?

Also, I'd recommend stepping through this with a debugger, or at least adding print lines that let you know what's going on. For example, what is the value of sizeofsquare each iteration through the loop? When will it be > 40 to allow the loop to exit?

 
 
public class Main
{
    public static void main(String args[])
    {
        System.out.print("#Number Of Stars: ");
        int sizeofsquare = 5;
        int down = 1;
        int across = 2;
        System.out.println();
 
        while ( down <= sizeofsquare ){
 
            System.out.print("*");
 
            while ( across <= sizeofsquare ){
 
                System.out.print("*");
                across = across + 1;
 
            }
 
            System.out.println();
 
            down = down + 1;
 
        }
 
    }
}

Right i've managed to shrink it abit but at the moment i get:

*****
*
*
*
*

when i need:

*****
*****
*****
*****
*****

I don't really understand why the while loop containing the across * stops either :S

Again, I'd recommend stepping through this with a debugger or at least adding print lines to understand what's going on. Pay special attention to the value of across each time through the loops.

Originally Posted by BITmixit

I used the debugger and from what it showed me the while across loop is doing its job then thinking its done and letting the other loop then do its job.

I'm not sure you understand how the loops are working. One is inside the other, they aren't happening one after another.

Originally Posted by BITmixit

However ive tried to move the across=across + 1 and it just makes the across while loop continue forever.

What did you expect that to accomplish?

Originally Posted by BITmixit

Do i need to add another while loop to the mix?

What do you expect that to accomplish?

I suggest you slow down and take a closer look at what your existing program is doing before you attempt to add anything to it.

Another approach would be to write a method that prints a single row of a certain parameterized length, then call that method the correct number of times.

Also, why are you using while loops instead of for loops?