Missing return statement

[mrroberts2u]

Ok all, I have been racking my brain for the last 4 hours. I can not for the life of my figure out return statement I need for my code. (Which is located at the last method; public static String convertIntegerToWords) This is for school and only the second time I have ever had to do this. I hope that I can get some help. Here is my code: ( I apologize now for any formatting errors) Thanks to all in advance.

import java.util.Scanner;
public class marc1 {
 
public static void main(String [] args) {
//Main Method//
 
//Create a Scanner//
    Scanner input = new Scanner(System.in);
 
    //Enter an Integer//   
     System.out.print(" What is your integer ? ");
   int Number= input.nextInt(); 
          while (Number >= 0) {
 
	if (Number == 0) {
	System.out.print( "Thank you for playing! " + "Good bye! ");	
    break;    }
 
	else if (Number != 0)
	validateLength(Number);
     break;  
   }   
}   
   //Next Method//
  public static boolean validateLength(int userNum) {
		String userNumber = "" + userNum;
 
	if (userNumber.length() < 1) {
	System.out.print("The number you entered is too long!");
	  return false;
        }
 
	else
	  return true;
      } 
   //End of validate//
 
   //Final Method//
    public static String convertIntegerToWords(int Number) {
     if (Number == 1)
         System.out.println("Your integer " + Number + "is written out as one");
     else if (Number == 2) 
         System.out.println("Your integer " + Number + "is written out as two");
     else if (Number == 3) 
         System.out.println("Your integer " + Number + "is written out as three");
     else if (Number == 4) 
         System.out.println("Your integer " + Number + "is written out as four");
     else if (Number == 5) 
         System.out.println("Your integer " + Number + "is written out as five");
     else if (Number == 6) 
         System.out.println("Your integer " + Number + "is written out as six");
     else if (Number == 7) 
         System.out.println("Your integer " + Number + "is written out as seven");
     else if (Number == 8) 
         System.out.println("Your integer " + Number + "is written out as eight");
     else if (Number == 9) 
         System.out.println("Your integer " + Number + "is written out as nine");
 
    }
    }

[tomejuan]

remember that all class names should be capitalized!
change the class name to Marc1

for the last method, the method signature clearly indicates that you intend for the method to return a String. yet the method only prints the numbers and does not return anything. there are 2 solutions, the first is just to change the return type to void. the second solution is to return
number + ""; which automatically turns it into a string. you can then print this in another method.

[TopdeK]

remember that all class names should be capitalized!
change the class name to Marc1

for the last method, the method signature clearly indicates that you intend for the method to return a String. yet the method only prints the numbers and does not return anything. there are 2 solutions, the first is just to change the return type to void. the second solution is to return
number + ""; which automatically turns it into a string. you can then print this in another method.

Class names DON'T have to be capitalized. Its just a good coding convention that you do. I was corrected on this fact earlier this week. Also, tomejuan is correct in saying that the reason you have a "missing return error" is due to the fact that your final method is setup to return a String type but you are only printing to the screen. So to correct this, change "String" to "void" in the method's header.

[mrroberts2u]

Thanks for helping me get the return statement taken care of. All errors went away. Now when I went to run the code in my terminal. No matter what I enter, it continuously loops my system.out.print.

[TopdeK]

I modified your main code a bit to reflect what I think you wanted to do. Firstly you seem to exit the program if the user enters a zero but there is no notice to the user about this. Secondly I'm presuming since you have the main program in a while loop, you want the program to run so long as zero is not entered. Finally, your validateLength(), I am taking it that you are looking for input of no more than one (ie the number entered is to be a single digit) based on the "You're number is too long" message. So I changed the conditional bracket in the method to check if the length was "Greater Than" 1 and not "Less Than" as you have it.

    System.out.println("What is your single digit integer?");
	System.out.print("Type 0 to exit: "); //Tell the user how to exit program
	int number= input.nextInt(); 
 
    while (number > 0) { //While the number entered is not 0
 
		if (validateLength(number)){ //Validate number length
			convertIntegerToWords(number); //if true, convert to word
		}
 
		System.out.print("Enter another single digit integer?: "); //request another integer
		number = input.nextInt(); //store the new number and return to start of loop
   }   
 
   System.out.print( "Thank you for playing! Good bye!"); //User has decided to exit so print goodbye message before program ends
}

	if (userNumber.length() > 1) { //change made here!
	System.out.print("The number you entered is too long!");
	  return false;
        }
 
	else
	  return true;
      }

Hope this helps a bit. If I have mistaken your code's functionality just make the necessary amends to facilitate larger numbers.