Refactoring if statement

[jbraque]

Hello all,

This is an example of pseudocode:

if string = "" then
do something
if string case is all capital
do something else
if ...
do something else
...

Which design is better to implement in cases like above? Should i use a strategy pattern and put each condition inside each strategy?

[GregBrannon]

Even in pseudo code, if string.equals( something ), would be preferred, and '==' is the comparison operator, '=' the assignment operator. Using '=', '==', and equals() improperly will confuse the less aware.

I'm not sure what measure one would use to determine the better approach, but what I hear most typically is to use the approach that results in the most readable and understandable source code and then trust in the compiler's optimizer to produce efficient byte code for the JVM.

[jbraque]

Well yes you are right about the pseudocode...
Anyway i thought of putting all strategies in a collection and perform all of them as they will have the same interface.

[aussiemcgr]

I think you'll need to expand on your problem if you want a more desirable answer.
At the moment, it looks like you're just trying to do a handful of if/else statements, but your assumption to use strategy patterns, collections, ect. makes me think you are trying to do something more complex. I'm just not sure what.

[jbraque]

I have to catch multiple exceptions and find which exception was thrown without using a if...else block. The exceptions are written by me and their number so far is 10 and may expand in the future.

an example:

String str = ...
if (str.equals("")) { throw new EmptyStringException}
if (Character.isUpperCase(str)) { throw new WrongCaseException}

[aussiemcgr]

To catch exceptions, you should use a try/catch block. Have you heard of those?

[jbraque]

Ok never mind, thanks