Help! Error with a save and load feature of a java chess game

[davidchan]

Currently I am trying to make a chess game, and one of the part is the save and load feature
Each chess have four data include x,y coordinate, rank and the color.

For the save feature, I use the file output method to save the data in a txt file. The first and second number is xy coordinate, and the third is color, the last is rank.
For instance, I save it like this:
"chess0816chess0618chess1712chess2614chess3415ches s3513"

But I got some problem on the load part. I know how to input the txt file but I got some problem on the loading.
The loading code is like this:



public void load() throws Exception{

File inputfile = new File ("output.txt");
Scanner input = new Scanner(inputfile);
String thisisgreat = input.next();

for (int i =0;i<=thisisgreat.length();i++){

char x = thisisgreat.charAt(i);
char y = thisisgreat.charAt(i+1);
char k = thisisgreat.charAt(i+2);
char p = thisisgreat.charAt(i+3);

if ( (x>='0'|| x<='9')&&(y>='0'|| y<='9')&&(k>='0'|| k<='9')&&(p>='0'|| p<='9')){

Chess ch ;
ch = new Chess( k, p );
GWorld.addOneObject( ch, x, y );

}


}


input.close();
}
When I run the program, it said java.lang.StringIndexOutOfBoundsException: String index out of range: 144

Can anyone help please thank you

[dineshj83]

Best way to save the state of an object is through serialization. why can't you do that and serialize the object while saving and retreive the object through de-serialization.

[davidchan]

Best way to save the state of an object is through serialization. why can't you do that and serialize the object while saving and retreive the object through de-serialization.

Sorry I am a beginner and haven't learn serialized. All i learned is that the fileio
Do you have any other suggestions ? thank you

[dineshj83]

Sorry I am a beginner and haven't learn serialized. All i learned is that the fileio
Do you have any other suggestions ? thank you

Are you familiar with XML?. In that case you can store your data in XML and read it back using parsers which is easy

[GregBrannon]

Or if we go back to your original question, since you're in complete control of what is being stored as the state of the game, you can make your life easier. This string of stored data is confusing:

"chess0816chess0618chess1712chess2614chess3415 ches s3513"

and I have no idea what it means. In your original explanation, it sounds like there are 4 important numbers: x,y,color,rank, so store them exactly like that:

x,y,color,rank // the data necessary to define a chess piece separated by commas

then to read each line from the file:

String[] chessPieceData = input.nextLine().split( "," );

And then you can create the chess piece with the chessPieceData[] array:

ChessPiece chessPiece = new ChessPiece( chessPieceData );

Let me know if you have any questions.

[davidchan]

Or if we go back to your original question, since you're in complete control of what is being stored as the state of the game, you can make your life easier. This string of stored data is confusing:

"chess0816chess0618chess1712chess2614chess3415 ches s3513"

and I have no idea what it means. In your original explanation, it sounds like there are 4 important numbers: x,y,color,rank, so store them exactly like that:

x,y,color,rank // the data necessary to define a chess piece separated by commas

then to read each line from the file:

String[] chessPieceData = input.nextLine().split( "," );

And then you can create the chess piece with the chessPieceData[] array:

ChessPiece chessPiece = new ChessPiece( chessPieceData );

Let me know if you have any questions.

I try your method and get some changes but still can't operate,

my input file like this("0816,0618,1712,2614,4615,5713,6611,6817,0201 ,0007,1103,2205,4204,5102,6208,6006"_
my code:

public void reload() throws Exception{

File inputfile = new File ("output.txt");
Scanner input = new Scanner(inputfile);
String[] thisisgreat = input.next().split(",");

for (int i =0;i<=18;i++){

int x = thisisgreat[i].charAt(0);
int y = thisisgreat[i].charAt(1);
int k = thisisgreat[i].charAt(2);
int p = thisisgreat[i].charAt(3);

Chess ch ;
ch = new Chess( k, p );
GWorld.addOneObject( ch, x, y );
}

}


After I run the program, it said java.lang.ArrayIndexOutOfBoundsException: 16
How can I do?Thank you

[GregBrannon]

The error message is very pointed and helpful. These are the simpler kind of errors that you should know how to fix at this point. You can't iterate past the end of an array, hence the error.

You should also know to avoid the use of "magic numbers" like the '18' in the for loop. A for loop that iterates elements of an array should be:

for ( int i = i ; i < myArray.length ; i++ )