HELP WITH METHODS!

[swirth123]

Hi friends, having trouble using a method to do a calculation and then calling it to be printed. What am I doing wrong? (What I am doing is all the way at the bottom below the main method)

import javax.swing.JOptionPane;
public class hospital_copy {
 
	public static void main(String[] args) {
 
			//Declare variables
				String patient_last, surgery_location, surgery_type, insurance_fee, surgeon_name, output="";
				double agh_count=0, upmc_count=0;
				double fee = 0, agh_fee = 0, upmc_fee = 0, high_fee = 0;
				int count_knee=0, count_hip=0;
				String highest_surgeon="";
				String high_patient="";
				String high_surgeon="";
				String high_location="";
				String more_data = "yes";
				int Atkins_count=0,Johnson_count=0,Smith_count=0;
 
				while(more_data.equals("yes"))
				{
			//Read the data
					patient_last=JOptionPane.showInputDialog(null,"Enter Patient's Last Name",
						"Input Data", JOptionPane.QUESTION_MESSAGE);
 
					surgery_location=JOptionPane.showInputDialog(null,"Enter the Surgery Location (AGH or UPMC)",
						"Input Data", JOptionPane.QUESTION_MESSAGE);
 
					surgery_type=JOptionPane.showInputDialog(null,"Enter the Type of Surgery (knee or hip)",
						"Input Data", JOptionPane.QUESTION_MESSAGE);
 
					insurance_fee=JOptionPane.showInputDialog(null,"Enter the Amount of Fee Paid By Insurance",
							"Input Data", JOptionPane.QUESTION_MESSAGE);
					//parse insurance fee to double
					 fee=Double.parseDouble(insurance_fee);
 
					surgeon_name=JOptionPane.showInputDialog(null,"Enter the Surgeon's Name (Johnson, Atkins, or Smith)",
							"Input Data", JOptionPane.QUESTION_MESSAGE);	
 
					//Count number of each type of surgery
					if(surgery_type.equals("knee"))
						count_knee=count_knee+1;
					else
						count_hip=count_hip+1;
 
					//Count number of surgeries at each location
					if(surgery_location.equals("UPMC"))
					{
						upmc_count=upmc_count+1;
						upmc_fee=upmc_fee+fee;
					}
					if(surgery_location.equals("AGH"))
					{
						agh_count=agh_count+1;
						agh_fee=agh_fee+fee;				
					}
 
					//Count number of surgeries each surgeon did
					if(surgeon_name.equals("Johnson"))
						Johnson_count=Johnson_count+1;
					else
					if(surgeon_name.equals("Atkins"))
						Atkins_count=Atkins_count+1;
					else
						Smith_count=Smith_count+1;
 
					//Find surgeon with highest fee
					if (fee>high_fee)
					{
						high_fee=fee;
						high_patient=patient_last;
						high_surgeon=surgeon_name;
						high_location=surgery_location;
					}
 
					//Ask if more data
				 	more_data=JOptionPane.showInputDialog(null,"More Info? Enter yes or no",
						 "Input Dialog",JOptionPane.QUESTION_MESSAGE);	
				}//End of while loop
 
 
 
 
 
 
				//Calculate average fee for each location
 
 
 
				//Find surgeon with most surgeries
				if ((Johnson_count > Atkins_count)&(Johnson_count > Smith_count))
						highest_surgeon = "Johnson";
				else
					if ((Atkins_count > Johnson_count)&(Atkins_count > Smith_count))
						highest_surgeon = "Atkins";
					else
						highest_surgeon = "Smith";
 
				//Output data
			 	output=output+"Number of Knee Surgeries: "+count_knee+"\n"; 
				output=output+"Number of Hip Surgeries: "+count_hip+"\n"+"\n";
 
 
				output=output+"Number of Surgeries Performed by Johnson: "+Johnson_count+"\n";
				output=output+"Number of Surgeries Performed by Atkins: "+Atkins_count+"\n";
				output=output+"Number of Surgeries Performed by Smith: "+Smith_count+"\n"+"\n";
				output=output+"Doctor Who Performed the Most Surgeries: "+highest_surgeon+"\n"+"\n";
				output=output+"Patient Whose Insurance Paid Highest Fee: "+high_patient+"\n";
				output=output+"Doctor For Above Patient: "+high_surgeon+"\n";
				output=output+"Location of Above Patient's Surgery: "+high_location+"\n";
 
 
				//Display the output dialog box
				JOptionPane.showMessageDialog(null,output,"Output",JOptionPane.INFORMATION_MESSAGE);
				System.exit(0);
 
			}//end class
 
	public static void calc_average(double avagh, double avUPMC){
		System.out.println(avUPMC);
	}
 
 
	public static double calc_averages(double agh_fee,int agh_count){
		double avagh = agh_fee / agh_count;
		return avagh;
	}
 
	public static double calc_average(double UPMC_fee, int UPMC_count){
		double avUPMC = UPMC_fee / UPMC_count;
		return avUPMC;
	}
 
 
		} //end method

[Norm]

What am I doing wrong?

Please explain what the problem is.

[swirth123]

At the very bottom, bellow the main method, I am trying to calculate the average of the fees paid by UPMC (avUPMC) Something is going wrong but I'm getting no errors. Its either its not calculating correctly and not returning anything, or I'm not calling the print method correctly and its just not showing up. This is the part that I am working on and have hit a dead end;

	public static void print(double avUPMC){
		System.out.println(avUPMC);
	}
 
 
	public static double calc_averages(double agh_fee,int agh_count){
		double avagh = agh_fee / agh_count;
		return avagh;
	}
 
	public static double calc_average(double UPMC_fee, int UPMC_count){
		double avUPMC = UPMC_fee / UPMC_count;
		return avUPMC;
	}
 
 
		} //end method

[Norm]

Something is going wrong

Can you explain what the program does and what is "going wrong"?

What do you expect to happen when the code executes?

[swirth123]

It just isnt returning anything with the System.out.println(avUPMC); Its either not calculating and returning avUPMC or I'm not doing the print method correctly. Do I have to initialize anything in the main method or something? I'm completely lost.

I want this method below to calculate the average fees paid at UPMC.

public static double calc_average(double upmc_fee, int upmc_count){
		double avUPMC = upmc_fee / upmc_count;
		return avUPMC;
	}

and i want this to print the results

	public static void printing(double avUPMC){
		System.out.println(avUPMC);
	}

[Norm]

Are the methods you want to execute being called? If they are not called, they will not be executed.

Take a look at the tutorial:
Passing Information to a Method or a Constructor (The Java™ Tutorials > Learning the Java Language > Classes and Objects)

[swirth123]

This is a very good link, thank you. But I really dont understand what I personally am doing wrong then. If you could answer this...how would you call back "answer" and have it print it in a separate method in this example? Bellow it is how I think I should be doing it.

public double computePayment(
                  double loanAmt,
                  double rate,
                  double futureValue,
                  int numPeriods) {
    double interest = rate / 100.0;
    double partial1 = Math.pow((1 + interest), 
                    - numPeriods);
    double denominator = (1 - partial1) / interest;
    double answer = (-loanAmt / denominator)
                    - ((futureValue * partial1) / denominator);
    return answer;
}

public static void computePayment(double answer){
System.out.println(answer);
}

--- Update ---

Is there something else I need to do in the unseen main method in order to make it work? I feel like it needs to be initialized in the main method or something. This is only speculative but I'm really pulling my hair out trying to figure out what I'm not doing correctly

[Norm]

When a method returns a value, the calling code needs to assign the returned value to a variable:

double someVar = computePayment(put needed args here);

someVar now has the value that was returned by the computePayment() method from what was in the answer variable in the computePayment() method.

The method you posted will print out the value of the double arg that was passed to it.
That method has NO relationship with the computePayment() that was coded above it.

what I'm not doing correctly

You still have not explained what is wrong and what you expect the program to do differently.

[swirth123]

double someVar = computePayment(put needed args here);

Which method is this going in? Main?

Also what I want it to do is work, when I run it nothing happens and the console is blank. I want a method to take information from the main method and compute the average, then return it to yet another method to print the results.

[Norm]

Which method is this going in?

That statement could be coded in any method that is in the same class as the computePayment() method.

want a method to take information from the main method and compute the average, then return it to yet another method to print the results.

Then you need to have a statement that calls the method you want to execute and pass it whatever values it needs.

I'm done for tonight. Back tomorrow.

[Tamilarasi]

you didn't call the methods like calc_averages() and calc_average() anywhere then how to print the average in your screen..
you first call the methods in your class and assign return statement in to variable.

Finally you print that variable ...

[StephenCoyle]

Your code compiles because it's syntax is correct. However as already mention

Then you need to have a statement that calls the method you want to execute and pass it whatever values it needs.

Java Tutorials - Defining Methods