GUI issue

[Pusillus]

So I'm making a really simple counter for use while playing Magic the Gathering, my goal is to have 2 buttons (looking like arrows) one to count up and one to count down, however when I try and execute it looks like this:



I've tried with down.setIgnoreRepaint(true);, but it doesn't help.

GUI code:

package magic.counter;
 
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
 
public class GUI extends JPanel {
    Image op1 = Toolkit.getDefaultToolkit().getImage("op.png");
    Image ned = Toolkit.getDefaultToolkit().getImage("ned.png");
 
    ImageIcon op = new ImageIcon(op1);
    ImageIcon ned1 = new ImageIcon(ned);
 
    JButton up = new JButton();
    JButton down = new JButton();
 
    int tæller = 20;
 
public void paintComponent(Graphics g){      
    down.setIgnoreRepaint(true);
    up.setIgnoreRepaint(true);
 
    add(up);
    up.setLocation(75,10);
    up.setBorder(BorderFactory.createEmptyBorder());
    up.setContentAreaFilled(false);
    up.setIcon(op);
 
 
 
    up.addActionListener(new ActionListener() {
 
         public void actionPerformed(ActionEvent e)
         {
             //Execute when button is pressed
             tæller++;
             repaint();            
         }
    });
 
    add (down);
    down.setLocation(75, 150);
    down.setBorder(BorderFactory.createEmptyBorder());
    down.setContentAreaFilled(false);
    down.setIcon(ned1);
 
 
    up.addActionListener(new ActionListener() {
 
         public void actionPerformed(ActionEvent e)
         {
             //Execute when button is pressed
             tæller--;
             repaint();            
         }
    });     
 
    g.drawString(""+tæller+"", 125, 125);          
}
 
}

Main code:

package magic.counter;
 
import javax.swing.*;
 
public class MagicCounter {
 
    public static void main(String[] args) {
        JFrame Vindue = new JFrame("MTG counter");
        Vindue.add( new GUI());
        Vindue.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
        Vindue.setSize(625,300);
        Vindue.setVisible(true);
    }
}

Please help a young and confused programmer, and don't laugh too hard

[curmudgeon]

Don't add components or do any program logic inside of a paint or paintComponent method. These methods are for painting and painting only. Instead add your components, add your ActionListeners and do your logic in your class's constructor or initComponents or init method (if an applet) or other non-painting methods.

[Pusillus]

Tried moving it out of paint like so

public void init(){
 
    add(up);
    add (down);
    up.setLocation(75,10);
    up.setBorder(BorderFactory.createEmptyBorder());
    up.setContentAreaFilled(false);
    up.setIcon(op);
 
 
 
    up.addActionListener(new ActionListener() {
 
         public void actionPerformed(ActionEvent e)
         {
             //Execute when button is pressed
             tæller++;
             repaint();            
         }
    });
 
 
    down.setLocation(75, 150);
    down.setBorder(BorderFactory.createEmptyBorder());
    down.setContentAreaFilled(false);
    down.setIcon(ned1);
 
 
    up.addActionListener(new ActionListener() {
 
         public void actionPerformed(ActionEvent e)
         {
             //Execute when button is pressed
             tæller--;
             repaint();            
         }
    });     
 
    }

but then the images doesn't show?

[Purple01]

I also had problems with the layout from the GUI when I made one a months ago.
I also had a hard time by placing them in the way I wanted them on the GUI, so I solved it by using a GridLayout.
On that you can also place a button and attach an image to that.

[Pusillus]

The problem is still not fixed, any ideas?

[jps]

The problem is still not fixed, any ideas?

Please provide a description of what the code should do, what it does do, and the current version of the code.
I see 6 or 8 possible arrows, which 2 of the group did you want?

[Pusillus]

The code should be a counter, so basically it needs to be 2 arrows, 1 up and 1 down, and a number, when you press the up arrow it's supposed to count 1 up, and vice versa, however my problem is as displayed on the screenshot that it paints so many arrows.

[jps]

where is the current version of the code?

[cool_techie]

One apparent problem that I see is that you are trying to do absolute positioning for your gui components (buttons) without setting the layout manager to null. You must make a call to setLayout(null) in order for absolute positioning to work as expected. Besides, the code seems dirty to me and you need to do a lot of reading regarding how to build a gui.