Image looping issue

[Montario]

Hello everyone

I have been trying to loop an image using the for loop within graphics 2D which consists of 17 images on the x axis and 17 images (across) on the y axis (down), creating a 'L' shape. When I compile and run the program however it prints 17 images on the y axis and none on the x. I have no idea what fault I have made as whatever I do it seems to ignore the x axis (or at least the way i interpret it to be printed.) How do I make it print along the x-axis? What exactly am I doing wrong? Here is my code:

  private void drawMaze(Graphics2D g){
    	Graphics2D g2 = (Graphics2D)g;
 
    	    int width = 17; //number of images drawn along the x-axis (none)
            int height = 17; //number of images drawn along the y axis
            int xOffset = 21; //width of image
            int yOffset = 21; //height of image
            int currentX = 10; //initial x coordinate of image
            int currentY = 10; //initial y coordinate of image
            for(int i = 0; i < width; i++) {
                 for(int j = 0; j < height; j++) {
                       g2.drawImage(cobblestone.getImage(), currentX, currentY,this);
                       currentY += yOffset;
                 }
                 currentX += xOffset;
                 currentY = 0;

Any help would greatly be appreciated, thanks!

[Norm]

The nested loops look ok. The ending } for the outer loop is missing. Is there any code is missing?

Add a call to print() that prints out the x and then all the y values on each column for each image that is drawn to show where the images are being drawn. Add a println() after the end of the inner loop.

[Montario]

Thanks Norm, I was missing some little code and never ended the outer loop, a silly unnoticeable mistake. Thank you so much! How would I go about making the printed box of images hollow however? I have a 17x17 box of images, how would I program it to just print the outer edges?

[Norm]

how would I program it to just print the outer edges?

Control the values of x and y to place the images where you want them drawn.

[Montario]

So does that mean there is no way of making the box of 17x17 images 'hollow' through looping? Looping was what I was aiming for instead of manually printing out similar codes for ages.

[Norm]

You should be able to use loops. There are two rows and two columns

[Montario]

How would I go about doing that? I am having issues as to how I can do that using as little code as possible, thanks for your help so far.

[Norm]

Draw the grid of images. Write down the x,y value for each of the 4 sides and look at how the x,y values change for each of the 4 areas you are putting images into.

The easiest solution looks like 3 to 4 loops

[Montario]

I have done what you said and tried changing the values of 'currentX' and 'currentY' within the new loops, but nothing is working. What should the loops consist of?

[Norm]

There are 4 areas to put the images in: two rows and two columns
To put images in a row, change the x value, leave the y value unchanged.
To put images in a column, change the y value, leave the x value unchanged.

The loops could be doubled up to do two rows (or two columns) at a time.

[Montario]

Ok, so now I have manged to create a 'L' shape using 2 loops, half way done now. However I am having slight troubles creating the other column and row. Here is the code so far, a few alterations have been made:

private void drawMaze(Graphics2D g){
    	Graphics2D g2 = (Graphics2D)g;
 
            int length = 16; 
            int xOffset = 21; 
            int yOffset = 21; 
            int currentX = 10; 
            int currentY = 10; 
                 for(int j = 0; j < length; j++) {
                       g2.drawImage(cobblestone.getImage(), currentX, currentY,this);
                       currentY += yOffset;
                       }
                 for(int k = 0; k < length; k++) {
                	   g2.drawImage(cobblestone.getImage(), currentX, currentY,this);
                	   currentX += xOffset;
                	   length = 27;
                       }
            }

I tried to make the 3rd loop for my second column, though when I set the value of Current X within my loop to 540, it only printed out one image in my second column. Why is this?

[Norm]

when I set the value of Current X within my loop to 540, it only printed out one image in my second column

Can you post the code did that?
Try debugging the code by adding printlns that print the values of x and y where the images are being drawn.

[Montario]

I do not recall the exact code as it was deleted; here is some of it though.

for(int l = 0; l < length; l++) {
                	   g2.drawImage(cobblestone.getImage(), currentX, currentY,this);

What should I do for this loop? Every variable I change ends up ruining the columns and rows.

[Norm]

What prints out when you add the println to print the x,y locations for each of the images you are drawing?

I assume that the x,y locations are the problem you are having, so if you print them out we can see where the problem is.

[Montario]

It prints out exactly the same thing, only one image on the column.

 for(int l = 0; l < length; l++) {
                	   g2.drawImage(cobblestone.getImage(), 560, 10,this);
                	}
                 }

[Norm]

Please post the print outs that shows the x and y values of where the image is being draw and the code that generated the output.

For testing you should reduce the width and height to a smaller value like 5 or 7 vs 17.

[Montario]

I thought the x and y values of where the images were being drawn were in the currentX and currentY variables?

[Norm]

Look at the code to get the names of the variables. You are probably correct with their names.

Please post the print outs that shows the x and y values of where the image is being draw and the code that generated the output.

[Montario]

 int length = 5; 
            int xOffset = 21; 
            int yOffset = 21; 
            int currentX = 10; 
            int currentY = 10; 
                 for(int j = 0; j < length; j++) {
                       g2.drawImage(cobblestone.getImage(), currentX, currentY,this);
                       currentY += yOffset;
                       }
                 for(int k = 0; k < length; k++) {
                	   g2.drawImage(cobblestone.getImage(), currentX, currentY,this);
                	   currentX += xOffset;
                	   length = 7;
                 for(int l = 0; l < length; l++) {
                	   g2.drawImage(cobblestone.getImage(), 560, 10,this);
                 }
                 }
    }

My currentX and currentY variables determine the x and y positioning. The variable Length is just the number of images printed.

[Norm]

Where is the print out of the values of the x and y locations where you are drawing the images?

I don't see any println statements in the code you posted. Add some println statements to print out the values of where each image is being drawn.

[Montario]

I don't understand what you mean by println statements? Aren't those only for strings? Sorry, i'm still getting used to java!

[Norm]

To get debug output so you can see what the code is doing, print the values of the variables using:

System.out.println("var=" + var + ", anotherVar=" 
              + anotherVar + ", andMore=" + andMore);

replace var, anotherVar and andMore with the names of the variables in your program

[Montario]

To get debug output so you can see what the code is doing, print the values of the variables using:

System.out.println("var=" + var + ", anotherVar=" 
              + andMore);

I am a bit confused as to what is going on here, what are all the '=' and quotes at different places for?

[Norm]

The = are part of the String to be printed. The above would print out something like this:
var=234, anotherVar=34, andMore=333


The "s define Strings. The +s concatenate all the Strings into a single String which is printed.

[Montario]

I get an infinite pattern of this:

currentX= 31, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 52, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 73, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 94, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 115, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 136, currentY = 115, xOffset = 21yOffset = 21 and length = 7
currentX= 157, currentY = 115, xOffset = 21yOffset = 21 and length = 7

This is the code which executed this:

System.out.println("currentX= " + currentX + ", currentY = " + currentY +
                 		", xOffset = " + xOffset + "yOffset = " + yOffset + " and length = " + length )