Thread: infinite loop on pig latin program

Well, just think about it, your loop will stop when the following condition is false:

wordToTranslate.equalsIgnoreCase("q")

Now look at every single point in your program where the value of "wordToTranslate" is being set.
You will realize that it is only set once, and that is at the very beginning of the program.
So if the condition is not false the first time it is being checked, then it will never be false the second or third time either, or any other time after that. Because the value will never spontaniously change.

Originally Posted by Cornix

Well, just think about it, your loop will stop when the following condition is false:

wordToTranslate.equalsIgnoreCase("q")

Now look at every single point in your program where the value of "wordToTranslate" is being set.
You will realize that it is only set once, and that is at the very beginning of the program.
So if the condition is not false the first time it is being checked, then it will never be false the second or third time either, or any other time after that. Because the value will never spontaniously change.

I've tweaked this a little and it doesn't loop anymore but I lost the ability to quit when 'q' is entered.

 
/******************
*Pig Latin Program
 
Eddy Caraballo
******************/
 
import java.util.Scanner;
public class PigLatin5 {
 
   public static void main(String[] args)
   {
      System.out.println("give me a word to translate or press 'q' to quit");    //displaying question//
      Scanner scan = new Scanner(System.in);       
 
      String wordToTranslate = scan.nextLine();                                  //taking user input and creates new variable//
      char v = Character.toLowerCase(wordToTranslate.charAt(0));                 //looking for the first letter of the word that is being input//
 
      while (wordToTranslate != "q")
      {
         System.out.println("give another word or press 'q' to quit");
         wordToTranslate = scan.nextLine();
 
 
      if (v == 'a' || v == 'e' || v == 'i' || v == 'o' || v == 'u')              //if first letter of inputted word is any of these letters(vowels)//
      {
          String pigLatinTranslation = wordToTranslate + "way";                  //then create new word with way at the end//
          System.out.println(pigLatinTranslation);                               //displays new word//
      }
 
      else                                                                       //otherwise//
      {
         String firstLetter = wordToTranslate.substring(0,1);                    //creates a new variable named firstLetter that comes from a section(substring) of "wordToTranslate" starting at character 0 and ending at character 1//
         String endOfWord = wordToTranslate.substring(1,wordToTranslate.length()); //creates a new variable named endOfWord that comes from a section(substring) of "wordToTranslate" starting at character 1 and ending at the length of the word//
         System.out.println (endOfWord + firstLetter + "ay");
 
      }
 
      }
 
   }  
 
}

The condition in your first version was not wrong, it was actually correct. The changes you made to the condition, however, are not correct.
You need to compare strings using the "equals" method. Comparing with "==" does not work for strings in java.