Thread: Cannot make static reference to a non-static method?

Cannot make a static reference to the non-static method

This is because the calls are being made from the static method: main. The non static methods can only be referenced when a reference to an instance of the class is used.
Create an instance of the class and use the reference to that instance to call the class.

Here is an example from your code:

		Scanner gallons = new Scanner(System.in);    // create instance of class with reference: gallons
		int numGallons = gallons.nextInt();                // use reference to call class's nextInt method

Another (non-OOP) solution is to make the methods static.

Unreachable code means that due to some logic, that code won't be reached. Here is an example:

void foo() {
    // do something
    return;
    a = 10;  <-- this code will not be reached.
}

In your case, it was menuSelect.close() after the break. But just delete the statement, don't close Scanner.


Regarding the static reference. That means you can't access an instance field or method from a static context.

class Foo {
    int a; // instance field
    public static void main(String[] args) {  <-- note the word static.
            a = 10; <--  not allowed.  You would have to do it like this
            Foo f = new Foo();
            f.a = 10;
    }
}

Also, only create one instance of Scanner. If you use it to read input from the console, don't close it.

Regards,
Jim

double tsp =  1/48;

The value of that expression will be 0. To get a double value change one of the operands to a double: 1/48.0

nature of a case/break menu structure

The break will exit the switch statement instead of falling through to the next case statement.

But won't my program crash or be stuck in limbo if I don't close the menu?

No, it won't. In fact, if you were to continue to ask for input for conversions, say in a loop, your program wouldn't work.

Try running this simple program to see what happens when you close the Scanner and try to reopen it and take input.

import java.util.Scanner;
 
public class ScannerDemo {
   public static void main(String[] args) {
	  Scanner input = new Scanner(System.in);
	  System.out.print("Enter a number: ");
	  int v = input.nextInt();
	  System.out.println("You entered " + v);
	  input.close();
	  input = new Scanner(System.in);
	  System.out.print("Enter a number: ");
	  v = input.nextInt(); // <--- KaBoom!!
	  System.out.println("You entered " + v);
	  System.out.printf("Done!");
   }
}

The reason this happens is when you close the Scanner, it then closes the console for input.

So a single instance of Scanner should be used for all of your console input. And don't close it.

Regards,
Jim

Originally Posted by jim829

The reason this happens is when you close the Scanner, it then closes the console for input.

So a single instance of Scanner should be used for all of your console input. And don't close it.

Is there any way that I could get my program to repeat the switch structure until the user chooses 6?

import java.util.Scanner;
 
 
public class UnitsToCups {
 
	public void displayMenu(){
		System.out.println("Option 1: Convert teaspoons to cups\n Option 2: Convert tablespoons to cups\n" +
							"Option 3: Convert pints to cups\n Option 4: Convert quarts to cups\n Option 5: Convert gallons to cups\n" +
							"Option 6: Exit");
	}
	double tsp = 1/48.0;//0.0208333333333333;//1 teaspoon = 1/48 of a cup
	double tbsp = 0.0625;//1 tablespoon = 1/16 of a cup
	int pint = 2;//1 pint = 2 cups
	int quart = 4;//1 quart = 4 cups
	int gallon = 16;//1 gallon = 16 cups
 
	public void Menu(){
		Scanner menuSelect = new Scanner(System.in);
		//while(menuSelect < 6){
			switch(menuSelect.nextInt()){
			case 1:
				System.out.println("Enter number of teaspoons: ");
				Scanner teaspoons = new Scanner(System.in);
				int numTsp = teaspoons.nextInt();
				double cups1 = tsp * numTsp;
				System.out.println(numTsp + " teaspoons is equivalent to " + cups1 + " Cups, or (Fraction?)");
				teaspoons.close();
				break;
			case 2:
				System.out.println("Enter number of tablespoons: ");
				Scanner tablespoons = new Scanner(System.in);
				int numTbsp = tablespoons.nextInt();
				double cups2 = tbsp * numTbsp;
				System.out.println(numTbsp + " tablespoons is equivalent to " + cups2 + " Cups, or (Fraction?)");
				tablespoons.close();
				break;
			case 3:
				System.out.println("Enter number of pints: ");
				Scanner pints = new Scanner(System.in);
				int numPints = pints.nextInt();
				double cups3 = pint * numPints;
				System.out.println(numPints + " pints is equivalent to " + cups3 + " Cups, or (Fraction?)");
				pints.close();
				break;
			case 4:
				System.out.println("Enter number of quarts: ");
				Scanner quarts = new Scanner(System.in);
				int numQuarts = quarts.nextInt();
				double cups4 = quart * numQuarts;
				System.out.println(numQuarts + " quarts is equivalent to " + cups4 + " Cups, or (Fraction?)");
				quarts.close();
				break;
			case 5:
				System.out.println("Enter number of gallons: ");
				Scanner gallons = new Scanner(System.in);
				int numGallons = gallons.nextInt();
				double cups5 = gallon * numGallons;
				System.out.println(numGallons + " gallons is equivalent to " + cups5 + " Cups, or (Fraction?)");
				gallons.close();
				break;
			case 6:
				System.out.println("Bye!");
				//menuSelect.close();//A single instance of scanner should be used for all console input, so don't close it.
				break;
			default:
				System.err.println("Invalid option. Choose an option from 1 to 5.");
				break;			
			}
			System.out.println("The program has passed the default portion of the switch structure.");
		//}//end of while loop
 
	}	
 
	public static void main(String[] args){
		UnitsToCups x = new UnitsToCups();
		x.displayMenu();
		System.out.println();
		x.Menu();		
	}
}

PS: how do I remove attached thumbnails from my posts?

get my program to repeat the switch structure until the user chooses 6?

Yes, use a loop.
What happened when the while was working?

BTW, Your thumbnail image of the error "NoSuchElementException" is what happens when you try to read from a closed console.

Regards,
Jim