Difficulty in creating/writing to a file (also, with reading file with data)

**Norm** · November 19th, 2018, 12:48 PM

including a system.out.println statement in them doesn't generate anything

If the code has a call to the println method and nothing is printed, that means the code is not being executed.
Check to see if there is another version of the class that is being executed instead of the one that has the added println statements.

I create a main method, attempt to invoke the method, can't do so

Don't add any main methods. The debugging is supposed to be of the whole program when it is executed normally.
The object of the print statements is to show the contents of items after something is added to it and when its contents are supposed to be displayed in the toString method.
The current code shows that the City object being added to items is lost before the call to the toString method.

Can you post the version of the Repository class that has the debug println statements?

**Tokugawa** · November 19th, 2018, 03:53 PM

package repositories;
 
import java.util.ArrayList;
import java.util.function.Predicate;
import model.City;
 
 
public class Repository implements RepositoryInterface {
    private ArrayList<City> items;    
 
    public Repository() {
        this.items = new ArrayList<>();       
    }
 
    public Repository(ArrayList <City> items) {        
        this.items = items;
    }
 
    public Repository(String filename) {
        this();
        // Create dao and execute load  
    }
 
    @Override
    public ArrayList<City> getItems() {        
        return this.items;
    }
 
    @Override
    public void setItems(ArrayList<City> items) {        
        this.items = items;
    }
 
    @Override
    public void add(City items) {
        this.items.add(items);
        System.out.println("value of items"+items);
    }
 
    @Override
    public void remove(int id) {
        Predicate<City> predicate = e->e.getId() == id;       
        this.items.removeIf(predicate);
    }
 
    @Override
    public City getItem(int id) {
 
        for (City item:this.items) {
            if (item.getId() == id)
                return item;
        }
        return null;
    }
 
    @Override
    public String toString() {
 
        return "\nItems: " + this.items;
    }    
 
    @Override
    public void store(String filename) {       
        // create dao and execute store    
    }        
}

**Norm** · November 19th, 2018, 04:35 PM

That's half of it. Also copy that println statement in the add method to the toString method.
Then compile the code and execute it to see what happens.

**Tokugawa** · November 19th, 2018, 04:42 PM

package repositories;

import java.util.ArrayList;
import java.util.function.Predicate;
import model.City;

public class Repository implements RepositoryInterface {
private ArrayList<City> items;

public Repository() {
this.items = new ArrayList<>();
}

public Repository(ArrayList <City> items) {
this.items = items;
}

public Repository(String filename) {
this();
// Create dao and execute load
}

@Override
public ArrayList<City> getItems() {
return this.items;
}

@Override
public void setItems(ArrayList<City> items) {
this.items = items;
}

@Override
public void add(City items) {
this.items.add(items);
System.out.println("value of items in the add method is:"+items);
}

@Override
public void remove(int id) {
Predicate<City> predicate = e->e.getId() == id;
this.items.removeIf(predicate);
}

@Override
public City getItem(int id) {

for (City item:this.items) {
if (item.getId() == id)
return item;
}
return null;
}

    @Override
    public String toString() {
           System.out.println("value of items in the toString method is"+items);
 
        return "\nItems: " + this.items;
 
    }    
 
    @Override
    public void store(String filename) {       
        // create dao and execute store    
    }        
}

I have to compile the whole project, because that file does not have a main method. The project runs, and I get:

items []
value of items in the toString method is[]

**Norm** · November 19th, 2018, 04:48 PM

there is absolutely nothing generated, the print statements dont run.

Why? Do you mean nothing is printed? If nothing is printed, then the code is not executed. That could mean there is more than one version of the Repository class. One that you are making changes to and the other that is used when the program is executed.

The idea of this debugging with the print statements in the Repository class was for the whole project to be executed normally to see what was printed when this following code from post#5 was executed:

              repository.add(city);      //<<<<<< This should execute one of the println statements
 
              System.out.println("value of repository is"+repository);   //<<<<<<<< this should execute the other println statement

**Tokugawa** · November 19th, 2018, 04:51 PM

I have to compile the whole project, because that file does not have a main method. The project runs, and I get:

items [] 
value of items in the toString method is[]

**Norm** · November 19th, 2018, 04:57 PM

items []

Where does that output come from? There isn't any posted code that shows that.

Where is the output from the add method from this statement:

   System.out.println("value of items in the add method is:"+items);

Where is the output from this line of code in post#5?

               System.out.println("value of repository is"+repository);

**Tokugawa** · November 19th, 2018, 04:59 PM

System.out.println("value of repository is"+repository); that is no longer appearing, whether I load a file or not.

System.out.println("value of items in the add method is:"+items); that appears in the console when I run the program

**Norm** · November 19th, 2018, 05:11 PM

that is no longer appearing,

Did you change the code in the load method in post#5 and remove that println statement?

Can you restore all the code to what was in it when you made post#5?
Then add the two println statements to the Repository class, compile and run the program so that it executes the load method.

Can you post the current version of the load method?

**Tokugawa** · November 19th, 2018, 05:13 PM

 
 
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package daos;
 
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.io.PrintWriter;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;
import model.City;
import model.YearData;
 
import repositories.Repository;
 
/**
 *
 * @author mga
 */
public class DAOTextImpl implements DAOInterface {
      private ArrayList<YearData>yeardata;
 
    static final char DELIMITER=',';   
 
 
 
 
    @Override
    public Repository load(String filename) {
 
        Repository repository = new Repository();
 
        try (BufferedReader br = new BufferedReader(new FileReader(filename))) { 
 
            String[] temp;
            String line = br.readLine();
            while(line!=null){
 
 
                temp=line.split(Character.toString(DELIMITER));        
                int id = Integer.parseInt(temp[0]);
                String cityName = stripQuotes(temp[1]);
                String country=stripQuotes(temp[2]);
                City city=new City (id, cityName, country);
 
   repository.add(city);
 
 
                  /*  line=br.readLine();
                    temp=line.split(Character.toString(DELIMITER));
                    String year=stripQuotes(temp[4]);
                    float precipitation=Float.parseFloat(temp[5]);
                    int maxTemp=Integer.parseInt(temp[6]);
                    int minTemp=Integer.parseInt(temp[7]);
                    int windSpeed=Integer.parseInt(temp[8]);
                    String windDirection=stripQuotes(temp[9]);
                 YearData yeardata=new YearData(year, precipitation, maxTemp, minTemp,windSpeed, windDirection); */
 
 
 
 
                 line = br.readLine();                
            }
 
 
 
 
 
 
 
            br.close();
        } catch (IOException ex) {
            Logger.getLogger(DAOTextImpl.class.getName()).log(Level.SEVERE, null, ex);
        }
        return repository;
 
    }
 @Override
 
 public void store(String filename, Repository repository) {
try (PrintWriter output = new PrintWriter(filename)) {
System.out.println("blah");
System.out.println("value of repository is"+repository);
System.out.println("value of repository is"+repository.toString());
System.out.println("value of repository is"+repository.toString(DELIMITER));
output.print(repository.toString());
 
output.close();
 
} catch (FileNotFoundException ex) {
Logger.getLogger(DAOTextImpl.class.getName()).log( Level.SEVERE, null, ex);
}
 
} 
 
    private String stripQuotes(String str) {
        return str.substring(1, str.length()-1);
    }
}

No, not changed

**Norm** · November 19th, 2018, 05:17 PM

What prints on the console when that version of the load method is executed?

Add this statement after the call to add:

  System.out.println("value of repository is"+repository);

Run the code and copy the contents of console and paste it here.

**Tokugawa** · November 19th, 2018, 05:20 PM

debug:
Weather App
===========

Load an existing File (Y/N)?:
y
Enter filename:
tony2

value of items in the toString method is!!!!!!!!!![]

Items: []

A. Add City B. Add new year data C. List Country Data In City Name Order D. List City Average Data E. List City Weather Data In City ID Order Q. Quit
Enter choice:
Q
Enter filename:
tony10
Thank you for using Weather App. Good bye.

BUILD SUCCESSFUL (total time: 15 seconds)

**Norm** · November 19th, 2018, 05:22 PM

Where is the printout from the add method?

**Tokugawa** · November 19th, 2018, 05:23 PM

Would it be easier if Just start from scratch?

--- Update ---

It doesn't output/appear

**Norm** · November 19th, 2018, 05:27 PM

A problem is you are changing things and not telling me about it.
There was supposed to be print statements in the add method and the toString method.
The code in the load method was supposed to call the add method and the toString methods which would each print something.
There wasn't a print out from the add method.

I can't make any more suggestions because I have no idea what is currently in the code.

**Tokugawa** · November 19th, 2018, 05:30 PM

There is a print statement in the add method, and the toString method. Only the toString method actually returned a value. The printout of the add method doesn't show/doesn't exist, as I've stated several times. I havent' changed anything without telling you :\

**Norm** · November 19th, 2018, 05:43 PM

The printout of the add method doesn't show

If there is a print statement in the Repository class's add method that does not print anything, then that method is not being called.
If that method is not called, then it won't add to the items ArrayList.

Where is the code for the add method that is called in the load method?

**Tokugawa** · November 19th, 2018, 05:48 PM

Where is the code for the add method that is called in the load method?
There isn't any.

Do you mean the printout statement?

That was in the repository class, not the class which has the load method :\

Oh wait,

 
 
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package daos;
 
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.io.PrintWriter;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;
import model.City;
import model.YearData;
 
import repositories.Repository;
 
/**
 *
 * @author mga
 */
public class DAOTextImpl implements DAOInterface {
      private ArrayList<YearData>yeardata;
 
    static final char DELIMITER=',';   
 
 
 
 
    @Override
    public Repository load(String filename) {
 
        Repository repository = new Repository();
 
        try (BufferedReader br = new BufferedReader(new FileReader(filename))) { 
 
            String[] temp;
            String line = br.readLine();
            while(line!=null){
 
 
                temp=line.split(Character.toString(DELIMITER));        
                int id = Integer.parseInt(temp[0]);
                String cityName = stripQuotes(temp[1]);
                String country=stripQuotes(temp[2]);
                City city=new City (id, cityName, country);
 
   repository.add(city);
 
 
                  /*  line=br.readLine();
                    temp=line.split(Character.toString(DELIMITER));
                    String year=stripQuotes(temp[4]);
                    float precipitation=Float.parseFloat(temp[5]);
                    int maxTemp=Integer.parseInt(temp[6]);
                    int minTemp=Integer.parseInt(temp[7]);
                    int windSpeed=Integer.parseInt(temp[8]);
                    String windDirection=stripQuotes(temp[9]);
                 YearData yeardata=new YearData(year, precipitation, maxTemp, minTemp,windSpeed, windDirection); */
 
 
 
 
                 line = br.readLine();                
            }
 
 
 
 
 
 
 
            br.close();
        } catch (IOException ex) {
            Logger.getLogger(DAOTextImpl.class.getName()).log(Level.SEVERE, null, ex);
        }
        return repository;
 
    }
 @Override
 
 public void store(String filename, Repository repository) {
try (PrintWriter output = new PrintWriter(filename)) {
System.out.println("blah");
System.out.println("value of repository is"+repository);
System.out.println("value of repository is"+repository.toString());
System.out.println("value of repository is"+repository.toString(DELIMITER));
 
 
output.print(repository.toString());
 
output.close();
 
} catch (FileNotFoundException ex) {
Logger.getLogger(DAOTextImpl.class.getName()).log( Level.SEVERE, null, ex);
}
 
} 
 
    private String stripQuotes(String str) {
        return str.substring(1, str.length()-1);
    }
}

Did you mean:

repository.add(city);

**Norm** · November 19th, 2018, 05:59 PM

Did you mean:

repository.add(city);

Yes. The Repository class's add method has a print statement that should output the contents of items when it is called.
Why didn't it print something? Where is the code for that add statement shown in the above quote?

In the load method, where is this print statement:

               System.out.println("value of repository is"+repository);

It used to be right after the call to add. See post#5

**Tokugawa** · November 19th, 2018, 06:06 PM

Originally Posted by Norm

Yes. The Repository class's add method has a print statement that should output the contents of items when it is called.
Why didn't it print something? Where is the code for that add statement shown in the above quote?

In the load method, where is this print statement:

               System.out.println("value of repository is"+repository);

It used to be right after the call to add. See post#5

I dont know why I didnt print something.

public class DAOTextImpl implements DAOInterface {
      private ArrayList<YearData>yeardata;
 
    static final char DELIMITER=',';   
 
 
 
 
    @Override
    public Repository load(String filename) {
 
        Repository repository = new Repository();
 
        try (BufferedReader br = new BufferedReader(new FileReader(filename))) { 
 
            String[] temp;
            String line = br.readLine();
            while(line!=null){
 
 
                temp=line.split(Character.toString(DELIMITER));        
                int id = Integer.parseInt(temp[0]);
                String cityName = stripQuotes(temp[1]);
                String country=stripQuotes(temp[2]);
                City city=new City (id, cityName, country);
 
   repository.add(city);

**Norm** · November 19th, 2018, 06:17 PM

The last post truncated the end of the load method's code.

**Tokugawa** · November 19th, 2018, 06:18 PM

 
/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package daos;
 
import java.io.BufferedReader;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.IOException;
import java.io.PrintWriter;
import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Calendar;
import java.util.Date;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;
import model.City;
import model.YearData;
 
import repositories.Repository;
 
/**
 *
 * @author mga
 */
public class DAOTextImpl implements DAOInterface {
      private ArrayList<YearData>yeardata;
 
    static final char DELIMITER=',';   
 
 
 
 
    @Override
    public Repository load(String filename) {
 
        Repository repository = new Repository();
 
        try (BufferedReader br = new BufferedReader(new FileReader(filename))) { 
 
            String[] temp;
            String line = br.readLine();
            while(line!=null){
 
 
                temp=line.split(Character.toString(DELIMITER));        
                int id = Integer.parseInt(temp[0]);
                String cityName = stripQuotes(temp[1]);
                String country=stripQuotes(temp[2]);
                City city=new City (id, cityName, country);
 
   repository.add(city);
 
 
                  /*  line=br.readLine();
                    temp=line.split(Character.toString(DELIMITER));
                    String year=stripQuotes(temp[4]);
                    float precipitation=Float.parseFloat(temp[5]);
                    int maxTemp=Integer.parseInt(temp[6]);
                    int minTemp=Integer.parseInt(temp[7]);
                    int windSpeed=Integer.parseInt(temp[8]);
                    String windDirection=stripQuotes(temp[9]);
                 YearData yeardata=new YearData(year, precipitation, maxTemp, minTemp,windSpeed, windDirection); */
 
 
 
 
                 line = br.readLine();                
            }
 
 
 
 
 
 
 
            br.close();
        } catch (IOException ex) {
            Logger.getLogger(DAOTextImpl.class.getName()).log(Level.SEVERE, null, ex);
        }
        return repository;
 
    }
 @Override
 
 public void store(String filename, Repository repository) {
try (PrintWriter output = new PrintWriter(filename)) {
System.out.println("blah");
System.out.println("value of repository is"+repository);
System.out.println("value of repository is"+repository.toString());
System.out.println("value of repository is"+repository.toString(DELIMITER));
 
 
output.print(repository.toString());
 
output.close();
 
} catch (FileNotFoundException ex) {
Logger.getLogger(DAOTextImpl.class.getName()).log( Level.SEVERE, null, ex);
}
 
} 
 
    private String stripQuotes(String str) {
        return str.substring(1, str.length()-1);
    }
}

**Norm** · November 19th, 2018, 06:35 PM

In the load method, where is this print statement:

               System.out.println("value of repository is"+repository);

It used to be right after the call to add. See post#5

Thread: Difficulty in creating/writing to a file (also, with reading file with data)

LinkBack

Thread Tools

Display

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Re: Difficulty in creating/writing to a file (also, with reading file with data)

Similar Threads

File reading/writing

Reading and writing file

Trouble with writing/reading array to/from file

file reading & writing

Reading a writing binary file