Thread: how can use timer for a loop like this?

this method is for animating the mouse from 1 button 2 another. It works but .sleep doesnt work out for my whole project. Can any 1 help me rewrite this with a timer loop im not sure how to make the timer loop stop as the whiles i have below. Another thing is that i cant set new values to a final variable inside a the actionlistener. Im quite new to java any kind of help will be appreciated. if the object timer can be use for this please let me know i don't really fully understand the use of either

 public void optimusprime(int row, int column, JButton current) throws InterruptedException {
        Point p;
        Point p2;
        double x;
        double y;
        double x2;
        double y2;
        double conx = 0;
        double m;
        double b;
        double cony;
        p = current.getLocationOnScreen();
 
        x = (int)( p.getX() + 22.5);
        y = (int)( p.getY() + 22.5);
 
        optimus((int) x, (int) y);
 
 
 
 
        p2 = mesa[row][column].getLocationOnScreen();
        x2 = (int) (p2.getX() + 22.5);
        y2 = (int) (p2.getY() + 22.5);
 
        m = (y2 - y) / (x2 - x);
        b = y - (m * x);
       conx = x;
 
 
       if (x2>x){ 
 
           while (conx <= x2) {
 
 
            cony = (m * conx) + b;
            optimus((int) conx, (int) cony);
            conx++;
            Thread.sleep(5);
        }
       }else{
 
           while (conx >= x2) {
 
 
            cony = (m * conx) + b;
            optimus((int) conx, (int) cony);
            conx--;
            Thread.sleep(5);
        }
       }
    }
 
    public void optimus(int x, int y) {
        try {
 
 
            Robot robot = new Robot();
            robot.mouseMove(x, y);
        } catch (AWTException e) {
        }
    }

If you're doing all these things with some GUI, then your issue might be because of you invoke your loop in event dispatcher thread. If this is the case, make sure to invoke all the "heavy" stuff concurrently.

Originally Posted by guntanis

...sleep doesnt work out for my whole project...

So what does that mean? We have no idea what the project is supposed to do, and we can not run the provided snippet to see what happens.

Originally Posted by guntanis

...Can any 1 help me rewrite this with a timer loop im not sure how to make the timer loop stop as the whiles i have below.

Search for the tutorial on timers and/or swing timers. Post any remaining questions you have.

Originally Posted by guntanis

...Another thing is that i cant set new values to a final variable inside a the actionlistener.

Read the documentation on setting the value of a final variable. As it is "final" your options are limited on when and where the value can be assigned.

Originally Posted by guntanis

...sleep doesnt work out for my whole project...

So what does that mean? We have no idea what the project is supposed to do, and we can not run the provided snippet to see what happens.

Originally Posted by guntanis

...Can any 1 help me rewrite this with a timer loop im not sure how to make the timer loop stop as the whiles i have below.

Search for the tutorial on timers and/or swing timers. Post any remaining questions you have.

Originally Posted by guntanis

...Another thing is that i cant set new values to a final variable inside a the actionlistener.

Read the documentation on setting the value of a final variable. As it is "final" your options are limited on when and where the value can be assigned.

well im doing a game call ratsuk that is pretty much like chess; my problem is that once i press the button were i want to move, the icon in the "current" button most disappear and appear were i pressed. but this doesn't happen until the doclick method i use for ai presses the button. this leaves tree knights at the same time at given moment of time, which i don't want to :/

here is my code:

package ratsuk;
 
 
import java.util.Random;
import javax.swing.JFrame;
 
/**
 * import javax.swing.JFrame; import javax.swing.SwingUtilities; import
 * javax.swing.UIManager;
 */
public class Ratsuk extends JFrame {
 
    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        // TODO code application logic here
  ;
 
        Random rad;
        rad = new Random();
        int row = rad.nextInt(8);
        int column = rad.nextInt(8);
 
 
 
      Tablero newtablero = new Tablero();
        newtablero.reiniciar();
        newtablero.Knight(row, column);   
 
 
    }
 
 
}

this class is were almost everything happens i didn't post it bc its too long :/. The problem is probably inside method knight hmmmm... but i dont get why this happens.

package ratsuk;
 
import javax.swing.JFrame;
import javax.swing.JButton;
import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Random;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.swing.AbstractButton;
import javax.swing.JPanel;
import javax.swing.Icon;
import javax.swing.ImageIcon;
import javax.swing.JOptionPane;
import javax.swing.Timer;
 
/**
 *
 * @author Melvin
 */
public class Tablero {
 
    private static final int HEIGHT = 8;
    private static final int WIDTH = 8;
    private JButton[][] mesa;
    private Icon image;
    private JPanel panel;
    private JFrame ventana;
    private int contador;
    private Random rom;
    private Menu men;
    private Cursor cur;
    private Point hot;
    private Toolkit tool;
    private Image icon;
 
    public Tablero() {
        ventana = new JFrame();
        mesa = new JButton[HEIGHT][WIDTH];
        panel = new JPanel(new GridLayout(HEIGHT, WIDTH));
        image = new ImageIcon(getClass().getResource("redKnight.gif"));
        contador = 0;
        rom = new Random();
        men = new Menu();
        tool = Toolkit.getDefaultToolkit();
        icon = tool.getImage(getClass().getResource("redKnight.gif"));
        hot = new Point();
        cur = tool.createCustomCursor(icon, hot, "caballo");
        crearventana();
 
        crearmesa();
 
        pintarmesa();
    }
 
    private void crearventana() {
 
        setVentana(new JFrame("Juego de Ratsuk"));
        getVentana().setVisible(true);
        getVentana().setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        getVentana().setLayout(new BorderLayout());
        getVentana().setSize(600, 650);
        getVentana().add(panel, BorderLayout.CENTER);
        getVentana().add(men.getPanel1(), BorderLayout.SOUTH);
        getVentana().add(men.getPanel2(), BorderLayout.NORTH);
        getVentana().setVisible(true);
    }
 
    private void crearmesa() {
 
        for (int row = 0; row < HEIGHT; row++) {
            for (int column = 0; column < WIDTH; column++) {
                JButton button = new JButton();
                mesa[row][column] = button;
                panel.add(button);
 
            }
        }
    }
 
    public void pintarmesa() {
        Color fondo;
        for (int r = 0; r < HEIGHT; r++) {
            for (int t = 0; t < WIDTH; t++) {
                fondo = getBackgroundColor(r, t);
                mesa[r][t].setForeground(Color.blue);
                mesa[r][t].setBackground(fondo);
            }
        }
    }
 
    private Color getBackgroundColor(int r, int t) {
        Color fondo;
        if (r % 2 == 0 || r == 0) {
            if (t % 2 == 0 || t == 0) {
                fondo = Color.BLACK;
            } else {
                fondo = Color.WHITE;
            }
        } else {
            if (t % 2 == 0 || t == 0) {
                fondo = Color.WHITE;
            } else {
                fondo = Color.BLACK;
            }
        }
        return fondo;
    }
 
    public void Knight(final int row, final int column) {
        final JButton current = mesa[row][column];
 
        reiniciar();
 
        current.setIcon(image);
 
        current.setBackground(Color.RED);
 
 
 
 
 
        if (conclucion(row, column)) {
 
 
            // limpieza();
 
 
 
            if (contador == 0 || contador % 2 == 0) {
                JOptionPane.showMessageDialog(null, "You Lose");
            } else {
                if (contador % 2 != 0) {
                    JOptionPane.showMessageDialog(null, "You Win");
                }
            }
 
 
 
 
            men.quitarALmAtriz(mesa);
 
 
            contador = 0;
 
 
 
        } else {
 
 
 
            //  panel.repaint();
 
            acciones(row, column, current);
 
 
 
 
 
 
        }
    }
 
    public void acciones(final int row, final int column, final JButton current) {
 
 
 
        men.quitarALmAtriz(mesa);
        current.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                panel.setCursor(cur);
                men.quitarALmAtriz(mesa);
                for (int i = 0; i < HEIGHT; i++) {
                    for (int j = 0; j < WIDTH; j++) {
 
 
 
                        mesa[i][j].addActionListener(e(row, column, current));
 
 
 
                    }
                }
                if (contador % 2 != 0 && contador != 0) {
                    current.setIcon(null);
                }
            }
        });
 
 
        if (contador % 2 != 0 && contador != 0) {
 
            verificar(contador, row, column, current);
 
        }
 
 
    }
 
    public ActionListener e(final int row, final int column,
            final JButton current) {
        return new ActionListener() {
            public void actionPerformed(ActionEvent e) {
 
                if (tienebotton(row + 2, column + 1)) {
                    if (e.getSource() == mesa[row + 2][column + 1]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row + 2, column + 1);
                    }
                }
                if (tienebotton(row + 2, column - 1)) {
                    if (e.getSource() == mesa[row + 2][column - 1]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row + 2, column - 1);
                    }
                }
                if (tienebotton(row - 2, column - 1)) {
                    if (e.getSource() == mesa[row - 2][column - 1]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row - 2, column - 1);
                    }
                }
                if (tienebotton(row - 2, column + 1)) {
                    if (e.getSource() == mesa[row - 2][column + 1]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row - 2, column + 1);
                    }
                }
 
                if (tienebotton(row + 1, column + 2)) {
                    if (e.getSource() == mesa[row + 1][column + 2]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row + 1, column + 2);
                    }
                }
                if (tienebotton(row - 1, column + 2)) {
                    if (e.getSource() == mesa[row - 1][column + 2]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row - 1, column + 2);
 
 
                    }
                }
                if (tienebotton(row + 1, column - 2)) {
                    if (e.getSource() == mesa[row + 1][column - 2]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row + 1, column - 2);
                    }
                }
                if (tienebotton(row - 1, column - 2)) {
                    if (e.getSource() == mesa[row - 1][column - 2]) {
                        contador++;
                        current.setIcon(null);
                        ((AbstractButton) current).setEnabled(false);
                        panel.setCursor(Cursor.getDefaultCursor());
                        Knight(row - 1, column - 2);
                    }
                }
            }
        };
    }
 
    public boolean tienebotton(int row, int column) {
        return (row >= 0 && row < HEIGHT && column >= 0 && column < WIDTH);
 
    }
 
    public boolean conclucion(int row, int column) {
        boolean estado, estado1, estado2, estado3, estado4, estado5, estado6, estado7;
 
        if (tienebotton(row + 2, column + 1)) {
            estado = mesa[row + 2][column + 1].isEnabled();
        } else {
            estado = false;
        }
        if (tienebotton(row + 2, column - 1)) {
            estado1 = mesa[row + 2][column - 1].isEnabled();
        } else {
            estado1 = false;
        }
        if (tienebotton(row - 2, column + 1)) {
            estado2 = mesa[row - 2][column + 1].isEnabled();
        } else {
            estado2 = false;
        }
        if (tienebotton(row - 2, column - 1)) {
            estado3 = mesa[row - 2][column - 1].isEnabled();
        } else {
            estado3 = false;
        }
        if (tienebotton(row + 1, column + 2)) {
            estado4 = mesa[row + 1][column + 2].isEnabled();
        } else {
            estado4 = false;
        }
        if (tienebotton(row - 1, column + 2)) {
            estado5 = mesa[row - 1][column + 2].isEnabled();
        } else {
            estado5 = false;
        }
        if (tienebotton(row + 1, column - 2)) {
            estado6 = mesa[row + 1][column - 2].isEnabled();
        } else {
            estado6 = false;
        }
        if (tienebotton(row - 1, column - 2)) {
            estado7 = mesa[row - 1][column - 2].isEnabled();
        } else {
            estado7 = false;
        }
        return (estado == false && estado1 == false && estado2 == false && estado3 == false && estado4 == false && estado5 == false && estado6 == false && estado7 == false);
    }
 
    public void AI(int contador, int row, int column, int contador2, int[] matriz, JButton current) throws IllegalArgumentException, InterruptedException {
        int al = rom.nextInt(contador2 + 1);
 
        current.doClick();
 
        if (al == matriz[0]) {
            optimusprime(row + 2, column + 1, current);
            mesa[row + 2][column + 1].doClick();
        }
 
 
        if (al == matriz[1]) {
            optimusprime(row + 2, column - 1, current);
            mesa[row + 2][column - 1].doClick();
        }
        if (al == matriz[2]) {
            optimusprime(row - 2, column - 1, current);
            mesa[row - 2][column - 1].doClick();
        }
 
 
        if (al == matriz[3]) {
            optimusprime(row - 2, column + 1, current);
            mesa[row - 2][column + 1].doClick();
        }
 
        if (al == matriz[4]) {
            optimusprime(row + 1, column + 2, current);
            mesa[row + 1][column + 2].doClick();
        }
        if (al == matriz[5]) {
            optimusprime(row - 1, column + 2, current);
            mesa[row - 1][column + 2].doClick();
        }
 
        if (al == matriz[6]) {
            optimusprime(row + 1, column - 2, current);
            mesa[row + 1][column - 2].doClick();
        }
 
 
        if (al == matriz[7]) {
            optimusprime(row - 1, column - 2, current);
            mesa[row - 1][column - 2].doClick();
        }
 
        for (int i = 0; i < matriz.length; i++) {
 
            matriz[i] = 40;
        }
    }
 
    public void verificar(int contador, int row, int column, JButton current) {
 
        int[] matriz;
        matriz = new int[8];
        int contador2;
        contador2 = -1;
 
 
        for (int i = 0; i < matriz.length; i++) {
            matriz[i] = 40;
 
        }
 
        if (tienebotton(row + 2, column + 1)) {
            if (mesa[row + 2][column + 1].isEnabled() == true) {
 
                contador2++;
                matriz[0] = contador2;
            }
        }
        if (tienebotton(row + 2, column - 1)) {
            if (mesa[row + 2][column - 1].isEnabled() == true) {
 
                contador2++;
                matriz[1] = contador2;
            }
        }
        if (tienebotton(row - 2, column - 1)) {
            if (mesa[row - 2][column - 1].isEnabled() == true) {
 
                contador2++;
                matriz[2] = contador2;
            }
        }
        if (tienebotton(row - 2, column + 1)) {
            if (mesa[row - 2][column + 1].isEnabled() == true) {
 
                contador2++;
                matriz[3] = contador2;
            }
        }
        if (tienebotton(row + 1, column + 2)) {
            if (mesa[row + 1][column + 2].isEnabled() == true) {
                contador2++;
                matriz[4] = contador2;
            }
        }
        if (tienebotton(row - 1, column + 2)) {
            if (mesa[row - 1][column + 2].isEnabled() == true) {
                contador2++;
                matriz[5] = contador2;
            }
        }
        if (tienebotton(row + 1, column - 2)) {
            if (mesa[row + 1][column - 2].isEnabled() == true) {
                contador2++;
                matriz[6] = contador2;
            }
        }
        if (tienebotton(row - 1, column - 2)) {
            if (mesa[row - 1][column - 2].isEnabled() == true) {
                contador2++;
                matriz[7] = contador2;
            }
        }
        if (contador2 < 0) {
            contador2 = 0;
        }
        try {
            AI(contador, row, column, contador2, matriz, current);
        } catch (IllegalArgumentException | InterruptedException ex) {
            Logger.getLogger(Tablero.class.getName()).log(Level.SEVERE, null, ex);
        }
    }
 
    public void limpieza() {
        pintarmesa();
 
        for (int r = 0; r < HEIGHT; r++) {
            for (int t = 0; t < WIDTH; t++) {
 
 
                mesa[r][t].setEnabled(true);
                mesa[r][t].setIcon(null);
 
            }
        }
    }
 
    public JFrame getVentana() {
        return ventana;
 
 
    }
 
    /**
     * @param ventana the ventana to set
     */
    public void reiniciar() {
        ActionListener[] bu;
        bu = men.getReiniciar().getActionListeners();
 
        for (int k = 0; k < bu.length; k++) {
 
            men.getReiniciar().removeActionListener(bu[k]);
        }
 
 
        men.getReiniciar().addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                final int row;
                final int column;
 
                row = rom.nextInt(8);
                column = rom.nextInt(8);
                contador = 0;
                limpieza();
                men.quitarALmAtriz(mesa);
                panel.setCursor(Cursor.getDefaultCursor());
                Knight(row, column);
 
 
            }
        });
 
    }
 
    public void optimusprime(int row, int column, JButton current) throws InterruptedException {
 
        Point p;
        Point p2;
        double x;
        double y;
        double x2;
        double y2;
        double conx;
        double m;
        double b;
        double cony;
 
 
        p = current.getLocationOnScreen();
 
        x = (int) (p.getX() + 22.5);
        y = (int) (p.getY() + 22.5);
 
        optimus((int) x, (int) y);
 
 
 
 
        p2 = mesa[row][column].getLocationOnScreen();
        x2 = (int) (p2.getX() + 22.5);
        y2 = (int) (p2.getY() + 22.5);
 
        m = (y2 - y) / (x2 - x);
        b = y - (m * x);
        conx = x;
 
 
        if (x2 > x) {
 
            while (conx <= x2) {
 
 
                cony = (m * conx) + b;
                optimus((int) conx, (int) cony);
                conx++;
                Thread.sleep(5);
 
            }
        } else {
 
            while (conx >= x2) {
 
 
                cony = (m * conx) + b;
                optimus((int) conx, (int) cony);
                conx--;
                Thread.sleep(5);
 
            }
        }
    }
 
    public void optimus(int x, int y) {
        try {
 
 
            Robot robot = new Robot();
            robot.mouseMove(x, y);
        } catch (AWTException e) {
        }
    }
 
    public void setVentana(JFrame ventana) {
        this.ventana = ventana;
    }
 
    /**
     * @return the men
     */
    public Menu getMen() {
        return men;
    }
 
    /**
     * @param men the men to set
     */
    public void setMen(Menu men) {
        this.men = men;
 
    }
}

this 1 doesn't do much yet;

package ratsuk;
 
import java.awt.Dimension;
 
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
 
 
public final class Menu {
 
    private JPanel panel2;
    private JPanel panel1;
    private JButton reiniciar;
    private JButton iniciar;
    private JButton sugerencia;
    private JButton salir;
    private JButton marcador;
    private JButton guardar;
    private JButton cargar;
 
    public Menu() {
        panel1 = new JPanel(new GridLayout(0, 7, 2, 2));
        panel2 = new JPanel(new GridLayout(0, 7, 2, 2));
        reiniciar = new JButton("Restart");
        iniciar = new JButton();
        sugerencia = new JButton();
        salir = new JButton();
        marcador = new JButton();
        guardar = new JButton();
        cargar = new JButton();
        agregarbotones();
 
    }
 
    public void agregarbotones() {
 
        panel1.add(getReiniciar());
        getReiniciar().setPreferredSize(new Dimension(300, 30));
        panel2.add(sugerencia);
        sugerencia.setPreferredSize(new Dimension(300, 30));
    }
 
    public void accionesmen(final int ciclo) {
 
        getReiniciar().addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
 
            }
        });
    }
 
    public JPanel getPanel1() {
        return panel1;
    }
 
    /**
     * @param panel1 the panel1 to set
     */
    public void setPanel1(JPanel panel1) {
        this.panel1 = panel1;
    }
 
    /**
     * @return the panel2
     */
    public JPanel getPanel2() {
        return panel2;
    }
 
    /**
     * @param panel2 the panel2 to set
     */
    public void setPanel2(JPanel panel2) {
        this.panel2 = panel2;
    }
 
    /**
     * @return the reiniciar
     */
    public JButton getReiniciar() {
        return reiniciar;
    }
 
    /**
     * @param reiniciar the reiniciar to set
     */
    public void setReiniciar(JButton reiniciar) {
        this.reiniciar = reiniciar;
    }
 
public void quitarALmAtriz(JButton[][] mesa){
ActionListener[]bu;
    for (int i = 0; i < mesa.length; i++) {
            for (int j = 0; j < mesa[0].length; j++) {
                bu = mesa[i][j].getActionListeners();
                for (int k = 0; k < bu.length; k++) {
                    bu = mesa[i][j].getActionListeners();
                    mesa[i][j].removeActionListener(bu[k]);
                }
            }
}
}
}

I don't really expect any 1 to check this whole thing but any general advice in how to improve my program skills will be greatly appreciated. Im a complete noob

Originally Posted by guntanis

I don't really expect any 1 to check this whole thing

That is good, because they probably won't. See SSCCE

Best general advice I have would be to follow the execution of the program (from the start if necessary) and see where things do not go as desired. If something should show or hide at a specific point, then the line of code to show or hide that item should be up next.



I do not understand what you wrote here:

Originally Posted by guntanis

this leaves tree knights at the same time at given moment of time, which i don't want to"