Basic Calculator

Hey, I'm having some problems a basic calculator that I'm messing about with in Java. Would be appreciated if some of you guys could give me some pointers as to where I'm going wrong...

Code :

---

 import java.util.Scanner;
 
public class Calculator {
 
    Scanner kybd;
    kybd  = new Scanner(System.in);
 
    public void main(String[] args) {
 
        String calcname = "Calculator";
        System.out.println("Welcome to " + calcname + "please enter your name");
        String name = kybd.readString();
        System.out.println("Welcome. Press 1 to multiply and 2 to divide");
        int choice = kybd.readInt();
        choice = kybd.nextInt();
 
        if (choice == 1) {
            System.out.println("Enter your first number");
            int num1 = kybd.readInt();
            System.out.println("Enter your second number");
            int num2 = kybd.readInt();
            System.out.println(num1 + " times " + num2 + "equals" + num1 * num2 + ".");
        } else if (choice == 2) {
            System.out.println("Enter your first number");
            int Dnum1 = kybd.readInt();
            System.out.println("Enter your second number");
            int Dnum2 = kybd.readInt();
            System.out.println(Dnum1 + " divided by " + Dnum2 + "equals" + Dnum1 / Dnum2 + ".");
        } else {
            System.out.println("Please check your input");
        }
    }
}

---

Cheers!

You're trying to perform statements outside of a method. This is only allowed for same-line initialization.
Also, by default Java declares variables inside classes as instance fields, not static so you can't access them directly from a static method like main.

Quick fix:

move these two lines inside the main method (first two lines)

Code :

---

    Scanner kybd;
    kybd  = new Scanner(System.in);

---

Quote:

---

Originally Posted by helloworld922

You're trying to perform statements outside of a method. This is only allowed for same-line initialization.
Also, by default Java declares variables inside classes as instance fields, not static so you can't access them directly from a static method like main.

Quick fix:

move these two lines inside the main method (first two lines)

Code :

---

    Scanner kybd;
    kybd  = new Scanner(System.in);

---

---

Hey cheers for that!

The one other problem I have is I'm getting the red line under all of the readString and readInt's. Netbeans say's it can't find the symbol. Which to me just doesn't make sense...

What class are the readString() and readInt() methods members of?
What is the class of the object used with them?

Read the API doc to find the answers.
At the top of the API docs page there is an "Index" link. Click that, chose "R" and search for readInt() to see what classes have it.

Quote:

---

Originally Posted by Norm

What class are the readString() and readInt() methods members of?
What is the class of the object used with them?

Read the API doc to find the answers.
At the top of the API docs page there is an "Index" link. Click that, chose "R" and search for readInt() to see what classes have it.

---

I think I've got things a bit confused :confused:

The message that I get when I drag he cursor over the error is: cannot find symbol. symbol: method readString() location: class java util.Scanner. To me that just doesn't make sense becauase the scanner is at the top of the class- where it is usually and never causes problems like this :confused:

I am using the only one class-Calculator. I'm not using objects and such like- the whole program run's from that one class- well that's what I want it to do haha.

I'll give the API doc a look- thanks.

Quote:

---

I'm not using objects

---

Think you are. Only if you code with primitives such as int and char can you NOT use objects.
Many of the variables in your code refer to objects of class such as String and Scanner.

Quote:

---

Originally Posted by Norm

Think you are. Only if you code with primitives such as int and char can you NOT use objects.
Many of the variables in your code refer to objects of class such as String and Scanner.

---

Ok then, I don't want to be using objects. I want the program to be just one class. But, making edits to the code creates more errors and more problems it seems.

I fully understand that my ramblings about the code probably seem pretty confused - but... I'm new to this haha!

Sure, it takes time to learn the new vocabulary and terms.

Quote:

---

I don't want to be using objects

---

I'm afraid you'll have to use objects if you use the Scanner or String classes.

As far as I'm aware the Scanner (Java Platform SE 6) class does not have any read methods, only next and nextXxx methods.

// Json

Ok then cheers guys.

Would any of you be able to give me a few pointers on how to create the calculator just using the one class- It's not like I have NO code- but it seems that I have things very muddleded up haha :p

Put all your code in the main() method. Then you only define the one class that main() is in.

Quote:

---

Originally Posted by Norm

Put all your code in the main() method. Then you only define the one class that main() is in.

---

Please tell me you're not serious.

db

Read the OPs requirements. I answered his question without any comments.

You should explain to the OP about OOP and why using the main() for simple programs is a bad idea.

Quote:

---

Originally Posted by Yes.

Hey, I'm having some problems a basic calculator that I'm messing about with in Java. Would be appreciated if some of you guys could give me some pointers as to where I'm going wrong...

Code :

---

 import java.util.Scanner;
 
public class Calculator {
 
    Scanner kybd;
    kybd  = new Scanner(System.in);
 
    public void main(String[] args) {
 
        String calcname = "Calculator";
        System.out.println("Welcome to " + calcname + "please enter your name");
        String name = kybd.readString();
        System.out.println("Welcome. Press 1 to multiply and 2 to divide");
        int choice = kybd.readInt();
        choice = kybd.nextInt();
 
        if (choice == 1) {
            System.out.println("Enter your first number");
            int num1 = kybd.readInt();
            System.out.println("Enter your second number");
            int num2 = kybd.readInt();
            System.out.println(num1 + " times " + num2 + "equals" + num1 * num2 + ".");
        } else if (choice == 2) {
            System.out.println("Enter your first number");
            int Dnum1 = kybd.readInt();
            System.out.println("Enter your second number");
            int Dnum2 = kybd.readInt();
            System.out.println(Dnum1 + " divided by " + Dnum2 + "equals" + Dnum1 / Dnum2 + ".");
        } else {
            System.out.println("Please check your input");
        }
    }
}

---

Cheers!

---

Did you try static Scanner kbrd = new Scanner(System.in); ?

Also, did you have try and catch block in case it divides by zero?

Like

Code :

---

boolean isOk = false;
 
while (isOk == false)
{
try
{
num1 = kbrd.nextInt();
num2 = kbrd.nextInt();
 
num3 = num1/num2;
isOk = true;
}
 
 
 catch (InputMismatchException imeRef )
                     { // beginning of catch
                        String str ;
                        str = console.next();
                        System.out.println(   "Enter a value"
                           +" that is an integer, i.e.  not a decimal "  + 
                           "\n" + imeRef.toString());
 
                     } // end of catch
 
 
} // end of while

---