Running .JAR file issue.

This is my code:

Code JAVA:

---

//By José D. Hernández, 2013.
 
import java.io.*;
import javax.swing.*;
import java.awt.*;
 
public class PasswordDialog 
{
 
	public static void main(String[] args) throws IOException
 
	{
 
		String line, usern, passw, servdns = "108.168.227.11", check1, check2, server = "TERMSVR5", rdp = "LaUnion";
		CharSequence look = "REG_SZ", Error = "0 match(es)";
		Process p;
		Boolean stop = true, stop2 = true;
 
		Runtime runtime = Runtime.getRuntime();
		p=Runtime.getRuntime().exec("reg add HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server);
		p=Runtime.getRuntime().exec("taskkill /F /IM Reg.exe");
		Process process = runtime.exec("reg query HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Verified /t REG_SZ"); 
		InputStream is = process.getInputStream();
		InputStreamReader isr = new InputStreamReader(is);
		BufferedReader br = new BufferedReader(isr);
 
		while ((line = br.readLine()) != null && stop)
 
		{
			if(line.contains(Error))
 
			{				
				JPanel userPanel = new JPanel();
				userPanel.setLayout(new GridLayout(2,2));
 
				JLabel usernameLbl = new JLabel("Username:");
				JLabel passwordLbl = new JLabel("Password:");
				JTextField username = new JTextField();
				JTextField passwordFld = new JTextField();
 
				userPanel.add(usernameLbl);
				userPanel.add(username);
				userPanel.add(passwordLbl);
				userPanel.add(passwordFld);
 
				int input = JOptionPane.showConfirmDialog(userPanel, userPanel, "Credentials:"
						,JOptionPane.OK_CANCEL_OPTION, JOptionPane.PLAIN_MESSAGE);
 
				if (input == 0)
				{
 
					usern = username.getText();
					passw = passwordFld.getText();
 
 
					p=Runtime.getRuntime().exec("reg add HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Certified /t REG_SZ /d " + usern); 
					p=Runtime.getRuntime().exec("reg add HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Starting /t REG_SZ /d " + passw);
					p=Runtime.getRuntime().exec("reg add HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Verified /t REG_SZ /d " + servdns); 
 
					p=Runtime.getRuntime().exec("cmdkey /generic:TERMSRV/" + servdns + " /user: " + usern + " /pass: " + passw);
 
					p=Runtime.getRuntime().exec("mstsc.exe C:\\Windows\\System32\\drivers\\etc\\" + rdp + ".rdp");
				}
 
				else 
 
				{
					System.exit(0); 
				}
			}
 
			else
			{
				stop = false;
 
				p=Runtime.getRuntime().exec("reg query HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Certified"); 
 
				BufferedReader reader=new BufferedReader(new InputStreamReader(p.getInputStream())); 
 
				check1=reader.toString();
 
				while ((check1 = reader.readLine()) != null && stop2) 
				{
 
					if(check1.contains(look))
 
					{						
						String username = (check1.split(" ")[12]);
 
						p=Runtime.getRuntime().exec("reg query HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server + " /v Starting"); 
 
						BufferedReader reader2=new BufferedReader(new InputStreamReader(p.getInputStream())); 
 
						check2=reader2.toString();
 
						stop2 = false;
 
						while ((check2 = reader2.readLine()) != null) 
						{
 
							if(check2.contains(look))
 
							{						
								String password = (check2.split(" ")[12]);
 
								p=Runtime.getRuntime().exec("cmdkey /generic:TERMSRV/" + servdns + " /user: " + username + " /pass: " + password);
 
								p=Runtime.getRuntime().exec("mstsc.exe C:\\Windows\\System32\\drivers\\etc\\" + rdp + ".rdp");
							}
						}
					}
				}
				stop = true;
			}	
		}
 
		System.exit(0); 
	}
}

---

Is working just fine, it does what I want, perfect to me, when I run it in Eclipse and also when I export the program to a runable .JAR file it runs! I have Windows 7 Enterprise Edition 64x but when I try to run the same .JAR file in Windows XP Professional it get stuck...

My code create a registry key in the windows registry and the it goes on, in windows xp it only create that key, which is this part:

Code JAVA:

---

p=Runtime.getRuntime().exec("reg add HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server);

---

I tough that maybe because I'm killing the reg process after that execution, it could be the problem, but I deleted it and it was still not working.

HELP!

You shouldn't be killing the process, just wait for it to terminate normally.

Code java:

---

p = Runtime.getRuntime().exec("command");
p.waitFor(); // waits until process p terminates

---

But it never terminate, and even if I dont add that in the code, it still dont run

--- Update ---

Still don't run in windows xp

So nobody has an Idea, why is this not working on windows xp?

I don't have an XP machine to test with, but I did find this post over at stack exchange where they were able to read/write to the Windows registry without having to use JNI, reg processes, etc. It may solve your problem by simply avoiding it to begin with.

My problem is not reading or modifying the registry. (Thats what I think)

Because it actually create the registry, that I want and read from it, bot it just don't continue. As you can see in my code the first "while" is not executing which will open a dialog box and ask for some info, but that does not happen in windows xp.

--- Update ---

And I downloaded Eclipse in a windows xp machine to test if it was a 64x 32x problem and copying and pasting the code in the console, does the same thing. Thanks.

What I meant was the solution presented in that post doesn't use external processes at all. No need to worry about any processes terminating correctly or having to parse piped output, you just get your results and get on with your program.

Okay, thanks.

I'll try that.

--- Update ---

Now, I'm using the code from the link that you posted.

Let's say that you run this code:

Code JAVA:

---

String value = WinRegistry.readString (
				WinRegistry.HKEY_CURRENT_USER,                             //HKEY
				"SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Korbel\\" + server,           //Key
				"Certified");                                              //ValueName
 
		System.out.println("Value = " + value);

---

In your computer since that string does not exist, the program is going to print this out:

Code JAVA:

---

Value = null

---

Now, I want to create that string, if is not in your system.

I'm trying to user this:

Code :

---

if(value.contains("null"))
 
			{
...
}

---

But it does not do anything, meaning that the null that is printed out at the beginning is not a string, or something else that i yet don't understand.

What could the problem be? And how can I solve this? Thanks.

What variable is used to print this:
Value = null
To test that if the variable used to create the above printout is null compare it to null, not the String "null"

Code :

---

if(value == null)

---

If value was null then the following would give a NPE:

Code :

---

if(value.contains("null"))

---

What do you mean by NPE?

NPE = NullPointerException

I solved the problem by doing this:

Code JAVA:

---

if((value = Error) != null)
		{
...
 
}

---

Why not just test the value of the Error variable directly?
if(Error != null)