JComboBox

Hello,
I am trying to create a JComboBox that would change pictures. My problem is that my method always returns null and it doesn`t return my image which is located in my package. Now I would like to know if java.net.URL is used only for getting images from web page or can I use it to get image from a local folder?

Code :

---

 
        public static ImageIcon createImageIcon(String path){
 
	URL imgURL = Bikes.class.getResource(path);
 
        if (imgURL != null) {
            return new ImageIcon(imgURL);
        } else {
            System.out.println("Couldn't find file: " + path);
            System.out.println(path);
            return null;
        }
    }

---

icocijan
Sure, you can access either from the web OR from a folder or from a JAR file. The code you wrote is good for a) web, b) Jar file you can circumvent the problem as following (access URL/JAR/local folder

Code java:

---

if (!(new File(path)).exists()) return new ImageIcon(getClass().getResource(path)); // web or Jar
else return new ImageIcon(path); // local folder

---

the getClass() is probably your Bikes.class

OK, thanks for your answer. Tried that but it still won`t load the picture. Can you please tell me in which folder should I put the pictures? package folder or something else?

edit: Could there be an error in this method which calls createImageIcon method?

Code :

---

  public void updateLabel(String name) {
		ImageIcon icon = createImageIcon(name);
                 picture.setIcon(icon);
                 picture.setToolTipText(name.toLowerCase()); //sets text when mouse is over the picture (works!!!! but there is no picture only text what picture should be there !)
 
            if (icon != null) {
            picture.setText(null);
        } else { //ako nema slike postavlja natpis "Image not found"
            picture.setText("Image not found");
        }
    }

---

...tell me how the path looks like. Remember that java is CASE SENSITIVE and window isn't.

When I print it on console path is Bike 5.

When I try your code it always throws java.lang.NullPointerException. I think that is becase it never creates new File. I changed IF statement so that it runs when F exists and it always goes straight to else statement.

Code :

---

  File F = new File (path);
 
		if ( F.exists())
			{
			 System.out.println("If statement");	
			return new ImageIcon(Bikes.class.getResource(path)); // web or Jar
 
			}
		else
		{
                         System.out.println(path);
			 System.out.println("Else statement");	
			 return new ImageIcon(path); // local folder
		}

---

your path is invalid hence F is NULL and you end up with NullPointerException at the statement if (F.exists())

I know, I read that in Java tutorial NullPointerException - If the pathname argument is null. I would like to know if I need to put the pictures in a specific folder or add then to my project (tried all of the things I know).

Code java:

---

File fi = new File(path);
if (fi == null || !fi.exists()) return new ImageIcon(Bikes.class.getResource(path)); // web or Jar
else return new ImageIcon(path); // local folder

---

Quote:

---

Originally Posted by Voodoo

Code java:

---

File fi = new File(path);
if (fi == null || !fi.exists()) return new ImageIcon(Bikes.class.getResource(path)); // web or Jar
else return new ImageIcon(path); // local folder

---

---

SOLVED my problem. The whole time I gave the program Bike 5 path insted of Bike5.jpg. Didn`t realize that extensions must be added! Sorry for wasting your time and thanks for help! :D

=)) you're welcome