FILE READER PROGRAM

This is my program in which m reading from a filr with approx 40000 Strings in which m making a combination of all 40000 strings with other using a while loop but the loop is running only for first entry of the nested loop what is the problem with this code and can any body give me sugessions for such a huge loop??

Code Java:

---

package combinator;
 
import java.io.*;
 
import Reader.HandsFileReader;
 
public class FinalCombination{
 
	HandsFileReader hfr=new HandsFileReader();
	BufferedReader b,s;
	String bs1,bs2, ss;
	final String separator =System.getProperty("line.separator");
	public void finalRead(){
		try{
			FileWriter fr=new FileWriter("F:/java/Project/outputfiles/FinalCombination.txt");
 
			b=hfr.readSingle();
			s=hfr.readSamyukta();
 
				while((bs1=b.readLine())!=null){
					while((bs2=b.readLine())!=null){
						String temp=(bs1+","+bs2); 
						char []c=temp.toCharArray();
						for(int i=0;i<c.length;i++){
						fr.append(c[i]);
					}
						fr.append(separator);
				}
			while((ss=s.readLine())!=null){
				String temp=(ss+","+ss); 
				char []c=temp.toCharArray();
				for(int i=0;i<c.length;i++){
				fr.append(c[i]);
				}
				fr.append(separator);
 
			}
			fr.close();
 
		}
				}
		catch(IOException e){
			e.printStackTrace();
		}
		System.out.println("Done");
	}
	public static void main(String[] args) {
		FinalCombination fc=new FinalCombination();
		fc.finalRead();
	}
}

---

Please post in the correct forum. Thread moved to - File I/O & Other I/O Streams

You need to provide the input file and also give an example of the desired output.

Quote:

---

loop is running only for first entry of the nested loop

---

There is more than one nested loop. Please add some comments to the code explaining WHERE the problem is. Which loop executes and how many times and which loop only executes once etc.

package combinator;

import java.io.*;

import Reader.HandsFileReader;

public class FinalCombination{

HandsFileReader hfr=new HandsFileReader();
BufferedReader b1,b2,s;
String bs1,bs2, ss;
final String separator =System.getProperty("line.separator");
public void finalRead(){
try{
FileWriter fr=new FileWriter("F:/java/Project/outputfiles/FinalCombination.txt");

b1=hfr.readSingle();
b2=hfr.readSingle();
s=hfr.readSamyukta();

while((bs2=b1.readLine())!=null){
while((bs1=b2.readLine())!=null){
String temp=(bs1+","+bs2);
char []c=temp.toCharArray();
for(int i=0;i<c.length;i++){
fr.append(c[i]);
}
fr.append(separator);
}
while((ss=s.readLine())!=null){
String temp=(ss+","+ss);
char []c=temp.toCharArray();
for(int i=0;i<c.length;i++){
fr.append(c[i]);
}
fr.append(separator);

}
fr.close();

}
}
catch(IOException e){
e.printStackTrace();
}
System.out.println("Done");
}
public static void main(String[] args) {
FinalCombination fc=new FinalCombination();
fc.finalRead();
}
}


The Underlined second loop is executing only once while thw outer loop executes untill the end of the file
here is the sample of the input file


an,0,0,0,0,0,0
swa,0,0,0,0,0,0
dol,0,0,0,0,0,0
pus,0,0,0,0,0,0
katv,0,0,0,0,0,0
an,0,0,0,0,90,0
swa,0,0,0,0,90,0
dol,0,0,0,0,90,0
pus,0,0,0,0,90,0
katv,0,0,0,0,90,0
an,0,0,0,0,180,0
swa,0,0,0,0,180,0
dol,0,0,0,0,180,0
pus,0,0,0,0,180,0
katv,0,0,0,0,180,0
an,0,0,0,90,0,0
swa,0,0,0,90,0,0

total 20,000 input both the file and i want their all possible combinations



and the output i want is like this all possible combination of two files with 20,000 string entries
an,0,0,0,0,0,0swa,0,0,0,0,0,0
dol,0,0,0,0,0,0pus,0,0,0,0,0,0
katv,0,0,0,0,0,0an,0,0,0,0,90,0
swa,0,0,0,0,90,0dol,0,0,0,0,90,0
pus,0,0,0,0,90,0katv,0,0,0,0,90,0
an,0,0,0,0,180,0swa,0,0,0,0,180,0
dol,0,0,0,0,180,0pus,0,0,0,0,180,0
katv,0,0,0,0,180,0an,0,0,0,90,0,0

please suggest if dere is any other possible way to get such a huge combination

Code java:

---

while((bs1=b.readLine())!=null){
    while((bs2=b.readLine())!=null){

---

The outer loop will read the first line in the file. The inner loop will then read all the other lines in the file. Now there are no more lines to read so both loops exit. I take it this is not what you want, especially since the outer loop appears to be pointless. In that case you need to rethink your design.

i want outer loop to take one entry from the file1 den combine it with all entries in file 2 again take second entry from file 1 and combine it with all entry in file 2 and so on

while((bs1=b1.readLine())!=null){
while((bs2=b2.readLine())!=null){

Where do you initialise the BufferedReaders?

in another program in a package Reader.HeadFileReader.java with a method which has a return type BufferedReader object
u can see the buffered reader references are assingned to hfr.readSingle() hfr=HandFileReader object and readSingle() is a method with return type BufferedReader