NullPointerException in Poker's program

Hi, working on a poker program(isn't everybody?) After searching for hours on the web I'm hoping someone here can help me. Here is the problematic snippet below.

Code :

---

// this part works fine
for (Player player : players){
            player = new Player();
            player.pocketCard1 = new Card(deck.deal());
            System.out.print(player.pocketCard1.toString() + " ");
            player.pocketCard2 = new Card(deck.deal());
            System.out.print(player.pocketCard2.toString() + " ");
        }
 
// this part throws a null pointer exception
        System.out.print(players[0].pocketCard1.toString() + " ");

---

It seems like the assignments I made to pocketCard1 simply disappear when the for loop ends. Can I not use a for loop to set data members? The second piece of code does exactly the same thing as the first.
I'm pulling my hair out here.
-dean_martin

btw I forgot to introduce myself.

I am a new programmer in the San Diego area. I just graduated from a computer information systems

diploma level course and I'm close to an AA degreee. I started by learning Java, learned bits and pieces of

other languages too. Now that I have a school break, I'm going back to my Java roots to brush up.

I'm happy to see some concepts click which made no sense 7 months ago, but I feel like I don't have much

depth of knowledge, though having a slightly better breadth and flexiblity with other languages.

peace
dean_martin

Hello dean_martin and welcome to the forums :D

Could you please attach all of the code so I can compile it and see the error for myself?

Ok here is everything:

edit: I'm using NetBeans 6.5.1

Code :

---

public enum Suit {
   DIAMONDS,
   CLUBS,
   HEARTS,
   SPADES
 
}
 
public enum Rank {
    DEUCE, THREE, FOUR, FIVE, SIX, SEVEN,
    EIGHT, NINE, TEN, JACK, QUEEN, KING, ACE
}
 
public class Card{
    Rank rank;
    Suit suit;
 
    public Card(){}
 
    public Card(Card card) {
        this.rank = card.rank;
        this.suit = card.suit;
    }
 
    public Card(Rank rank, Suit suit) {
        this.rank = rank;
        this.suit = suit;
    }
 
    public Suit getSuit() {
        return suit;
    }
 
    public Rank getRank() {
        return rank;
    }
 
    @Override
    public String toString() {
        return rank + " of " + suit;
    }
}
 
public class Deck{
    Card[] cards = new Card[52];
    int index;
 
    public Deck() {
        index = 0;
        int i = 0;
        for (Suit suit : Suit.values()) {
            for (Rank rank : Rank.values()) {
                cards[i++] = new Card(rank, suit);
            }
        }
    }
 
    @Override
    public String toString(){
        String allCards = "";
        for (Card card : cards){
            allCards += card.toString() + "\n";
        }
        return allCards;
    }
 
    public void shuffle(){
        for (int i = 0; i < this.cards.length; i++){
            int randomIndex = (int) (Math.random() * this.cards.length);
            Card current = this.cards[i];            
            this.cards[i] = this.cards[randomIndex];
            this.cards[randomIndex] = current;
        }
    }    
 
    public Card deal(){
        return this.cards[index++];
    }
}
 
public class Player {
    String name;
    int bankroll;
    int chipstack;
    Card pocketCard1;
    Card pocketCard2;
    String handRank;
 
    public Player(){
    }
 
    public void setPocketCards(Card card1, Card card2){
        pocketCard1 = card1;
        pocketCard2 = card2;
    }
}
 
public class Main{
 
    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {        
        Deck deck = new Deck();
        deck.shuffle();
 
        int numberOfPlayers = 2;
        Player[] players = new Player[numberOfPlayers];
        for (Player player : players){
            player = new Player();
            player.pocketCard1 = new Card(deck.deal());
            System.out.print(player.pocketCard1.toString() + " ");
            player.pocketCard2 = new Card(deck.deal());
            System.out.print(player.pocketCard2.toString() + " ");
        }
        System.out.print(players[0].pocketCard1.toString() + " ");
 
//        for (Player player : players){
//            System.out.println("" +
//            player.pocketCard1.toString() +
//            player.pocketCard2.toString());
//        }
 
        Card[] communityCards = new Card[5];
        for (Card card : communityCards){
            card = new Card(deck.deal());
 
//        for (Card card : communityCards){
//            System.out.println(" " + card.toString());
        }
 
 
    }
 
}

---

Thanks for that dean,

I can see the exception. I will look into it now..

Dean, if this wasn't generating an exception, what is your expected output for:

Code :

---

System.out.print(players[0].pocketCard1.toString() + " ");

---

?

Quote:

---

Originally Posted by JavaPF

Dean, if this wasn't generating an exception, what is your expected output for:

Code :

---

System.out.print(players[0].pocketCard1.toString() + " ");

---

?

---

Thanks for looking into this. The program randomly shuffles the deck, so the output for:

Code :

---

System.out.print(players[0].pocketCard1.toString() + " ");

---

should be a random card name, such as:
SIX of HEARTS

I am printing the card for testing and debugging purposes. My real problem seems to be assigning values to the
pocketCard1 and pocketCard2 fields of a player object.

I changed the for loop from enhanced to regular and the exception is not being thrown anymore.
However, it feels like a patchjob and I'm not satisfied with it.

Here is the snippet from the top post, slightly modified:

Code :

---

Deck deck = new Deck();
        deck.shuffle();
 
        int numberOfPlayers = 2;
        Player[] players = new Player[numberOfPlayers];
 
/*   If I use this enhanced for loop to assign pocketCard1, I can then reference pocketCard1
 *   within the loop. Then if I try to reference pocketCard1 immediately following the loop,
 *   I get the NullPointerException
 */     
//        for (Player player : players){
//            player = new Player();
//            player.pocketCard1 = new Card(deck.deal());
//            System.out.print(player.pocketCard1.toString() + " ");          
//        }
//        System.out.print(players[0].pocketCard1.toString() + " ");// This line throws NullPointerException.
 
/*  I'm using a standard for loop to assign pocketCard1, then I can reference pocketCard1 
     from withing the for loop or afterward
        for (int i = 0; i < numberOfPlayers; i++){
            players[i] = new Player();
            players[i].pocketCard1 = new Card(deck.deal());
            System.out.print(players[i].pocketCard1.toString() + " ");
        }
        System.out.print(players[0].pocketCard1.toString() + " ");// This line does not.

---

I am trying to learn and use best practices over getting this done quickly. Therefore, I would like to understand why the enhanced for loop is not working like I think it should. I could just use the standard form, but according to the Sun Tutorial an enhanced for loop should be used when you want to cycle through each item of an array.

Hello dean,

The enhanced for loop is something that is reasonably new to myself. I have always used the regular for loop to print array data in the past. This will not cause any performance issues so there is no reason not to use regular for loops but like you say, its best practise to keep up with coding standards.

players[0] is being returned as null. I'm having a play with it now.

You will have to excuse my slow replies. I am at work so doing 10000 things at once :P

I found this on a Sun webpage.

Quote:

---

It's important to note that the enhanced for loop can't be used everywhere. You can't use the enhanced for loop:

* To remove elements as you traverse collections
* To modify the current slot in an array or list
* To iterate over multiple collections or arrays

---

I assume that trying to assign within the loop breaks the second rule. I am confused as to the reasoning
behind the rule, but my issue is solved.

Ah OK yes that makes sense. Learning new things every day!

I'm glad you have resolved this. Thank you for marking your thread as solved :)