Very simple GUI problem

Printable View

Hi,

I'm having an issue with my GUI, where 2 of the buttons appear to be overlapping. I'm trying to get the buttons to span multiple columns. It works on the other 2 buttons, but not on this one; which is weird because i practially copy and pasted the code.

I've been trying to debug this stupid button for 45min now, but with no luck. Can someone please take a look at the code and let me know what the problem is? The 'Solve' button (jSolve) overlaps with the 'EXIT' (jExit) button.

Thank you.

Code :

public class test extends JFrame {
 
	JTextField jHex1;
	JTextField jHex2;
	JTextField jHex3;
	JTextField jHex4;
	JTextField jHex5;
	JTextField jHex6;
	JTextField jHex7;
 
	JTextArea jResult;
	JButton jClear;
	JButton jSolve;
	JButton jExit;
 
 
	test()
	{
		JPanel p1 = new JPanel();
		p1.setLayout(new GridBagLayout());
 
		GridBagConstraints c = new GridBagConstraints();
		c.insets = new Insets(6,6,3,3);
 
		jHex1 = new JTextField(12);
		jHex2 = new JTextField(12);
		jHex3 = new JTextField(12);
		jHex4 = new JTextField(12);
		jHex5 = new JTextField(12);
		jHex6 = new JTextField(12);
		jHex7 = new JTextField(12);		
		jResult = new JTextArea();
		jClear = new JButton("Clear");
		jSolve = new JButton("Solve");
		jExit = new JButton("EXIT");
		JLabel label1 = new JLabel("Hex 1:");
		JLabel label2 = new JLabel("Hex 2:");
		JLabel label3 = new JLabel("Hex 3:");
		JLabel label4 = new JLabel("Hex 4:");
		JLabel label5 = new JLabel("Hex 5:");
		JLabel label6 = new JLabel("Hex 6:");
		JLabel label7 = new JLabel("Hex 7:");
 
		c.gridx = 0;
		c.gridy = 3;
		p1.add(label1, c);
		c.gridx = 3;
		c.gridy = 3;
		p1.add(jHex1, c);
 
		c.gridx = 0;
		c.gridy = 6;
		p1.add(label2, c);
		c.gridx = 3;
		c.gridy = 6;
		p1.add(jHex2, c);
 
		c.gridx = 0;
		c.gridy = 9;
		p1.add(label3, c);
		c.gridx = 3;
		c.gridy = 9;
		p1.add(jHex3, c);
 
		c.gridx = 0;
		c.gridy = 12;
		p1.add(label4, c);
		c.gridx = 3;
		c.gridy = 12;
		p1.add(jHex4, c);
 
// ****** Solve Button *******
		c.weightx = 0.0;
		c.gridwidth = GridBagConstraints.RELATIVE;
		c.fill = GridBagConstraints.HORIZONTAL;
		c.gridx = 0;
		c.gridy = 15;
		p1.add(jSolve, c);
 
		c.gridx = 15;
		c.gridy = 3;
		p1.add(label5, c);
		c.gridx = 18;
		c.gridy = 3;
		p1.add(jHex5, c);
 
		c.gridx = 15;
		c.gridy = 6;
		p1.add(label6, c);
		c.gridx = 18;
		c.gridy = 6;
		p1.add(jHex6, c);
 
		c.gridx = 15;
		c.gridy = 9;
		p1.add(label7, c);
		c.gridx = 18;
		c.gridy = 9;
		p1.add(jHex7, c);
 
		c.weightx = 0.0;
		c.gridwidth = GridBagConstraints.REMAINDER;
		c.fill = GridBagConstraints.HORIZONTAL;
		c.gridx = 15;
		c.gridy = 12;		
		p1.add(jClear, c);
 
// ****** EXIT Button *******
 
		c.weightx = 0.0;
		c.gridwidth = GridBagConstraints.REMAINDER;
		c.fill = GridBagConstraints.HORIZONTAL;
		c.gridx = 15;
		c.gridy = 15;		
		p1.add(jExit, c);
 
		add(p1);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
	    setTitle("Hex Puzzle");
		setSize(800,600);
		setVisible(true);
	}
 
 
 
   public static void main (String[] args) {
 
   new test();
 
 
 }
}

March 14th, 2012, 02:48 AM
deependeroracle

Re: Very simple GUI problem

try some different values for gridx and gridy positions
March 14th, 2012, 06:57 AM
Mr.777

Re: Very simple GUI problem
Quote:

c.gridwidth = GridBagConstraints.RELATIVE;

Try changing this line with;
Code :

c.gridwidth = GridBagConstraints.EAST;
There are many other solutions too.
March 17th, 2012, 09:53 AM
Bob_Sadarka

Re: Very simple GUI problem
Quote:
Originally Posted by Mr.777

Try changing this line with;

Code :

c.gridwidth = GridBagConstraints.EAST;

There are many other solutions too.
Complete wrong. The gridwidth property specifies how many columns on which the cell will span. So the solution is to set c.gridwidth = 2;
March 19th, 2012, 06:30 AM
Mr.777

Re: Very simple GUI problem

Quote:

Originally Posted by Bob_Sadarka

Complete wrong. The gridwidth property specifies how many columns on which the cell will span. So the solution is to set c.gridwidth = 2;

Well, first read my post carefully. I've clearly mentioned that there can be many other solutions too.
Also, will you care explaining why this solution is completely wrong?
March 19th, 2012, 02:33 PM
copeg

Re: Very simple GUI problem

Quote:

Originally Posted by Mr.777

Well, first read my post carefully. I've clearly mentioned that there can be many other solutions too.
Also, will you care explaining why this solution is completely wrong?

The gridwidth property specifies the number of cells in a row a component should occupy. The EAST property should be used to specify the anchor - when a component is smaller than the display area this manages where the component should be anchored. EAST is defined as 13, so in affect setting the gridwidth to EAST sets the gridwidth to 13.
March 20th, 2012, 05:58 AM
Mr.777

Re: Very simple GUI problem

Quote:

Originally Posted by copeg

The gridwidth property specifies the number of cells in a row a component should occupy. The EAST property should be used to specify the anchor - when a component is smaller than the display area this manages where the component should be anchored. EAST is defined as 13, so in affect setting the gridwidth to EAST sets the gridwidth to 13.

Yeah and when i tried my given solution, it worked fine and resulted as user wanted. Also i mentioned that there might be other solutions too.
So, you mean, my given solution is completely Wrong? I will ofcourse take your opinion seriously as you've more knowledge than me.
March 20th, 2012, 09:40 AM
copeg

Re: Very simple GUI problem

Quote:

Originally Posted by Mr.777

Yeah and when i tried my given solution, it worked fine and resulted as user wanted. Also i mentioned that there might be other solutions too.
So, you mean, my given solution is completely Wrong? I will ofcourse take your opinion seriously as you've more knowledge than me.

Fair enough. Wrong is often relative, as in this case (eg it compiles and fixes the problem, but may not be best practice). The position properties of GridBagLayout should not be used for width properties, as they may result in unwanted behavior (such as a gridwith of 13). Width should be defined by the width one wishes - EAST/WEST/etc... make no sense when it comes to defining width.
March 20th, 2012, 10:37 AM
Mr.777

Re: Very simple GUI problem

Quote:

Originally Posted by copeg

Fair enough. Wrong is often relative, as in this case (eg it compiles and fixes the problem, but may not be best practice). The position properties of GridBagLayout should not be used for width properties, as they may result in unwanted behavior (such as a gridwith of 13). Width should be defined by the width one wishes - EAST/WEST/etc... make no sense when it comes to defining width.

Great. Thanks a lot.